Fix definition.cloze and text-based getMedia in handlebars being escaped #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/bug
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
StefanVukovic99
previously approved these changes
Apr 23, 2024
Kuuuube
changed the title
|
|
|
Aaaand also |
Kuuuube
changed the title
jamesmaa
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there were some other handlebars that needed fixing besides
{sentence-furigana}#733The output of definition.cloze needs to not be escaped. This requires using
{{{ }}}syntax. https://handlebarsjs.com/guide/expressions.html#html-escapingText-based
getMediaalso should not be escaped ({clipboard-text}and{selection-text}).Fixes #856