Skip to content

Add saving/loading for transforms, models, pipelines #1068

Merged
merged 13 commits into from
Jan 16, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jan 13, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  • Add saving/loading for transforms, models, pipelines
  • Add example for using saving/loading

Closing issues

@Mr-Geekman Mr-Geekman self-assigned this Jan 13, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Merging #1068 (b0a5987) into master (56990dd) will increase coverage by 0.46%.
The diff coverage is 99.00%.

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   86.03%   86.49%   +0.46%     
==========================================
  Files         163      164       +1     
  Lines        8656     8901     +245     
==========================================
+ Hits         7447     7699     +252     
+ Misses       1209     1202       -7     
Impacted Files Coverage Δ
etna/models/nn/mlp.py 100.00% <ø> (ø)
etna/core/saving.py 83.33% <83.33%> (ø)
etna/models/base.py 86.26% <88.88%> (-0.18%) ⬇️
etna/core/__init__.py 100.00% <100.00%> (ø)
etna/core/mixins.py 98.49% <100.00%> (+1.27%) ⬆️
etna/core/utils.py 97.56% <100.00%> (+1.40%) ⬆️
etna/ensembles/__init__.py 100.00% <100.00%> (ø)
etna/ensembles/direct_ensemble.py 94.64% <100.00%> (+0.09%) ⬆️
etna/ensembles/mixins.py 100.00% <100.00%> (ø)
etna/ensembles/stacking_ensemble.py 96.49% <100.00%> (+0.03%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jan 13, 2023

@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 07:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 08:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 08:57 Inactive
@Mr-Geekman Mr-Geekman added this to the Inference 2.0 milestone Jan 13, 2023
@github-actions github-actions bot temporarily deployed to pull request January 13, 2023 10:39 Inactive
@alex-hse-repository alex-hse-repository merged commit c04bf64 into master Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants