Skip to content

Fix inference tests on new segments for DeepARModel and TFTModel #1109

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Feb 10, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Set categorical encoder manually, otherwise it is set automatically without option to work with new categories.

Closing issues

Closes #1088.

@Mr-Geekman Mr-Geekman self-assigned this Feb 10, 2023
@Mr-Geekman Mr-Geekman changed the title Fix inference tests on new segments for old NNs Fix inference tests on new segments for DeepARModel and TFTModel Feb 10, 2023
@github-actions
Copy link

github-actions bot commented Feb 10, 2023

@github-actions github-actions bot temporarily deployed to pull request February 10, 2023 13:41 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (inference-v2.1@27023dd). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                Coverage Diff                @@
##             inference-v2.1    #1109   +/-   ##
=================================================
  Coverage                  ?   86.48%           
=================================================
  Files                     ?      164           
  Lines                     ?     8911           
  Branches                  ?        0           
=================================================
  Hits                      ?     7707           
  Misses                    ?     1204           
  Partials                  ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martins0n martins0n self-requested a review February 13, 2023 07:36
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mr-Geekman Mr-Geekman merged commit ccfff31 into inference-v2.1 Feb 14, 2023
@Mr-Geekman Mr-Geekman deleted the issue-1088 branch February 14, 2023 07:04
This was referenced Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants