Inference v2.1 for etna v2 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts and raise error on new segments (#1107)
# Conflicts: # .github/workflows/test.yml # CHANGELOG.md # etna/models/base.py # etna/pipeline/base.py # etna/pipeline/hierarchical_pipeline.py # etna/pipeline/pipeline.py # etna/transforms/base.py # etna/transforms/encoders/mean_segment_encoder.py # etna/transforms/encoders/segment_encoder.py # etna/transforms/math/differencing.py # etna/transforms/math/sklearn.py # etna/transforms/outliers/base.py # etna/transforms/timestamp/special_days.py # etna/transforms/utils.py # tests/test_datasets/test_dataset.py # tests/test_models/test_base.py # tests/test_models/test_inference/common.py # tests/test_models/test_inference/test_forecast.py # tests/test_models/test_inference/test_predict.py # tests/test_pipeline/test_hierarchical_pipeline.py # tests/test_transforms/test_encoders/conftest.py # tests/test_transforms/test_encoders/test_mean_segment_encoder_transform.py # tests/test_transforms/test_math/test_differencing_transform.py # tests/test_transforms/test_math/test_sklearn_transform_interface.py # tests/test_transforms/test_outliers/test_outliers_transform.py
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
🚀 Deployed on https://deploy-preview-1177--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1177 +/- ##
==========================================
+ Coverage 87.17% 87.58% +0.40%
==========================================
Files 177 177
Lines 10090 10267 +177
==========================================
+ Hits 8796 8992 +196
+ Misses 1294 1275 -19
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
added 6 commits
March 22, 2023 14:46
# Conflicts: # etna/ensembles/direct_ensemble.py # etna/ensembles/stacking_ensemble.py # etna/ensembles/voting_ensemble.py # etna/pipeline/autoregressive_pipeline.py # etna/pipeline/base.py # etna/pipeline/hierarchical_pipeline.py # etna/pipeline/pipeline.py # tests/test_ensembles/test_direct_ensemble.py # tests/test_ensembles/test_stacking_ensemble.py # tests/test_ensembles/test_voting_ensemble.py # tests/test_models/test_inference/test_forecast.py # tests/test_models/test_inference/test_predict.py # tests/test_pipeline/conftest.py # tests/test_pipeline/test_autoregressive_pipeline.py # tests/test_pipeline/test_hierarchical_pipeline.py # tests/test_pipeline/test_pipeline.py # tests/utils.py
alex-hse-repository
suggested changes
Mar 23, 2023
| @@ -390,17 +391,56 @@ def test_forecast_given_ts(model, transforms, reconciliator, product_level_const | |||
| because it is difficult to set it up for hierarchy. | |||
There was a problem hiding this comment.
Can't we use assert_pipeline_forecasts_given_ts here?
| @@ -128,8 +128,6 @@ def _forecast(self, ts: TSDataset, return_components: bool) -> TSDataset: | |||
| In each point in the future, forecast of the ensemble is forecast of base pipeline with the shortest horizon, | |||
| which covers this point. | |||
| """ | |||
| if self.ts is None: | |||
There was a problem hiding this comment.
Is it the only redundant check like this?
alex-hse-repository
approved these changes
Mar 23, 2023
brsnw250
approved these changes
Mar 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Add
refitparameter intobacktest(#1159)strideparameter intobacktest(#1165)tsintoforecastmethod of pipelines (#1071)transformmethod of transforms on subset of segments, on new segments, on future with gap (#1094)inverse_transformmethod of transforms on subset of segments, on new segments, on future with gap (#1127)Change
SeasonalMovingAverageModelfromPerSegmentModelMixin(#1132)DeadlineMovingAverageModelfromPerSegmentModelMixin(#1140)Fix
DeepARModelandTFTModel(#1109)MLPNet(#1108)MeanSegmentEncoderTransformto work with subset of segments and raise error on new segments (#1104)SegmentEncoderTransformto work with subset of segments and raise error on new segments (#1103)SklearnTransformin per-segment mode to work on subset of segments and raise error on new segments (#1107)OutliersTransformand its children to raise error on new segments (#1139)DifferencingTransformto raise error on new segments duringtransformandinverse_transformin inplace mode (#1141)DifferencingTransformtoinverse_transformwith NaNs (#1155)Closing issues