Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide background for tooltips #636

Closed
Zabooby opened this issue Sep 21, 2023 · 2 comments · Fixed by #680
Closed

Add option to hide background for tooltips #636

Zabooby opened this issue Sep 21, 2023 · 2 comments · Fixed by #680

Comments

@Zabooby
Copy link

Zabooby commented Sep 21, 2023

If some users have the background off for the title, tooltips look kinda out of place with backgrounds. As people commented in #237 we really love unreadable text. 🙃

@tomasklaen
Copy link
Owner

tomasklaen commented Sep 21, 2023

Forgot top_bar_title_opacity exists. I want to remove it for 5.0 now. Why should we have, and keep adding and maintaining more options that make text unreadable? Just look at this:

image

This happens and annoys me on Youtube almost daily, and I don't understand arguments that this should not only be developer oversight/disregard, but to have it as an option that does it on purpose?

This feature request triggers me. 💢

@Zabooby
Copy link
Author

Zabooby commented Sep 21, 2023

Totally get where you're coming from, I guess people want a ui that is as minimal as possible even if readability suffers as a result.

Maybe keep this feature request open if others are interested, like with #237.

But if you don't want to add this feature I don't mind (please keep top_bar_title_opacity though, @FichteFoll brought up good points for its existence).

tomasklaen added a commit that referenced this issue Oct 7, 2023
These options have been removed:

```
timeline_opacity
timeline_chapters_opacity
volume_opacity
speed_opacity
menu_opacity
menu_parent_opacity
top_bar_title_opacity
window_border_opacity
curtain_opacity
```

and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values.

Example:

```
opacity=timeline=0.5,title=0.5
```

List of opacity values available for override and their current defaults:

```
timeline=.9
position=1     # timeline progress or line
chapters=0.8
slider=0.9     # background of all sliders, such as volume
slider_gauge=1 # value bar of all sliders
speed=0.6
menu=1
submenu=0.4
border=1       # window border
title=1        # window title
tooltip=1      # tooltip background
thumbnail=1    # thumbnail border
curtain=0.5
```

closes #584, closes #636, closes #675
tomasklaen added a commit that referenced this issue Oct 8, 2023
These options have been removed:

```
timeline_opacity
timeline_chapters_opacity
volume_opacity
speed_opacity
menu_opacity
menu_parent_opacity
top_bar_title_opacity
window_border_opacity
curtain_opacity
```

and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values.

Example:

```
opacity=timeline=0.5,title=0.5
```

List of opacity values available for override and their current defaults:

```
timeline=.9
position=1     # timeline progress or line
chapters=0.8
slider=0.9     # background of all sliders, such as volume
slider_gauge=1 # value bar of all sliders
speed=0.6
menu=1
submenu=0.4
border=1       # window border
title=1        # window title
tooltip=1      # tooltip background
thumbnail=1    # thumbnail border
curtain=0.5
```

closes #584, closes #636, closes #675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants