Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu icon fade out #675

Conversation

christoph-heinrich
Copy link
Contributor

It also used text_opacity instead of menu_opacity like the rest of the title/search bar.

But maybe everything in that bar should use text_opacity anyway?

@tomasklaen
Copy link
Owner

But maybe everything in that bar should use text_opacity anyway?

Yes, icons are essentially text.

@christoph-heinrich
Copy link
Contributor Author

But maybe everything in that bar should use text_opacity anyway?

Yes, icons are essentially text.

But the other text in the title/search bar doesn't use text_opacity, hence my confusion.

@christoph-heinrich
Copy link
Contributor Author

I've added a commit to fix the menu_opacity and text_opacity usage.
One of those is for the highlight, not sure if we want to change that one.

@tomasklaen
Copy link
Owner

One of those is for the highlight, not sure if we want to change that one.

Since the addition of options.menu_opacity it's all a bit misnamed so it's hard to follow. It needs a refactor.

options.menu_opacity should only affect the menu background. So, we should swap current menu_opacity and text_opacity for:

  • menu_opacity - It should start at 1 for current menu, decay for (parent/sub)menus, and multiplied by self.opacity. This should be the base used by everything.
  • background_opacity = menu_opacity * options.menu_opacity - and only used by the background, so I guess we don't need it as a value.

@tomasklaen
Copy link
Owner

Don't bother with this, I'm working on the opacity options overhaul and this is in the path, so I'll include it there.

tomasklaen added a commit that referenced this pull request Oct 7, 2023
These options have been removed:

```
timeline_opacity
timeline_chapters_opacity
volume_opacity
speed_opacity
menu_opacity
menu_parent_opacity
top_bar_title_opacity
window_border_opacity
curtain_opacity
```

and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values.

Example:

```
opacity=timeline=0.5,title=0.5
```

List of opacity values available for override and their current defaults:

```
timeline=.9
position=1     # timeline progress or line
chapters=0.8
slider=0.9     # background of all sliders, such as volume
slider_gauge=1 # value bar of all sliders
speed=0.6
menu=1
submenu=0.4
border=1       # window border
title=1        # window title
tooltip=1      # tooltip background
thumbnail=1    # thumbnail border
curtain=0.5
```

closes #584, closes #636, closes #675
@christoph-heinrich
Copy link
Contributor Author

Alright I'll close it then.

tomasklaen added a commit that referenced this pull request Oct 8, 2023
These options have been removed:

```
timeline_opacity
timeline_chapters_opacity
volume_opacity
speed_opacity
menu_opacity
menu_parent_opacity
top_bar_title_opacity
window_border_opacity
curtain_opacity
```

and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values.

Example:

```
opacity=timeline=0.5,title=0.5
```

List of opacity values available for override and their current defaults:

```
timeline=.9
position=1     # timeline progress or line
chapters=0.8
slider=0.9     # background of all sliders, such as volume
slider_gauge=1 # value bar of all sliders
speed=0.6
menu=1
submenu=0.4
border=1       # window border
title=1        # window title
tooltip=1      # tooltip background
thumbnail=1    # thumbnail border
curtain=0.5
```

closes #584, closes #636, closes #675
@christoph-heinrich christoph-heinrich deleted the fix_search_icon_fade branch March 3, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants