-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: menu icon fade out #675
fix: menu icon fade out #675
Conversation
Yes, icons are essentially text. |
But the other text in the title/search bar doesn't use text_opacity, hence my confusion. |
b3c7b08
to
da9e2ae
Compare
I've added a commit to fix the menu_opacity and text_opacity usage. |
Since the addition of
|
Don't bother with this, I'm working on the opacity options overhaul and this is in the path, so I'll include it there. |
These options have been removed: ``` timeline_opacity timeline_chapters_opacity volume_opacity speed_opacity menu_opacity menu_parent_opacity top_bar_title_opacity window_border_opacity curtain_opacity ``` and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values. Example: ``` opacity=timeline=0.5,title=0.5 ``` List of opacity values available for override and their current defaults: ``` timeline=.9 position=1 # timeline progress or line chapters=0.8 slider=0.9 # background of all sliders, such as volume slider_gauge=1 # value bar of all sliders speed=0.6 menu=1 submenu=0.4 border=1 # window border title=1 # window title tooltip=1 # tooltip background thumbnail=1 # thumbnail border curtain=0.5 ``` closes #584, closes #636, closes #675
Alright I'll close it then. |
These options have been removed: ``` timeline_opacity timeline_chapters_opacity volume_opacity speed_opacity menu_opacity menu_parent_opacity top_bar_title_opacity window_border_opacity curtain_opacity ``` and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values. Example: ``` opacity=timeline=0.5,title=0.5 ``` List of opacity values available for override and their current defaults: ``` timeline=.9 position=1 # timeline progress or line chapters=0.8 slider=0.9 # background of all sliders, such as volume slider_gauge=1 # value bar of all sliders speed=0.6 menu=1 submenu=0.4 border=1 # window border title=1 # window title tooltip=1 # tooltip background thumbnail=1 # thumbnail border curtain=0.5 ``` closes #584, closes #636, closes #675
It also used
text_opacity
instead ofmenu_opacity
like the rest of the title/search bar.But maybe everything in that bar should use
text_opacity
anyway?