feat!: reworked opacity options #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options have been removed: ``` timeline_opacity timeline_chapters_opacity volume_opacity speed_opacity menu_opacity menu_parent_opacity top_bar_title_opacity window_border_opacity curtain_opacity ``` and replaced with one comma delimited `opacity` list to override all of the above and some new default opacity values. Example: ``` opacity=timeline=0.5,title=0.5 ``` List of opacity values available for override and their current defaults: ``` timeline=.9 position=1 # timeline progress or line chapters=0.8 slider=0.9 # background of all sliders, such as volume slider_gauge=1 # value bar of all sliders speed=0.6 menu=1 submenu=0.4 border=1 # window border title=1 # window title tooltip=1 # tooltip background thumbnail=1 # thumbnail border curtain=0.5 ``` closes #584, closes #636, closes #675
|
I wonder if |
|
The speed control is aesthetically (and functionally) very different from the volume slider, so it makes sense to be separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options have been removed:
and replaced with one comma delimited
opacitylist to override all of the above and some new default opacity values.Example:
List of opacity values available for override and their current defaults:
closes #584, closes #636, closes #675