Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump esp-tools (March 2021) #837

Merged
merged 17 commits into from
Jun 10, 2021
Merged

Bump esp-tools (March 2021) #837

merged 17 commits into from
Jun 10, 2021

Conversation

zitaofang
Copy link
Member

Related issue: N/A

Type of change: other enhancement

Impact: software change

Release Notes

Bump esp-tools to March 2021 version

@alonamid
Copy link
Contributor

Should this also include a bump of upstream riscv-isa-sim and riscv-pk to keep them in sync?

@zitaofang
Copy link
Member Author

This PR is ready. Check the PR listed above for submodule PR.

@alonamid
Copy link
Contributor

alonamid commented Jun 2, 2021

Could this PR also bump riscv-tools to the equivalent commits, so we can make sure that esp-tools and riscv-tools are aligned?

@zitaofang
Copy link
Member Author

Someone touched the instruction struct in the upstream Spike after my PR for multi-extension support was merged, breaking all of our custom extensions. Time is running out, so I am only modifying esp-tools (since people must use it if they want to use our extension anyway) to solve the problem for this release. I will submit another upstream PR to fix this bug, and we could merge that fix in the next bump.

@zitaofang
Copy link
Member Author

Never mind, they fixed it in the latest version of spike.

Copy link
Contributor

@alonamid alonamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suspecting there might bit a merge issue that may have overwritten some files (in particular, extension reset within spike_main/spike.cc ) , but will merge this since tests seem to pass with hwacha, and gemmini has added a workaround in the tests.

@alonamid alonamid merged commit 4338ef8 into dev Jun 10, 2021
@jerryz123 jerryz123 deleted the mar2021-esp-bump branch October 1, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants