Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in units updates from FV3 #2467

Closed
wants to merge 3 commits into from

Conversation

DWesl
Copy link

@DWesl DWesl commented Oct 11, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR updates units definitions to be machine-readable:

  • W rather than w as a symbol for watts
  • m rather than M as a symbol for meters
  • Pa rather than pa as a symbol for pascals (and hPa for hectopascals)
  • mbar rather than mb as a symbol for millibar

Commit Message:

* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

w/M^2->W/m^2 and pa->Pa and mb->mbar.
@DusanJovic-NOAA
Copy link
Collaborator

I ran a subset of tests on Hera and everything looks good. @jkbk2004 This PR is ready for review and merge. It does need new baselines.

@DusanJovic-NOAA DusanJovic-NOAA added the Baseline Updates Current baselines will be updated. label Oct 15, 2024
@DWesl DWesl marked this pull request as ready for review October 15, 2024 18:34
@DWesl
Copy link
Author

DWesl commented Oct 24, 2024

Should I merge updates from the main/develop branch into the FV3 PR, and update the hash here?

@jkbk2004
Copy link
Collaborator

Should I merge updates from the main/develop branch into the FV3 PR, and update the hash here?

@DWesl yes, please keep syncing up. I may do some pre-tests to make this pr ready to commit. We are currently working on #2445.

dpsarmie added a commit to dpsarmie/ufs-weather-model that referenced this pull request Oct 31, 2024
Pointing to FV3 branch for ufs-community#2467 to merge both PRs.
jkbk2004 pushed a commit that referenced this pull request Nov 5, 2024
* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable
@jkbk2004
Copy link
Collaborator

jkbk2004 commented Nov 5, 2024

merged with #2475

@jkbk2004 jkbk2004 closed this Nov 5, 2024
tsga added a commit to tsga/ufs-weather-model that referenced this pull request Nov 13, 2024
* develop:
  Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461)
  Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458)
  Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants