-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull in units updates from FV3 #2467
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w/M^2->W/m^2 and pa->Pa and mb->mbar.
I ran a subset of tests on Hera and everything looks good. @jkbk2004 This PR is ready for review and merge. It does need new baselines. |
Should I merge updates from the main/develop branch into the FV3 PR, and update the hash here? |
14 tasks
dpsarmie
added a commit
to dpsarmie/ufs-weather-model
that referenced
this pull request
Oct 31, 2024
Pointing to FV3 branch for ufs-community#2467 to merge both PRs.
jkbk2004
pushed a commit
that referenced
this pull request
Nov 5, 2024
* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs * UFSWM - Update units attributes in netCDF output to be machine-readable * FV3 - Update units attributes in netCDF output to be machine-readable * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable
merged with #2475 |
tsga
added a commit
to tsga/ufs-weather-model
that referenced
this pull request
Nov 13, 2024
* develop: Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461) Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458) Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
Description:
This PR updates units definitions to be machine-readable:
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: