fix!: Remove [Get|Set][Left|Top|ZIndex] methods that take DependencyObject from Canvas
#11340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
force-pushed
the
canvas-get-set-dir
branch
from
b0c5239
to
38d6e3f
Compare
github-actions
bot
added
the
platform/android 🤖
Youssef1313
force-pushed
the
canvas-get-set-dir
branch
from
38d6e3f
to
5b478ed
Compare
github-actions
bot
added
area/automation
jeromelaban
reviewed
Feb 20, 2023
Youssef1313
force-pushed
the
canvas-get-set-dir
branch
from
5b478ed
to
007dd85
Compare
Youssef1313
force-pushed
the
canvas-get-set-dir
branch
from
007dd85
to
ae28f15
Compare
jeromelaban
approved these changes
Feb 27, 2023
…yObject from `Canvas` BREAKING CHANGE: `GetLeft`, `GetTop`, `SetLeft`, `SetTop`, `GetZIndex`, and `SetZIndex` overloads that take DependencyObject are now removed. The UIElement overloads should be used instead.
Youssef1313
force-pushed
the
canvas-get-set-dir
branch
from
d1eb28f
to
5215674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
GetLeft,GetTop,SetLeft,SetTop,GetZIndex, andSetZIndexoverloads that take DependencyObject are now removed. The UIElement overloads should be used instead.GitHub Issue (If applicable): #8339
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):