Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding 50bp filter for REF/ALT on clinvar-sv import (#293) #294

Merged

feat: adding 50bp filter for REF/ALT on clinvar-sv import (#293)

5a5ae95
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: adding 50bp filter for REF/ALT on clinvar-sv import (#293) #294

feat: adding 50bp filter for REF/ALT on clinvar-sv import (#293)
5a5ae95
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Nov 16, 2023 in 0s

clippy

6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 6
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 342 in src/clinvar_sv/cli/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/clinvar_sv/cli/query.rs:342:60
    |
342 |             print_record(&mut out_writer, args.out_format, &record)?;
    |                                                            ^^^^^^^ help: change this to: `record`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 339 in src/clinvar_sv/cli/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/clinvar_sv/cli/query.rs:339:20
    |
339 |             .query(&range)
    |                    ^^^^^^ help: change this to: `range`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 279 in src/clinvar_sv/cli/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/clinvar_sv/cli/query.rs:279:48
    |
279 |         let contig = extract_chrom::from_range(&range, Some(&self.meta.genome_release))?;
    |                                                ^^^^^^ help: change this to: `range`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 53 in src/clinvar_sv/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> src/clinvar_sv/cli/import.rs:53:38
   |
53 |         Box::new(std::fs::File::open(&path_in_jsonl)?)
   |                                      ^^^^^^^^^^^^^^ help: change this to: `path_in_jsonl`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 50 in src/clinvar_sv/cli/import.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> src/clinvar_sv/cli/import.rs:50:13
   |
50 |             &path_in_jsonl,
   |             ^^^^^^^^^^^^^^ help: change this to: `path_in_jsonl`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 223 in src/clinvar_sv/cli/query.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant field names in struct initialization

warning: redundant field names in struct initialization
   --> src/clinvar_sv/cli/query.rs:223:13
    |
223 |             meta: meta,
    |             ^^^^^^^^^^ help: replace it with: `meta`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
    = note: `#[warn(clippy::redundant_field_names)]` on by default