Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GranularChunks conformance check #11710

Merged
merged 89 commits into from
May 20, 2020
Merged

GranularChunks conformance check #11710

merged 89 commits into from
May 20, 2020

Conversation

janicklas-ralph
Copy link
Contributor

Adding a conformance plugin the make sure users don't undo the benefits of the granularChunks config.

The plugin makes sure that minSize, maxInitialRequests values aren't overridden. Also ensures the cacheGroups - vendors, framework, libs, common, shared are maintained.

The warning and error messages do not break the build with this change. They only display a message.

cc - @prateekbh, @atcastle

janicklas-ralph and others added 30 commits September 23, 2019 15:12
@janicklas-ralph
Adding native-url package
0d24bde
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
252ff9b
@janicklas-ralph
Bumping native-url version
ec54da8
@janicklas-ralph
Upgrading native-url
bc22678
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
22fbeb7
@janicklas-ralph
Logging stats object for debugging
c74137b
@janicklas-ralph
Logging stats object for debugging
a816aff
@timneutkens
Merge branch 'canary' into native-url
465fe2d
@ijjk
Merge branch 'canary' into native-url
aa99ed0
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
50c2e7c
@janicklas-ralph
Adding try catch to the error lines
5bbf585
@janicklas-ralph
Merge branch 'native-url' of github.com:janicklas-ralph/next.js into …
49fdf55 
…native-url
@janicklas-ralph
Experimenting with regex
044dae3
@janicklas-ralph
Experimenting with regex
e45be11
@janicklas-ralph
Experimenting with regex
5458c70
@janicklas-ralph
Testing regex changes
bf44461
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
0e0f422
@janicklas-ralph
Fixing defer-script test case to not include polyfill.js
e976414
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
31c709d
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
e77df8b
@janicklas-ralph
Meging changes with existing polyfill work
96e4456
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
6134036
@janicklas-ralph
Merge branch 'canary' of github.com:zeit/next.js into native-url
587783a
@janicklas-ralph
Bumping version
8431e0a
@Timer
adjust webpack config
62c15ac
@Timer
Reduce size in size test
98f5742
@Timer
Merge branch 'canary' into native-url
9183fa2
@Timer
Remove 1kb from legacy
ba8e6da
@Timer
Merge branch 'canary' into native-url
57df7e3
@Timer
Merge branch 'canary' into native-url
0ee9952
@ijjk
Copy link
Member

ijjk commented Apr 6, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.5s 12.4s -116ms
nodeModulesSize 47.7 MB 47.7 MB ⚠️ +7.29 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 13.3s 13.2s -106ms
nodeModulesSize 47.7 MB 47.7 MB ⚠️ +7.29 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js gzip 233 kB 233 kB -187 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB ⚠️ +125 B
link.js gzip 243 kB 243 kB -74 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +171 B
withRouter.js gzip 241 kB 241 kB -12 B
Overall change 1.19 MB 1.19 MB ⚠️ +23 B

@ijjk
Copy link
Member

ijjk commented Apr 6, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11s 11.2s ⚠️ +166ms
nodeModulesSize 47.7 MB 47.7 MB ⚠️ +7.29 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 916 B 916 B ✓
link.html gzip 925 B 925 B ✓
withRouter.html gzip 914 B 914 B ✓
Overall change 2.75 kB 2.75 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.2s 11.9s -328ms
nodeModulesSize 47.7 MB 47.7 MB ⚠️ +7.29 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.3 kB 56.3 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.78 kB 4.78 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 51.5 kB 51.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.03 kB 2.03 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 594 B 594 B ✓
_error.module.js gzip 2.08 kB 2.08 kB ✓
hooks.module.js gzip 370 B 370 B ✓
index.module.js gzip 212 B 212 B ✓
link.module.js gzip 1.48 kB 1.48 kB ✓
routerDirect..dule.js gzip 271 B 271 B ✓
withRouter.m..dule.js gzip 270 B 270 B ✓
Overall change 5.28 kB 5.28 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js gzip 233 kB 233 kB ⚠️ +73 B
404.html gzip 1.32 kB 1.32 kB ✓
hooks.html gzip 956 B 956 B ✓
index.js gzip 233 kB 233 kB -251 B
link.js gzip 243 kB 243 kB ⚠️ +293 B
routerDirect.js gzip 241 kB 241 kB -64 B
withRouter.js gzip 241 kB 241 kB -254 B
Overall change 1.19 MB 1.19 MB -203 B

@ijjk
Copy link
Member

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.5s 11.5s ⚠️ +62ms
nodeModulesSize 55.5 MB 55.5 MB -8.57 kB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.966 2.07 ⚠️ +0.1
/ avg req/sec 1271.89 1207.86 -64.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.147 1.153 ⚠️ +0.01
/error-in-render avg req/sec 2179.58 2167.94 -11.64
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 926 B 926 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.8s 12.3s ⚠️ +435ms
nodeModulesSize 55.5 MB 55.5 MB -8.57 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles Overall decrease ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 557 kB 556 kB -462 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB -462 B
link.js 594 kB 593 kB -462 B
routerDirect.js 586 kB 586 kB -462 B
withRouter.js 586 kB 586 kB -462 B
Overall change 2.89 MB 2.89 MB -2.31 kB

@ijjk
Copy link
Member

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.3s 12.2s -33ms
nodeModulesSize 55.5 MB 55.5 MB ⚠️ +3.71 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.135 2.158 ⚠️ +0.02
/ avg req/sec 1170.99 1158.46 -12.53
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.25 1.223 -0.03
/error-in-render avg req/sec 2000.64 2043.89 ⚠️ +43.25
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 926 B 926 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 13s 13.2s ⚠️ +165ms
nodeModulesSize 55.5 MB 55.5 MB ⚠️ +3.71 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 15, 2020

Failing test suites

test/integration/basic/test/index.test.js

  • Basic Features > Error Recovery > should recover from errors in getInitialProps in client
  • Basic Features > Error Recovery > should recover after an error reported via SSR
Expand output

● Basic Features › Error Recovery › should recover from errors in getInitialProps in client

TIMED OUT CHECK FOR IFRAME

  388 |     }
  389 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 390 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  391 |   }, 1000 * 30)
  392 |   while (!found) {
  393 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:390:11)

● Basic Features › Error Recovery › should recover after an error reported via SSR

TIMED OUT CHECK FOR IFRAME

  388 |     }
  389 |     console.error('TIMED OUT CHECK FOR IFRAME')
> 390 |     throw new Error('TIMED OUT CHECK FOR IFRAME')
      |           ^
  391 |   }, 1000 * 30)
  392 |   while (!found) {
  393 |     try {

  at Timeout._onTimeout (lib/next-test-utils.js:390:11)

@ijjk
Copy link
Member

ijjk commented Apr 15, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.6s 11.9s ⚠️ +323ms
nodeModulesSize 55.5 MB 55.5 MB ⚠️ +3.71 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.941 2.064 ⚠️ +0.12
/ avg req/sec 1288.31 1211.41 -76.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.037 0.977 -0.06
/error-in-render avg req/sec 2411.83 2558.7 ⚠️ +146.87
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 926 B 926 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.3s 12.2s -116ms
nodeModulesSize 55.5 MB 55.5 MB ⚠️ +3.71 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.25 kB 6.25 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..5e5e.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39 kB 39 kB ✓
Overall change 56.7 kB 56.7 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 4.79 kB 4.79 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.85 kB 6.85 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
Overall change 51.4 kB 51.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.2 kB 26.2 kB ✓
Overall change 26.2 kB 26.2 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.24 kB 1.24 kB ✓
_error.js gzip 3.12 kB 3.12 kB ✓
hooks.js gzip 664 B 664 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.86 kB 7.86 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 602 B 602 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 594 kB 594 kB ✓
routerDirect.js 586 kB 586 kB ✓
withRouter.js 586 kB 586 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@Timer Timer added this to the 9.4.2 milestone May 20, 2020
Timer
Timer approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.1s 12.2s ⚠️ +111ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.165 2.09 -0.08
/ avg req/sec 1154.68 1196.37 ⚠️ +41.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.438 1.436 0
/error-in-render avg req/sec 1738.41 1740.36 ⚠️ +1.95
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 13.1s 13s -164ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 10.9s 11.4s ⚠️ +447ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.869 1.837 -0.03
/ avg req/sec 1337.94 1360.76 ⚠️ +22.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.06 1.058 0
/error-in-render avg req/sec 2358.95 2362.12 ⚠️ +3.17
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.6s 11.5s -29ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 13.6s 13.1s -512ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.26 2.196 -0.06
/ avg req/sec 1106.27 1138.54 ⚠️ +32.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.507 1.476 -0.03
/error-in-render avg req/sec 1658.71 1693.7 ⚠️ +34.99
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 13.8s 14.1s ⚠️ +278ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 10.5s 10.4s -16ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Page Load Tests Overall increase ✓
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.834 1.853 ⚠️ +0.02
/ avg req/sec 1362.81 1349.16 -13.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.189 1.178 -0.01
/error-in-render avg req/sec 2102.91 2122.13 ⚠️ +19.22
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.3s 12.1s ⚠️ +722ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 11.4s 11.6s ⚠️ +204ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Page Load Tests Overall decrease ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.932 1.959 ⚠️ +0.03
/ avg req/sec 1294.22 1276.26 -17.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.309 1.314 ⚠️ +0.01
/error-in-render avg req/sec 1909.31 1902.26 -7.05
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary janicklas-ralph/next.js native-url Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General Overall increase ⚠️
zeit/next.js canary janicklas-ralph/next.js native-url Change
buildDuration 12.4s 12.3s -63ms
nodeModulesSize 61.8 MB 61.8 MB ⚠️ +10.8 kB
Client Bundles (main, webpack, commons)
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary janicklas-ralph/next.js native-url Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary janicklas-ralph/next.js native-url Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary janicklas-ralph/next.js native-url Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary janicklas-ralph/next.js native-url Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit a17ace8 into vercel:canary May 20, 2020
@merceyz merceyz mentioned this pull request May 20, 2020
Closed
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@janicklas-ralph @chibicode
GranularChunks conformance check (vercel#11710)
247cb0e 
Adding a conformance plugin the make sure users don't undo the benefits of the granularChunks config.

The plugin makes sure that minSize, maxInitialRequests values aren't overridden. Also ensures the cacheGroups - vendors, framework, libs, common, shared are maintained.

The warning and error messages do not break the build with this change. They only display a message.

cc - @prateekbh, @atcastle
chibicode added a commit to chibicode/next.js that referenced this pull request May 21, 2020
@chibicode
Merge remote-tracking branch 'upstream/canary' into strapi-blog-starter
f4729bd 
* upstream/canary: (143 commits)
  Remove old ErrorComponent global
  Remove unnecessary loadGetInitialProps (vercel#13159)
  Remove dead events (vercel#13156)
  v9.4.2
  v9.4.2-canary.5
  Record presence of `reportWebVitals` (vercel#13155)
  Feat/remove redundant imports from examples (vercel#13062)
  Fix Windows LogBox Test (vercel#13147)
  Eliminate array destructuring assignment (vercel#13151)
  Update Create Next App to handle rename of org (vercel#13138)
  v9.4.2-canary.4
  Correctly eliminate destructuring assignment (vercel#13144)
  Fix the link for Custom Server documentation (vercel#13137)
  Upgrade Next Redux Wrapper to version 6 in examples (vercel#11802)
  Enable jest/no-try-expect (vercel#13124)
  GranularChunks conformance check (vercel#11710)
  With stitches (vercel#12677)
  chore: Remove some redundant imports (vercel#13066)
  Use `eval-source-map` for Server Side Errors (vercel#13123)
  [Examples] Fix with-yarn-workspaces Vercel deploy button (vercel#12867)
  ...
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@janicklas-ralph @rokinsky
GranularChunks conformance check (vercel#11710)
84bb360 
Adding a conformance plugin the make sure users don't undo the benefits of the granularChunks config.

The plugin makes sure that minSize, maxInitialRequests values aren't overridden. Also ensures the cacheGroups - vendors, framework, libs, common, shared are maintained.

The warning and error messages do not break the build with this change. They only display a message.

cc - @prateekbh, @atcastle
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@janicklas-ralph @ijjk @Timer @timneutkens