Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Create Next App to handle rename of org #13138

Merged
merged 4 commits into from
May 20, 2020
Merged

Update Create Next App to handle rename of org #13138

merged 4 commits into from
May 20, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented May 20, 2020

As discussed this prepares for renaming by falling back to the new name after the current one 404s which should allow transitioning over without breaking.

The https://api.github.com/repositories/70107786/contents/examples URL used in CNA should not need updating since it seems to stay the same after renaming a project which I tested against one of my test repos here changing it from next-update-loader to next-test-loader and ensuring the URL is still valid

@ijjk ijjk added this to the 9.4.2 milestone May 20, 2020
@timneutkens timneutkens changed the title Update Create Next App to handle rename Update Create Next App to handle rename of org May 20, 2020
@ijjk
Copy link
Member Author

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 11.6s 11.8s ⚠️ +233ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary ijjk/next.js cna/handle-rename Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.921 1.918 0
/ avg req/sec 1301.41 1303.68 ⚠️ +2.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.132 1.1 -0.03
/error-in-render avg req/sec 2208.52 2271.83 ⚠️ +63.31
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js cna/handle-rename Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 12.6s 12.9s ⚠️ +313ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member Author

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 13s 12.9s -30ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary ijjk/next.js cna/handle-rename Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.213 2.197 -0.02
/ avg req/sec 1129.87 1137.69 ⚠️ +7.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.48 1.416 -0.06
/error-in-render avg req/sec 1689.41 1765.85 ⚠️ +76.44
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js cna/handle-rename Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 13.8s 13.7s -114ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk ijjk mentioned this pull request May 20, 2020
Merged
@ijjk
Copy link
Member Author

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 13.1s 12.9s -232ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary ijjk/next.js cna/handle-rename Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.3 2.255 -0.04
/ avg req/sec 1086.84 1108.88 ⚠️ +22.04
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.4 1.357 -0.04
/error-in-render avg req/sec 1785.64 1841.9 ⚠️ +56.26
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary ijjk/next.js cna/handle-rename Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary ijjk/next.js cna/handle-rename Change
buildDuration 13.7s 13.9s ⚠️ +150ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary ijjk/next.js cna/handle-rename Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary ijjk/next.js cna/handle-rename Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk ijjk merged commit b325f15 into vercel:canary May 20, 2020
@ijjk ijjk deleted the cna/handle-rename branch May 20, 2020 16:52
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@ijjk @chibicode
Update Create Next App to handle rename of org (vercel#13138)
d5a6c59 
* Update Create Next App to handle rename

* Rethrow if we dont handle the error
chibicode added a commit to chibicode/next.js that referenced this pull request May 21, 2020
@chibicode
Merge remote-tracking branch 'upstream/canary' into strapi-blog-starter
f4729bd 
* upstream/canary: (143 commits)
  Remove old ErrorComponent global
  Remove unnecessary loadGetInitialProps (vercel#13159)
  Remove dead events (vercel#13156)
  v9.4.2
  v9.4.2-canary.5
  Record presence of `reportWebVitals` (vercel#13155)
  Feat/remove redundant imports from examples (vercel#13062)
  Fix Windows LogBox Test (vercel#13147)
  Eliminate array destructuring assignment (vercel#13151)
  Update Create Next App to handle rename of org (vercel#13138)
  v9.4.2-canary.4
  Correctly eliminate destructuring assignment (vercel#13144)
  Fix the link for Custom Server documentation (vercel#13137)
  Upgrade Next Redux Wrapper to version 6 in examples (vercel#11802)
  Enable jest/no-try-expect (vercel#13124)
  GranularChunks conformance check (vercel#11710)
  With stitches (vercel#12677)
  chore: Remove some redundant imports (vercel#13066)
  Use `eval-source-map` for Server Side Errors (vercel#13123)
  [Examples] Fix with-yarn-workspaces Vercel deploy button (vercel#12867)
  ...
@chibicode chibicode mentioned this pull request Jun 1, 2020
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 1, 2020
@chibicode
Remove unnecessary catch (#13639)
1f49400 
This undoes #13138 as the rename is done.
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@ijjk @rokinsky
Update Create Next App to handle rename of org (vercel#13138)
a2f2f97 
* Update Create Next App to handle rename

* Rethrow if we dont handle the error
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@chibicode @rokinsky
Remove unnecessary catch (vercel#13639)
4f8764d 
This undoes vercel#13138 as the rename is done.
LuighiV pushed a commit to openpolitica/create-openpolitica-nextjs-app that referenced this pull request May 12, 2021
@chibicode
Remove unnecessary catch (#13639)
b2d6195 
This undoes vercel/next.js#13138 as the rename is done.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ijjk @timneutkens