Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/remove redundant imports from examples #13062

Merged
merged 35 commits into from
May 20, 2020
Merged

Feat/remove redundant imports from examples #13062

merged 35 commits into from
May 20, 2020

Conversation

todortotev
Copy link
Contributor

The issue is related to 12964

Let me know if there are any changes you want me to make.

Affected examples:

with-glamor
with-graphql-hooks
with-graphql-react
with-grommet
with-http2
with-jest
with-cookie-auth-fauna
with-context-api
with-cerebral
with-aphrodite
with-apollo-and-redux
basic-css
with-carbon-components
amp-first

I would love to help more, so let me know if there is anything specific I can contribute to.

@todortotev
Removed the redundant import and named the home function
0963456
@todortotev
Changed to arrow function
a7bb74a
@todortotev
Removed the redundant imports and named the functions
0cb206a
@todortotev
Named the home page function
ada8b08
@todortotev
Removed redundant imports and named the home function
540a585
@todortotev
Named the functions
7d93d15
@todortotev
Removed redundant react import
3a8fe35
@todortotev
Removed redundant react import
f1135d4
@todortotev
Removed redundant react import
0e31055
@todortotev
Removed redundant react imports
cf85be5
@todortotev
forgot that one
fa999c6
@todortotev
removed redundant imports and removed braces from single argument fun…
c9238a6 
…ction
@todortotev
removed redundant imports
81bbcfb
@todortotev
forgot that one
366d245
@todortotev
removed redundant imports
b5aa9c0
@todortotev
removed redundant react import
175ca6e
@todortotev
removed redundant react imports
2f44f61
@todortotev
removed redundant imports
66bfa8e
@todortotev
removed redundant import and named the home function
45714bb
@todortotev
removed redundant imports
bfb0ff8
@todortotev
forgot that one
a98ba0a
@todortotev
more redundant react imports, seems like everyone is doing it lol
4fd2bfe
@todortotev
another import
4ff15d4
@todortotev
removed yet another import
573d281
@todortotev
Named the function instead of being annonymous
19a0001
@todortotev
More redundant imports
3753429
@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 12.9s 13.1s ⚠️ +201ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.154 -0.08
/ avg req/sec 1118.03 1160.46 ⚠️ +42.43
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.528 1.407 -0.12
/error-in-render avg req/sec 1636.33 1777.15 ⚠️ +140.82
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 14.4s 14.1s -235ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 851 kB 851 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 13.2s 13.4s ⚠️ +154ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.197 2.19 -0.01
/ avg req/sec 1137.82 1141.73 ⚠️ +3.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.447 1.422 -0.03
/error-in-render avg req/sec 1728.11 1757.87 ⚠️ +29.76
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 926 B 926 B ✓
link.html gzip 936 B 936 B ✓
withRouter.html gzip 923 B 923 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 14.1s 13.9s -146ms
nodeModulesSize 60.4 MB 60.4 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.71 kB 6.71 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fc14.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57.1 kB 57.1 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.74 kB 5.74 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.28 kB 3.28 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.26 kB 8.26 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.38 kB 5.38 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 851 kB 851 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 851 kB 851 kB ✓
link.js 888 kB 888 kB ✓
routerDirect.js 880 kB 880 kB ✓
withRouter.js 880 kB 880 kB ✓
Overall change 4.36 MB 4.36 MB ✓

@ijjk
Copy link
Member

ijjk commented May 18, 2020

Failing test suites

test/integration/config/test/index.test.js

  • Configuration > renders css imports
  • Configuration > should update css styles using hmr
Expand output

● Configuration › renders css imports

expect(received).toBe(expected) // Object.is equality

Expected: "100px"
Received: "200px"

  54 |         .elementByCss('.hello-world')
  55 |         .getComputedCss('font-size')
> 56 |       expect(fontSize).toBe('100px')
     |                        ^
  57 |     } finally {
  58 |       if (browser) {
  59 |         await browser.close()

  at Object.<anonymous> (integration/config/test/index.test.js:56:24)

● Configuration › should update css styles using hmr

expect(received).toBe(expected) // Object.is equality

Expected: "100px"
Received: "200px"

  119 |       const initialFontSize = await pTag.getComputedCss('font-size')
  120 | 
> 121 |       expect(initialFontSize).toBe('100px')
      |                               ^
  122 | 
  123 |       const pagePath = join(
  124 |         __dirname,

  at Object.<anonymous> (integration/config/test/index.test.js:121:31)

@Timer Timer added the examples Issue/PR related to examples label May 20, 2020
@Timer Timer added this to the 9.4.2 milestone May 20, 2020
Timer
Timer approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 10.3s 11.4s ⚠️ +1.1s
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.769 1.821 ⚠️ +0.05
/ avg req/sec 1413.53 1373.23 -40.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.13 1.278 ⚠️ +0.15
/error-in-render avg req/sec 2211.72 1956.88 -254.84
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 11s 10.8s -227ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 12s 12.1s ⚠️ +100ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.034 1.999 -0.03
/ avg req/sec 1229.16 1250.46 ⚠️ +21.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.192 1.18 -0.01
/error-in-render avg req/sec 2097.69 2119.08 ⚠️ +21.39
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 13.1s 12.9s -197ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 13.6s 13.7s ⚠️ +24ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.297 2.32 ⚠️ +0.02
/ avg req/sec 1088.42 1077.36 -11.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.547 1.534 -0.01
/error-in-render avg req/sec 1616.3 1629.29 ⚠️ +12.99
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 14.4s 14.3s -71ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 10.7s 10.6s -171ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.849 1.847 0
/ avg req/sec 1351.88 1353.59 ⚠️ +1.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.206 1.212 ⚠️ +0.01
/error-in-render avg req/sec 2073.6 2062.52 -11.08
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 11.5s 11.9s ⚠️ +341ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 14.5s 14s -448ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.464 2.45 -0.01
/ avg req/sec 1014.69 1020.26 ⚠️ +5.57
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.601 1.59 -0.01
/error-in-render avg req/sec 1562.01 1572.81 ⚠️ +10.8
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 15.1s 15.3s ⚠️ +145ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 12.4s 12.1s -300ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall increase ✓
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.218 2.017 -0.2
/ avg req/sec 1127.05 1239.52 ⚠️ +112.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.173 1.195 ⚠️ +0.02
/error-in-render avg req/sec 2131.16 2092.39 -38.77
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
index.html gzip 928 B 928 B ✓
link.html gzip 938 B 938 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
buildDuration 12.7s 12.9s ⚠️ +152ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 57 kB 57 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
main-HASH.module.js gzip 5.69 kB 5.69 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.5 kB 52.5 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary TodorTotev/next.js feat/remove-redundant-imports-from-examples Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@kodiakhq kodiakhq bot merged commit 7cf3c3d into vercel:canary May 20, 2020
chibicode pushed a commit to chibicode/next.js that referenced this pull request May 21, 2020
@todortotev @chibicode
Feat/remove redundant imports from examples (vercel#13062)
6fc1f5b 
The issue is related to [12964](vercel#12964)

Let me know if there are any changes you want me to make.

Affected examples:

**with-glamor
with-graphql-hooks
with-graphql-react
with-grommet
with-http2
with-jest
with-cookie-auth-fauna
with-context-api
with-cerebral
with-aphrodite
with-apollo-and-redux
basic-css
with-carbon-components
amp-first**

I would love to help more, so let me know if there is anything specific I can contribute to.
chibicode added a commit to chibicode/next.js that referenced this pull request May 21, 2020
@chibicode
Merge remote-tracking branch 'upstream/canary' into strapi-blog-starter
f4729bd 
* upstream/canary: (143 commits)
  Remove old ErrorComponent global
  Remove unnecessary loadGetInitialProps (vercel#13159)
  Remove dead events (vercel#13156)
  v9.4.2
  v9.4.2-canary.5
  Record presence of `reportWebVitals` (vercel#13155)
  Feat/remove redundant imports from examples (vercel#13062)
  Fix Windows LogBox Test (vercel#13147)
  Eliminate array destructuring assignment (vercel#13151)
  Update Create Next App to handle rename of org (vercel#13138)
  v9.4.2-canary.4
  Correctly eliminate destructuring assignment (vercel#13144)
  Fix the link for Custom Server documentation (vercel#13137)
  Upgrade Next Redux Wrapper to version 6 in examples (vercel#11802)
  Enable jest/no-try-expect (vercel#13124)
  GranularChunks conformance check (vercel#11710)
  With stitches (vercel#12677)
  chore: Remove some redundant imports (vercel#13066)
  Use `eval-source-map` for Server Side Errors (vercel#13123)
  [Examples] Fix with-yarn-workspaces Vercel deploy button (vercel#12867)
  ...
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@todortotev @rokinsky
Feat/remove redundant imports from examples (vercel#13062)
edf7c5c 
The issue is related to [12964](vercel#12964)

Let me know if there are any changes you want me to make.

Affected examples:

**with-glamor
with-graphql-hooks
with-graphql-react
with-grommet
with-http2
with-jest
with-cookie-auth-fauna
with-context-api
with-cerebral
with-aphrodite
with-apollo-and-redux
basic-css
with-carbon-components
amp-first**

I would love to help more, so let me know if there is anything specific I can contribute to.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
9.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@todortotev @ijjk @Timer