Update with-three-js example #24857
Merged
Update with-three-js example #24857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaNdTriX
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
HaNdTriX
force-pushed
the
examples/three-js
branch
from
3950ed4 to
7d6abc6
Compare
leerob
previously approved these changes
May 6, 2021
ijjk
approved these changes
May 10, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 1, 2021
## Changes - Update dependencies - Use new `useAnimations` hook - Remove next-transpile-modules in favour of drei - Refactor Components - Remove dynamic import - Enable webpack5 (by removing `next.config.js`) - Removed missing key warning ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
useAnimationshooknext.config.js)Bug
fixes #numberFeature
fixes #numberDocumentation / Examples