update with-sentry example #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Jul 28, 2018
examples/with-sentry/pages/_app.js
Outdated
|
|
||
| componentDidCatch (error, errorInfo) { | ||
| this.setState({ error }) | ||
| Raven.captureException(error, { extra: errorInfo }) |
There was a problem hiding this comment.
This should have super.componentDidCatch(error, errorInfo) and the setState should be removed. Check the with-componentdidcatch example 👍
There was a problem hiding this comment.
Got it. I guess getInitialProps won't be needed here as well.
|
rename SENTRY_DSN to SENTRY_PUBLIC_DSN, plz |
timneutkens
approved these changes
Aug 4, 2018
|
FYI @Tomekmularczyk @avdeev The sentry docs example look different than the example. I assume raven has turned into @sentry/browser but please set me know if there is some reason next.js needs to use raven instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_app.jscomponentDidCatchcatches errors during rendering phase, but not within event handlers.