Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use @sentry/browser, remove raven-js #5253

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

amytych
Copy link
Contributor

@amytych amytych commented Sep 22, 2018

No description provided.

@timneutkens timneutkens merged commit 5276734 into vercel:canary Sep 22, 2018
@timneutkens
Copy link
Member

Thanks!

@amytych amytych deleted the update-with-sentry-example branch September 22, 2018 13:54
@kachkaev
Copy link
Contributor

kachkaev commented Oct 3, 2018

I'm curious if Sentry is something that we should import and initialize in a special way instead of making it a part of the common webpack bundle.

I once had a Next.js app that was silently crashing on the client side in a small proportion of old Android devices – that happened because Intl was not polyfiled. Finding the bug was only possible because I had the google analytics script, which was configured to send a custom event on window.onerror. The users just saw static server-rendered web pages because the entire webpack-generated JS file failed. Should Sentry be something that's fetched from CDN like in good old days?

@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants