add CompileTimeInfo struct for passing compile time info #3685

sokra · 2023-02-07T22:28:42Z

extracted from #3670

Refactoring to allow to pass more compile time info next to the environment to modules.
e. g. we want to pass process.env.NODE_ENV = "development" in future

vercel · 2023-02-07T22:28:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-basic-web	🔄 Building (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 6:47PM (UTC)
examples-cra-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 6:47PM (UTC)
examples-designsystem-docs	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 6:47PM (UTC)
examples-kitchensink-blog	❌ Failed (Inspect)			Feb 15, 2023 at 6:47PM (UTC)
examples-svelte-web	❌ Failed (Inspect)			Feb 15, 2023 at 6:47PM (UTC)
examples-vite-web	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 6:47PM (UTC)
turbo-site	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 15, 2023 at 6:47PM (UTC)

3 Ignored Deployments

Name	Status	Updated
examples-native-web	⬜️ Ignored (Inspect)	Feb 15, 2023 at 6:47PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)	Feb 15, 2023 at 6:47PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)	Feb 15, 2023 at 6:47PM (UTC)

github-actions · 2023-02-07T22:47:07Z

⚠️ CI failed ⚠️

The following steps have failed in CI:

Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

github-actions · 2023-02-08T08:54:37Z

Benchmark for `3937b6b`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9547.21µs ± 118.04µs	9561.60µs ± 71.80µs	+0.15%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9665.96µs ± 81.07µs	9762.79µs ± 65.74µs	+1.00%
bench_hmr_to_commit/Turbopack RSC/1000 modules	499.35ms ± 3.55ms	492.18ms ± 1.29ms	-1.43%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9618.97µs ± 98.39µs	9681.00µs ± 90.66µs	+0.64%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8504.26µs ± 91.98µs	8602.20µs ± 42.06µs	+1.15%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8698.95µs ± 102.80µs	8734.36µs ± 71.29µs	+0.41%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8606.20µs ± 74.98µs	8785.51µs ± 90.97µs	+2.08%
bench_hydration/Turbopack RCC/1000 modules	4226.53ms ± 11.03ms	4221.23ms ± 13.56ms	-0.13%
bench_hydration/Turbopack RSC/1000 modules	3795.09ms ± 17.87ms	3831.00ms ± 19.85ms	+0.95%
bench_hydration/Turbopack SSR/1000 modules	3708.86ms ± 18.14ms	3729.11ms ± 7.56ms	+0.55%
bench_startup/Turbopack CSR/1000 modules	2783.76ms ± 10.49ms	2767.89ms ± 14.69ms	-0.57%
bench_startup/Turbopack RCC/1000 modules	2576.30ms ± 9.58ms	2563.11ms ± 7.54ms	-0.51%
bench_startup/Turbopack RSC/1000 modules	2443.31ms ± 8.48ms	2468.44ms ± 11.37ms	+1.03%
bench_startup/Turbopack SSR/1000 modules	2127.91ms ± 3.27ms	2118.17ms ± 3.46ms	-0.46%

github-actions · 2023-02-10T08:21:51Z

Benchmark for `81c8257`

Click to view benchmark

Test	Base	PR	%
bench_hmr_to_commit/Turbopack CSR/1000 modules	9340.07µs ± 77.39µs	9409.82µs ± 94.06µs	+0.75%
bench_hmr_to_commit/Turbopack RCC/1000 modules	9606.27µs ± 54.70µs	9650.61µs ± 48.60µs	+0.46%
bench_hmr_to_commit/Turbopack RSC/1000 modules	490.41ms ± 2.03ms	484.87ms ± 1.52ms	-1.13%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9577.96µs ± 86.64µs	9501.74µs ± 79.05µs	-0.80%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8423.64µs ± 87.61µs	8394.69µs ± 78.03µs	-0.34%
bench_hmr_to_eval/Turbopack RCC/1000 modules	8617.69µs ± 85.33µs	8686.37µs ± 104.25µs	+0.80%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8557.13µs ± 63.09µs	8540.91µs ± 55.16µs	-0.19%
bench_hydration/Turbopack RCC/1000 modules	4238.19ms ± 8.44ms	4213.50ms ± 10.51ms	-0.58%
bench_hydration/Turbopack RSC/1000 modules	3836.33ms ± 19.05ms	3792.83ms ± 12.09ms	-1.13%
bench_hydration/Turbopack SSR/1000 modules	3728.72ms ± 13.55ms	3698.82ms ± 16.42ms	-0.80%
bench_startup/Turbopack CSR/1000 modules	2819.41ms ± 9.28ms	2799.69ms ± 12.34ms	-0.70%
bench_startup/Turbopack RCC/1000 modules	2558.09ms ± 10.75ms	2561.21ms ± 7.28ms	+0.12%
bench_startup/Turbopack RSC/1000 modules	2473.94ms ± 9.64ms	2435.92ms ± 10.34ms	-1.54%
bench_startup/Turbopack SSR/1000 modules	2130.48ms ± 2.43ms	2127.40ms ± 3.51ms	-0.14%

github-actions · 2023-02-10T17:44:14Z

Benchmark for `ffe5d54`

Test	Base	PR	%	Significant %
bench_hydration/Turbopack SSR/1000 modules	3809.07ms ± 12.40ms	3729.86ms ± 25.87ms	-2.08%	-0.07%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.15ms ± 0.09ms	10.26ms ± 0.10ms	+1.09%
bench_hmr_to_commit/Turbopack RCC/1000 modules	10.24ms ± 0.07ms	10.31ms ± 0.09ms	+0.73%
bench_hmr_to_commit/Turbopack RSC/1000 modules	498.83ms ± 2.24ms	497.77ms ± 3.00ms	-0.21%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.30ms ± 0.09ms	10.26ms ± 0.07ms	-0.30%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9257.96µs ± 100.58µs	9237.55µs ± 111.75µs	-0.22%
bench_hmr_to_eval/Turbopack RCC/1000 modules	9365.06µs ± 72.67µs	9300.81µs ± 80.43µs	-0.69%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9246.79µs ± 79.81µs	9316.69µs ± 68.05µs	+0.76%
bench_hydration/Turbopack RCC/1000 modules	4304.34ms ± 14.78ms	4293.86ms ± 12.16ms	-0.24%
bench_hydration/Turbopack RSC/1000 modules	3932.17ms ± 19.31ms	3914.11ms ± 17.28ms	-0.46%
bench_hydration/Turbopack SSR/1000 modules	3809.07ms ± 12.40ms	3729.86ms ± 25.87ms	-2.08%	-0.07%
bench_startup/Turbopack CSR/1000 modules	2847.95ms ± 14.76ms	2819.84ms ± 8.64ms	-0.99%
bench_startup/Turbopack RCC/1000 modules	2630.84ms ± 5.82ms	2641.80ms ± 11.24ms	+0.42%
bench_startup/Turbopack RSC/1000 modules	2547.27ms ± 13.97ms	2514.06ms ± 6.57ms	-1.30%
bench_startup/Turbopack SSR/1000 modules	2157.59ms ± 3.67ms	2157.65ms ± 2.72ms	+0.00%

github-actions · 2023-02-12T18:22:39Z

Benchmark for 6ee8356

Test	Base	PR	%	Significant %
bench_hydration/Turbopack RCC/1000 modules	4359.01ms ± 12.10ms	4422.95ms ± 16.35ms	+1.47%	+0.16%
bench_hydration/Turbopack RSC/1000 modules	4017.51ms ± 15.22ms	3933.12ms ± 24.47ms	-2.10%	-0.13%
bench_startup/Turbopack RCC/1000 modules	2605.08ms ± 4.34ms	2634.72ms ± 6.15ms	+1.14%	+0.33%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.21ms ± 0.08ms	10.25ms ± 0.08ms	+0.35%
bench_hmr_to_commit/Turbopack RCC/1000 modules	11.73ms ± 0.09ms	11.99ms ± 0.19ms	+2.19%
bench_hmr_to_commit/Turbopack RSC/1000 modules	530.06ms ± 1.57ms	532.64ms ± 1.88ms	+0.49%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.25ms ± 0.10ms	10.28ms ± 0.08ms	+0.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules	9060.21µs ± 67.93µs	9090.17µs ± 104.03µs	+0.33%
bench_hmr_to_eval/Turbopack RCC/1000 modules	11.71ms ± 0.32ms	11.08ms ± 0.33ms	-5.36%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9186.94µs ± 84.91µs	9186.47µs ± 65.11µs	-0.01%
bench_hydration/Turbopack RCC/1000 modules	4359.01ms ± 12.10ms	4422.95ms ± 16.35ms	+1.47%	+0.16%
bench_hydration/Turbopack RSC/1000 modules	4017.51ms ± 15.22ms	3933.12ms ± 24.47ms	-2.10%	-0.13%
bench_hydration/Turbopack SSR/1000 modules	3768.71ms ± 35.90ms	3791.27ms ± 23.65ms	+0.60%
bench_startup/Turbopack CSR/1000 modules	2855.55ms ± 11.65ms	2860.40ms ± 13.35ms	+0.17%
bench_startup/Turbopack RCC/1000 modules	2605.08ms ± 4.34ms	2634.72ms ± 6.15ms	+1.14%	+0.33%
bench_startup/Turbopack RSC/1000 modules	2524.91ms ± 9.57ms	2521.61ms ± 9.15ms	-0.13%
bench_startup/Turbopack SSR/1000 modules	2173.38ms ± 2.14ms	2165.92ms ± 2.42ms	-0.34%

github-actions · 2023-02-15T19:57:34Z

Benchmark for `2f5b685`

Test	Base	PR	%	Significant %
bench_startup/Turbopack CSR/1000 modules	2701.88ms ± 8.12ms	2669.07ms ± 6.21ms	-1.21%	-0.16%
bench_startup/Turbopack RSC/1000 modules	2241.99ms ± 5.57ms	2207.11ms ± 7.75ms	-1.56%	-0.37%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	10.13ms ± 0.09ms	10.14ms ± 0.06ms	+0.16%
bench_hmr_to_commit/Turbopack RCC/1000 modules	12.10ms ± 0.28ms	12.42ms ± 0.26ms	+2.63%
bench_hmr_to_commit/Turbopack RSC/1000 modules	518.62ms ± 1.22ms	517.38ms ± 2.07ms	-0.24%
bench_hmr_to_commit/Turbopack SSR/1000 modules	10.33ms ± 0.09ms	10.27ms ± 0.09ms	-0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8988.77µs ± 68.31µs	9190.82µs ± 70.77µs	+2.25%
bench_hmr_to_eval/Turbopack RCC/1000 modules	10.71ms ± 0.11ms	10.80ms ± 0.09ms	+0.81%
bench_hmr_to_eval/Turbopack SSR/1000 modules	9240.35µs ± 74.15µs	9222.88µs ± 63.05µs	-0.19%
bench_hydration/Turbopack RCC/1000 modules	3862.37ms ± 21.46ms	3864.17ms ± 31.24ms	+0.05%
bench_hydration/Turbopack RSC/1000 modules	3448.99ms ± 10.23ms	3428.73ms ± 9.52ms	-0.59%
bench_hydration/Turbopack SSR/1000 modules	3537.52ms ± 12.01ms	3547.79ms ± 16.43ms	+0.29%
bench_startup/Turbopack CSR/1000 modules	2701.88ms ± 8.12ms	2669.07ms ± 6.21ms	-1.21%	-0.16%
bench_startup/Turbopack RCC/1000 modules	2297.28ms ± 5.36ms	2294.86ms ± 2.66ms	-0.11%
bench_startup/Turbopack RSC/1000 modules	2241.99ms ± 5.57ms	2207.11ms ± 7.75ms	-1.56%	-0.37%
bench_startup/Turbopack SSR/1000 modules	2105.53ms ± 2.59ms	2109.49ms ± 2.56ms	+0.19%

…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> # New Features - vercel/turborepo#3771 - vercel/turborepo#3690 # Performance - vercel/turborepo#3768 # Fixes - vercel/turborepo#3795 - vercel/turborepo#3746 - vercel/turborepo#3832 - vercel/turborepo#3827 - vercel/turborepo#3847 # Other - vercel/turborepo#3803 - vercel/turborepo#3685 - vercel/turborepo#3848 --------- Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

extracted from #3670 depends on #3685 adds the equal operators to the evaluator

…orepo#3685) extracted from vercel/turborepo#3670 Refactoring to allow to pass more compile time info next to the environment to modules. e. g. we want to pass `process.env.NODE_ENV = "development"` in future

…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator

…orepo#3685) extracted from vercel/turborepo#3670 Refactoring to allow to pass more compile time info next to the environment to modules. e. g. we want to pass `process.env.NODE_ENV = "development"` in future

…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator

…orepo#3685) extracted from vercel/turborepo#3670 Refactoring to allow to pass more compile time info next to the environment to modules. e. g. we want to pass `process.env.NODE_ENV = "development"` in future

…o#3693) extracted from vercel/turborepo#3670 depends on vercel/turborepo#3685 adds the equal operators to the evaluator

github-actions bot added the area: turbopack label Feb 7, 2023

This comment was marked as outdated.

Sign in to view

sokra force-pushed the sokra/compile-time-value-refactor branch from 79d47a1 to 2275265 Compare February 8, 2023 01:22

turbo-orchestrator bot added the team: turbopack label Feb 8, 2023

sokra force-pushed the sokra/compile-time-value-refactor branch from 2275265 to da87095 Compare February 8, 2023 01:24

sokra removed the area: turbopack label Feb 8, 2023

sokra force-pushed the sokra/compile-time-value-refactor branch from da87095 to 3bf0ce6 Compare February 8, 2023 07:40

vercel bot deployed to Preview – turbo-site February 8, 2023 07:41 View deployment

sokra mentioned this pull request Feb 8, 2023

add ==, !=, ===, !== operator support for evaluation #3693

Merged

sokra marked this pull request as ready for review February 10, 2023 07:06

sokra requested a review from a team as a code owner February 10, 2023 07:06

sokra force-pushed the sokra/compile-time-value-refactor branch from 3bf0ce6 to e05ffba Compare February 10, 2023 07:07

vercel bot deployed to Preview – turbo-site February 10, 2023 07:08 View deployment

sokra requested a review from alexkirsz February 10, 2023 10:55

sokra force-pushed the sokra/compile-time-value-refactor branch from e05ffba to 5173106 Compare February 10, 2023 16:25

add CompileTimeInfo struct for passing compile time info

8de732d

sokra force-pushed the sokra/compile-time-value-refactor branch from 5173106 to 8de732d Compare February 12, 2023 17:04

vercel bot deployed to Preview – turbo-site February 12, 2023 17:05 View deployment

jridgewell approved these changes Feb 15, 2023

View reviewed changes

Merge branch 'main' into sokra/compile-time-value-refactor

633dc5c

sokra added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 15, 2023

vercel bot had a problem deploying to Preview – examples-kitchensink-blog February 15, 2023 18:46 Failure

vercel bot deployed to Preview – examples-basic-web February 15, 2023 18:46 View deployment

vercel bot had a problem deploying to Preview – examples-svelte-web February 15, 2023 18:46 Failure

vercel bot deployed to Preview – examples-vite-web February 15, 2023 18:46 View deployment

vercel bot deployed to Preview – examples-cra-web February 15, 2023 18:46 View deployment

vercel bot deployed to Preview – examples-designsystem-docs February 15, 2023 18:46 View deployment

vercel bot deployed to Preview – turbo-site February 15, 2023 18:47 View deployment

kodiakhq bot merged commit d1cc68e into main Feb 15, 2023

kodiakhq bot deleted the sokra/compile-time-value-refactor branch February 15, 2023 19:03

jridgewell mentioned this pull request Feb 16, 2023

build(cargo): update turbopack vercel/next.js#46013

Merged

kodiakhq bot pushed a commit that referenced this pull request Feb 22, 2023

add ==, !=, ===, !== operator support for evaluation (#3693)

0b844b1

extracted from #3670 depends on #3685 adds the equal operators to the evaluator

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add CompileTimeInfo struct for passing compile time info #3685

add CompileTimeInfo struct for passing compile time info #3685

sokra commented Feb 7, 2023

vercel bot commented Feb 7, 2023 •

edited

Loading

github-actions bot commented Feb 7, 2023 •

edited

Loading

This comment was marked as outdated.

github-actions bot commented Feb 8, 2023

github-actions bot commented Feb 10, 2023

github-actions bot commented Feb 10, 2023

github-actions bot commented Feb 12, 2023

github-actions bot commented Feb 15, 2023

add CompileTimeInfo struct for passing compile time info #3685

add CompileTimeInfo struct for passing compile time info #3685

Conversation

sokra commented Feb 7, 2023

vercel bot commented Feb 7, 2023 • edited Loading

github-actions bot commented Feb 7, 2023 • edited Loading

⚠️ CI failed ⚠️

This comment was marked as outdated.

github-actions bot commented Feb 8, 2023

Benchmark for 3937b6b

github-actions bot commented Feb 10, 2023

Benchmark for 81c8257

github-actions bot commented Feb 10, 2023

Benchmark for ffe5d54

github-actions bot commented Feb 12, 2023

Benchmark for 6ee8356

github-actions bot commented Feb 15, 2023

Benchmark for 2f5b685

vercel bot commented Feb 7, 2023 •

edited

Loading

github-actions bot commented Feb 7, 2023 •

edited

Loading

Benchmark for `3937b6b`

Benchmark for `81c8257`

Benchmark for `ffe5d54`

Benchmark for `2f5b685`