Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Issue Reporters #3803

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Restore Issue Reporters #3803

merged 3 commits into from
Feb 14, 2023

Conversation

wbinnssmith
Copy link
Member

This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves ConsoleUiVc::new into an async block to prevent it from stalling.

Test Plan: Verify cargo run --bin node-file-trace -- print path/to/my/app no longer stalls.

@wbinnssmith wbinnssmith requested review from a team as code owners February 14, 2023 18:29
@vercel
Copy link

vercel bot commented Feb 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-kitchensink-blog 🔄 Building (Inspect) Feb 14, 2023 at 6:40PM (UTC)
9 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:40PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2023 at 6:40PM (UTC)

jridgewell
jridgewell approved these changes Feb 14, 2023
View reviewed changes
crates/node-file-trace/src/lib.rs Outdated Show resolved Hide resolved
@wbinnssmith wbinnssmith added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kodiakhq kodiakhq bot merged commit e4a1951 into main Feb 14, 2023
@kodiakhq kodiakhq bot deleted the wbinnssmith/revert-revert-issue-reporters branch February 14, 2023 19:10
@github-actions
Copy link
Contributor

Benchmark for 05bd2cc

Test Base PR % Significant %
bench_hydration/Turbopack RCC/1000 modules 4115.60ms ± 11.56ms 4069.36ms ± 8.57ms -1.12% -0.15%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9206.36µs ± 93.00µs 9282.72µs ± 58.26µs +0.83%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.27ms ± 0.27ms 12.44ms ± 0.18ms +1.44%
bench_hmr_to_commit/Turbopack RSC/1000 modules 501.26ms ± 2.60ms 499.14ms ± 2.00ms -0.42%
bench_hmr_to_commit/Turbopack SSR/1000 modules 9406.55µs ± 82.51µs 9455.85µs ± 70.76µs +0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8204.23µs ± 53.95µs 8312.95µs ± 69.95µs +1.33%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.20ms ± 0.35ms 10.58ms ± 0.13ms -5.52%
bench_hmr_to_eval/Turbopack SSR/1000 modules 8411.71µs ± 95.12µs 8476.42µs ± 58.14µs +0.77%
bench_hydration/Turbopack RCC/1000 modules 4115.60ms ± 11.56ms 4069.36ms ± 8.57ms -1.12% -0.15%
bench_hydration/Turbopack RSC/1000 modules 3735.86ms ± 19.86ms 3763.42ms ± 15.58ms +0.74%
bench_hydration/Turbopack SSR/1000 modules 3663.73ms ± 16.10ms 3669.55ms ± 15.10ms +0.16%
bench_startup/Turbopack CSR/1000 modules 2769.56ms ± 6.90ms 2748.30ms ± 7.38ms -0.77%
bench_startup/Turbopack RCC/1000 modules 2533.19ms ± 9.12ms 2527.01ms ± 4.70ms -0.24%
bench_startup/Turbopack RSC/1000 modules 2429.63ms ± 6.80ms 2417.61ms ± 6.29ms -0.49%
bench_startup/Turbopack SSR/1000 modules 2094.14ms ± 2.51ms 2101.13ms ± 2.08ms +0.33%

@jridgewell jridgewell mentioned this pull request Feb 16, 2023
Merged
timneutkens pushed a commit to vercel/next.js that referenced this pull request Feb 21, 2023
@jridgewell @ijjk @sokra
build(cargo): update turbopack (#46013)Co-authored-by: JJ Kasper <jj@…
a1abeaf 
…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

# New Features
- vercel/turborepo#3771
- vercel/turborepo#3690

# Performance
- vercel/turborepo#3768

# Fixes
- vercel/turborepo#3795
- vercel/turborepo#3746
- vercel/turborepo#3832
- vercel/turborepo#3827
- vercel/turborepo#3847

# Other
- vercel/turborepo#3803
- vercel/turborepo#3685
- vercel/turborepo#3848

---------

Co-authored-by: JJ Kasper <jj@jjsweb.site>
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
@wbinnssmith
Restore Issue Reporters (vercel/turborepo#3803)
6b15f83 
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling.

Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
@wbinnssmith
Restore Issue Reporters (vercel/turborepo#3803)
268c9e0 
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling.

Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
@DuCanhGH DuCanhGH mentioned this pull request Mar 15, 2023
Merged
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@wbinnssmith
Restore Issue Reporters (vercel/turborepo#3803)
e191b66 
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling.

Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@wbinnssmith
Restore Issue Reporters (vercel/turborepo#3803)
1d58530 
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling.

Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@wbinnssmith
Restore Issue Reporters (vercel/turborepo#3803)
881262a 
This restores issue reporters, addressing a bug that prevented turbo-trace from completing. This moves `ConsoleUiVc::new` into an async block to prevent it from stalling.

Test Plan: Verify `cargo run --bin node-file-trace -- print path/to/my/app` no longer stalls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbinnssmith @jridgewell