fix export * warning for client pages #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
added
the
pr: automerge
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
Benchmark for d9fd67f
Click to view full benchmark
|
sokra
force-pushed
the
sokra/fix-client-warning
branch
from
c66a4f4 to
fa9ecab
Compare
sokra
changed the title
__turbopack_export_value__ as CJS style exports
sokra
commented
Feb 14, 2023
| @@ -167,7 +167,7 @@ impl CodeGenerateable for EsmExports { | |||
| let ident = ReferencedAsset::get_ident_from_placeable(asset).await?; | |||
|
|
|||
| cjs_exports.push(quote_expr!( | |||
| "__turbopack__cjs__($arg)", | |||
| "__turbopack_cjs__($arg)", | |||
There was a problem hiding this comment.
@kdy1 I really wonder why we didn't notice that earlier...
alexkirsz
approved these changes
Feb 14, 2023
crates/turbopack-ecmascript/src/transform/server_to_client_proxy.rs
Outdated
Show resolved
Hide resolved
Benchmark for 258454d
Click to view full benchmark
|
Detect `__turbopack_export_value__` as CJS style exports fix `__turbopack_cjs__` name flag turbopackHelper in client proxy
sokra
force-pushed
the
sokra/fix-client-warning
branch
from
1f30335 to
c8734bc
Compare
Benchmark for c9a43a8
Click to view full benchmark
|
timneutkens
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 21, 2023
…jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> # New Features - vercel/turborepo#3771 - vercel/turborepo#3690 # Performance - vercel/turborepo#3768 # Fixes - vercel/turborepo#3795 - vercel/turborepo#3746 - vercel/turborepo#3832 - vercel/turborepo#3827 - vercel/turborepo#3847 # Other - vercel/turborepo#3803 - vercel/turborepo#3685 - vercel/turborepo#3848 --------- Co-authored-by: JJ Kasper <jj@jjsweb.site> Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
This gets rid of this warning when using a client component as page:
```
warning - [analyze] [project-with-next]/src/app/client/page.jsx unexpected export *
export * used with module [project-with-next]/src/app/client/page.jsx which has no exports
Typescript only: Did you want to export only types with `export type { ... } from "..."`?
```
* fix export * warning for client pages
* Detect `__turbopack_export_value__` as CJS style exports
* fix `__turbopack_cjs__` name
* flag turbopackHelper in client proxy
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
This gets rid of this warning when using a client component as page:
```
warning - [analyze] [project-with-next]/src/app/client/page.jsx unexpected export *
export * used with module [project-with-next]/src/app/client/page.jsx which has no exports
Typescript only: Did you want to export only types with `export type { ... } from "..."`?
```
* fix export * warning for client pages
* Detect `__turbopack_export_value__` as CJS style exports
* fix `__turbopack_cjs__` name
* flag turbopackHelper in client proxy
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This gets rid of this warning when using a client component as page:
```
warning - [analyze] [project-with-next]/src/app/client/page.jsx unexpected export *
export * used with module [project-with-next]/src/app/client/page.jsx which has no exports
Typescript only: Did you want to export only types with `export type { ... } from "..."`?
```
* fix export * warning for client pages
* Detect `__turbopack_export_value__` as CJS style exports
* fix `__turbopack_cjs__` name
* flag turbopackHelper in client proxy
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This gets rid of this warning when using a client component as page:
```
warning - [analyze] [project-with-next]/src/app/client/page.jsx unexpected export *
export * used with module [project-with-next]/src/app/client/page.jsx which has no exports
Typescript only: Did you want to export only types with `export type { ... } from "..."`?
```
* fix export * warning for client pages
* Detect `__turbopack_export_value__` as CJS style exports
* fix `__turbopack_cjs__` name
* flag turbopackHelper in client proxy
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
This gets rid of this warning when using a client component as page:
```
warning - [analyze] [project-with-next]/src/app/client/page.jsx unexpected export *
export * used with module [project-with-next]/src/app/client/page.jsx which has no exports
Typescript only: Did you want to export only types with `export type { ... } from "..."`?
```
* fix export * warning for client pages
* Detect `__turbopack_export_value__` as CJS style exports
* fix `__turbopack_cjs__` name
* flag turbopackHelper in client proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of this warning when using a client component as page:
__turbopack_export_value__as CJS style exports__turbopack_cjs__name