Separate tabs for Errors and Warnings in error overlay #4001

ForsakenHarmony · 2023-02-28T11:55:22Z

No description provided.

vercel · 2023-02-28T11:55:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
examples-basic-web	🔄 Building (Inspect)			Mar 2, 2023 at 4:41PM (UTC)
examples-svelte-web	🔄 Building (Inspect)			Mar 2, 2023 at 4:41PM (UTC)

8 Ignored Deployments

Name	Status	Preview	Updated
examples-cra-web	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-nonmonorepo	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-tailwind-web	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
examples-vite-web	⬜️ Ignored (Inspect)		Mar 2, 2023 at 4:41PM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Mar 2, 2023 at 4:41PM (UTC)

ForsakenHarmony · 2023-02-28T11:55:34Z

Current dependencies on/for this PR:

main
- PR Separate tabs for Errors and Warnings in error overlay #4001 👈

This comment was auto-generated by Graphite.

github-actions · 2023-02-28T12:42:05Z

🟢 CI successful 🟢

Thanks

crates/next-core/js/src/overlay/internal/container/Errors.tsx

sokra · 2023-02-28T14:30:06Z

crates/next-core/js/src/overlay/internal/container/Errors.tsx

+          [TabId.TurbopackWarnings]: turbopackWarnings.length > 0,
+          [TabId.RuntimeErrors]: hasErrors,
+        }[tabId])
+    )[0] ?? TabId.RuntimeErrors;


Suggested change

)[0] ?? TabId.RuntimeErrors;

)[0];

didn't want it to be nullable

sokra · 2023-02-28T14:30:40Z

crates/next-core/js/src/overlay/internal/container/Errors.tsx

+    if (defaultTab === TabId.TurbopackErrors) {
+      setSelectedTab(TabId.TurbopackErrors);


Suggested change

if (defaultTab === TabId.TurbopackErrors) {

setSelectedTab(TabId.TurbopackErrors);

if (defaultTab) {

setSelectedTab(defaultTab );

This is here to switch to the turbopack error tab if those appear later on, but I'm not sure if it's a good idea to have

github-actions · 2023-03-02T17:54:58Z

Benchmark for 6a263b6

Test	Base	PR	%	Significant %
bench_startup/Turbopack RSC/1000 modules	2123.65ms ± 9.58ms	2085.68ms ± 4.61ms	-1.79%	-0.46%

Click to view full benchmark

Test	Base	PR	%	Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules	9769.89µs ± 33.38µs	9815.84µs ± 68.19µs	+0.47%
bench_hmr_to_commit/Turbopack RCC/1000 modules	13.08ms ± 0.30ms	13.29ms ± 0.20ms	+1.55%
bench_hmr_to_commit/Turbopack RSC/1000 modules	510.51ms ± 1.69ms	517.72ms ± 3.01ms	+1.41%
bench_hmr_to_commit/Turbopack SSR/1000 modules	9979.86µs ± 35.72µs	9999.92µs ± 50.45µs	+0.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules	8962.38µs ± 46.35µs	8922.48µs ± 31.03µs	-0.45%
bench_hmr_to_eval/Turbopack RCC/1000 modules	11.81ms ± 0.14ms	11.72ms ± 0.11ms	-0.74%
bench_hmr_to_eval/Turbopack SSR/1000 modules	8991.32µs ± 75.15µs	9022.21µs ± 58.99µs	+0.34%
bench_hydration/Turbopack RCC/1000 modules	3687.52ms ± 10.94ms	3675.76ms ± 10.56ms	-0.32%
bench_hydration/Turbopack RSC/1000 modules	3313.47ms ± 14.11ms	3292.45ms ± 15.01ms	-0.63%
bench_hydration/Turbopack SSR/1000 modules	3349.63ms ± 7.36ms	3346.55ms ± 9.11ms	-0.09%
bench_startup/Turbopack CSR/1000 modules	2599.95ms ± 6.50ms	2584.24ms ± 8.89ms	-0.60%
bench_startup/Turbopack RCC/1000 modules	2154.57ms ± 4.54ms	2170.74ms ± 3.62ms	+0.75%
bench_startup/Turbopack RSC/1000 modules	2123.65ms ± 9.58ms	2085.68ms ± 4.61ms	-1.79%	-0.46%
bench_startup/Turbopack SSR/1000 modules	2054.12ms ± 3.22ms	2060.81ms ± 3.54ms	+0.33%

…epo#4001)

turbo-orchestrator bot added area: ci team: turbopack labels Feb 28, 2023

vercel bot deployed to Preview – turbo-site February 28, 2023 11:56 View deployment

ForsakenHarmony marked this pull request as ready for review February 28, 2023 12:06

ForsakenHarmony requested review from a team as code owners February 28, 2023 12:06

ForsakenHarmony requested review from nathanhammond and chris-olszewski February 28, 2023 12:06

sokra approved these changes Feb 28, 2023

View reviewed changes

ForsakenHarmony force-pushed the hrmny/web-509-errors-warnings-tabs-error-overlay branch from 9491ff5 to d789050 Compare February 28, 2023 16:11

vercel bot deployed to Preview – turbo-site February 28, 2023 16:13 View deployment

nathanhammond removed request for nathanhammond and chris-olszewski March 2, 2023 07:29

ForsakenHarmony force-pushed the hrmny/web-509-errors-warnings-tabs-error-overlay branch from d789050 to 362b867 Compare March 2, 2023 16:14

vercel bot deployed to Preview – turbo-site March 2, 2023 16:15 View deployment

ForsakenHarmony force-pushed the hrmny/web-509-errors-warnings-tabs-error-overlay branch from 223b93d to c6f75f4 Compare March 2, 2023 16:38

turbo-orchestrator bot removed area: ci team: turborepo labels Mar 2, 2023

Separate tabs for Errors and Warnings in error overlay

893502d

ForsakenHarmony force-pushed the hrmny/web-509-errors-warnings-tabs-error-overlay branch from c6f75f4 to 893502d Compare March 2, 2023 16:41

ForsakenHarmony removed the request for review from a team March 2, 2023 16:41

ForsakenHarmony enabled auto-merge (squash) March 2, 2023 16:41

ForsakenHarmony merged commit d48f1bc into main Mar 2, 2023

ForsakenHarmony deleted the hrmny/web-509-errors-warnings-tabs-error-overlay branch March 2, 2023 16:58

kdy1 mentioned this pull request Mar 7, 2023

Update turbopack to 230307.1 vercel/next.js#46855

Closed

kdy1 mentioned this pull request Mar 8, 2023

Update turbopack to 230308.1 vercel/next.js#46909

Merged

jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023

Separate tabs for Errors and Warnings in error overlay (vercel/turbor…

0a9b4c5

…epo#4001)

sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023

Separate tabs for Errors and Warnings in error overlay (vercel/turbor…

6d4fcae

…epo#4001)

DuCanhGH mentioned this pull request Mar 15, 2023

Fix(typedRoutes): fixed files from directories other than pages and app getting into Route vercel/next.js#47184

Merged

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024

Separate tabs for Errors and Warnings in error overlay (vercel/turbor…

7b4e2ef

…epo#4001)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024

Separate tabs for Errors and Warnings in error overlay (vercel/turbor…

617e2d2

…epo#4001)

ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024

Separate tabs for Errors and Warnings in error overlay (vercel/turbor…

9099289

…epo#4001)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate tabs for Errors and Warnings in error overlay #4001

Separate tabs for Errors and Warnings in error overlay #4001

ForsakenHarmony commented Feb 28, 2023

vercel bot commented Feb 28, 2023 •

edited

Loading

ForsakenHarmony commented Feb 28, 2023

github-actions bot commented Feb 28, 2023 •

edited

Loading

sokra Feb 28, 2023

ForsakenHarmony Feb 28, 2023

sokra Feb 28, 2023

ForsakenHarmony Feb 28, 2023

github-actions bot commented Mar 2, 2023

		if (defaultTab === TabId.TurbopackErrors) {
		setSelectedTab(TabId.TurbopackErrors);

Separate tabs for Errors and Warnings in error overlay #4001

Separate tabs for Errors and Warnings in error overlay #4001

Conversation

ForsakenHarmony commented Feb 28, 2023

vercel bot commented Feb 28, 2023 • edited Loading

ForsakenHarmony commented Feb 28, 2023

github-actions bot commented Feb 28, 2023 • edited Loading

🟢 CI successful 🟢

sokra Feb 28, 2023

Choose a reason for hiding this comment

ForsakenHarmony Feb 28, 2023

Choose a reason for hiding this comment

sokra Feb 28, 2023

Choose a reason for hiding this comment

ForsakenHarmony Feb 28, 2023

Choose a reason for hiding this comment

github-actions bot commented Mar 2, 2023

Benchmark for 6a263b6

vercel bot commented Feb 28, 2023 •

edited

Loading

github-actions bot commented Feb 28, 2023 •

edited

Loading