Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove box indirection in Ropes #4040

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Remove box indirection in Ropes #4040

merged 1 commit into from
Mar 2, 2023

Conversation

jridgewell
Copy link
Contributor

No description provided.

@jridgewell jridgewell requested a review from a team as a code owner March 1, 2023 22:28
@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Mar 1, 2023 at 10:28PM (UTC)
9 Ignored Deployments
Name Status Preview Updated
examples-basic-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Mar 1, 2023 at 10:28PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Benchmark for 3c79ee9

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9447.81µs ± 68.68µs 8907.86µs ± 20.32µs -5.72% -3.89%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.07ms ± 0.14ms 13.20ms ± 0.19ms +9.33% +3.81%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8930.10µs ± 52.44µs 9195.80µs ± 80.37µs +2.98% +0.00%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7951.57µs ± 123.18µs 8528.04µs ± 56.53µs +7.25% +2.65%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9447.81µs ± 68.68µs 8907.86µs ± 20.32µs -5.72% -3.89%
bench_hmr_to_commit/Turbopack RCC/1000 modules 12.07ms ± 0.14ms 13.20ms ± 0.19ms +9.33% +3.81%
bench_hmr_to_commit/Turbopack RSC/1000 modules 502.01ms ± 1.47ms 510.19ms ± 4.83ms +1.63%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8930.10µs ± 52.44µs 9195.80µs ± 80.37µs +2.98% +0.00%
bench_hmr_to_eval/Turbopack CSR/1000 modules 8051.74µs ± 38.74µs 8107.75µs ± 75.45µs +0.70%
bench_hmr_to_eval/Turbopack RCC/1000 modules 11.59ms ± 0.28ms 11.67ms ± 0.23ms +0.69%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7951.57µs ± 123.18µs 8528.04µs ± 56.53µs +7.25% +2.65%
bench_hydration/Turbopack RCC/1000 modules 3819.63ms ± 8.19ms 3802.87ms ± 8.71ms -0.44%
bench_hydration/Turbopack RSC/1000 modules 3445.63ms ± 10.27ms 3409.63ms ± 14.25ms -1.04%
bench_hydration/Turbopack SSR/1000 modules 3328.25ms ± 11.24ms 3318.33ms ± 8.95ms -0.30%
bench_startup/Turbopack CSR/1000 modules 2568.41ms ± 9.03ms 2547.08ms ± 7.21ms -0.83%
bench_startup/Turbopack RCC/1000 modules 2322.24ms ± 7.73ms 2302.84ms ± 6.07ms -0.84%
bench_startup/Turbopack RSC/1000 modules 2259.50ms ± 6.25ms 2243.15ms ± 8.55ms -0.72%
bench_startup/Turbopack SSR/1000 modules 2047.71ms ± 4.19ms 2048.46ms ± 4.45ms +0.04%

@jridgewell jridgewell merged commit 76e6062 into main Mar 2, 2023
@jridgewell jridgewell deleted the jrl-rope-arc branch March 2, 2023 18:41
This was referenced Mar 7, 2023
Closed
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Mar 8, 2023
@kdy1
Update turbopack to 230308.1 (#46909)
37b0349 
## Bugfixes

 - vercel/turborepo#3526
 - vercel/turborepo#4084
 - vercel/turborepo#4083
 - vercel/turborepo#4067
 - vercel/turborepo#3959
 - vercel/turborepo#4060
 - vercel/turborepo#4081
 - vercel/turborepo#4103
 - vercel/turborepo#4100
 - vercel/turborepo#4108
 - vercel/turborepo#4101
 - vercel/turborepo#4112
 - vercel/turborepo#3956
 - vercel/turborepo#4118
 - vercel/turborepo#4117

## Feature

 - vercel/turborepo#4058
  - vercel/turborepo#4013
  - vercel/turborepo#4005
  - vercel/turborepo#4001
  - vercel/turborepo#3839
  - vercel/turborepo#4017
  - vercel/turborepo#4086
  - vercel/turborepo#4067

## Performance

  - vercel/turborepo#4040
  - vercel/turborepo#4110

## Refactor

 - vercel/turborepo#4098
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@jridgewell
Remove box indirection in Ropes (vercel/turborepo#4040)
e2304e1
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@jridgewell
Remove box indirection in Ropes (vercel/turborepo#4040)
9771a60
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@jridgewell
Remove box indirection in Ropes (vercel/turborepo#4040)
fcaf999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jridgewell @wbinnssmith