Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rebase error with ESM interop #5396

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix rebase error with ESM interop #5396

merged 1 commit into from
Jun 28, 2023

Conversation

alexkirsz
Copy link
Contributor

Description

Testing Instructions

@alexkirsz alexkirsz requested a review from a team as a code owner June 27, 2023 09:17
@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 1:58pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 1:58pm
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 1:58pm

@alexkirsz alexkirsz mentioned this pull request Jun 27, 2023
Merged
@alexkirsz
Copy link
Contributor Author

alexkirsz commented Jun 27, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust checks

See workflow summary for details

@github-actions
Copy link
Contributor

Linux Benchmark for 83792e7

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 10.66ms ± 0.08ms 10.79ms ± 0.09ms +1.29%
bench_hmr_to_eval/Turbopack CSR/1000 modules 9757.20µs ± 81.57µs 10.11ms ± 0.15ms +3.66%
bench_startup/Turbopack CSR/1000 modules 1106.53ms ± 1.60ms 1094.20ms ± 6.40ms -1.11%

This was referenced Jun 27, 2023
Merged
Merged
@alexkirsz alexkirsz force-pushed the alexkirsz/web-866-fix-rebase-error branch from 512d3f1 to 12903ee Compare June 27, 2023 13:58
@sokra sokra merged commit ea64a6a into alexkirsz/web-866-fspath-extensions Jun 28, 2023
@sokra sokra deleted the alexkirsz/web-866-fix-rebase-error branch June 28, 2023 17:46
@sokra
Copy link
Member

sokra commented Jun 28, 2023

Sorry. I messed up this one...

2 similar comments
@sokra
Copy link
Member

sokra commented Jun 28, 2023

Sorry. I messed up this one...

@sokra
Copy link
Member

sokra commented Jun 28, 2023

Sorry. I messed up this one...

alexkirsz added a commit that referenced this pull request Jul 3, 2023
@alexkirsz
Fix rebase error with ESM interop (#5396)
4f8ad69 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
alexkirsz added a commit that referenced this pull request Jul 3, 2023
@alexkirsz
Fix rebase error with ESM interop (#5396)
7932175 
### Description

<!--
  ✍️ Write a short summary of your work.
  If necessary, include relevant screenshots.
-->

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
@alexkirsz alexkirsz mentioned this pull request Jul 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexkirsz @sokra