Add support for CSS client references #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
This was referenced Jun 27, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
c8daa18 to
ed15812
Compare
sokra
requested changes
Jun 27, 2023
| #[turbo_tasks::value] | ||
| #[derive(Hash, Debug)] | ||
| pub struct InternalCssAssetReference { | ||
| asset: AssetVc, |
There was a problem hiding this comment.
Suggested change
| asset: AssetVc, | |
| source: AssetVc, | |
| context: AssetContextVc, |
This should lazily process the source asset
There was a problem hiding this comment.
The asset will already have been processed at that point, as we need to process it to compute other references.
| CssModule(CssInputTransformsVc), | ||
| CssGlobal, | ||
| CssModule, | ||
| Css { |
There was a problem hiding this comment.
I think CssGlobal and CssModule are explicit enough that Css on its own is OK.
alexkirsz
force-pushed
the
alexkirsz/web-866-fix-rebase-error
branch
from
512d3f1 to
12903ee
Compare
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
ed15812 to
81d7fbf
Compare
Base automatically changed from
alexkirsz/web-866-fix-rebase-error
to
alexkirsz/web-866-fspath-extensions
June 28, 2023 17:46
alexkirsz
force-pushed
the
alexkirsz/web-866-fspath-extensions
branch
from
e195ea7 to
f5b8530
Compare
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
81d7fbf to
c433a30
Compare
Linux Benchmark for 05be8dfClick to view benchmark
|
MacOS Benchmark for 05be8df
Click to view full benchmark
|
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
f7625f3 to
4f392bd
Compare
alexkirsz
force-pushed
the
alexkirsz/web-866-fspath-extensions
branch
from
74ada12 to
fcbb760
Compare
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
4f392bd to
9487de0
Compare
Linux Benchmark for b0429e1Click to view benchmark
|
alexkirsz
force-pushed
the
alexkirsz/web-866-css-client-references
branch
from
9487de0 to
6419597
Compare
Linux Benchmark for fe4e6b3Click to view benchmark
|
MacOS Benchmark for fe4e6b3
Click to view full benchmark
|
Linux Benchmark for 320cc3fClick to view benchmark
|
MacOS Benchmark for 320cc3f
Click to view full benchmark
|
sokra
approved these changes
Jul 4, 2023
Linux Benchmark for 1fa6952Click to view benchmark
|
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 4, 2023
vercel/turborepo#5397 ## Turbopack updates * vercel/turborepo#5419 * vercel/turborepo#5397
MacOS Benchmark for 1fa6952
Click to view full benchmark
|
sokra
pushed a commit
that referenced
this pull request
Jul 4, 2023
### Description My recent change in #5397 added a way to create rules that only apply to internal references. In the process, I also made it so the default rules don't apply to internal references as well. However, we still need them to apply to TS and JS files, as we use that with ReferenceType::Internal in Next.js. ### Testing Instructions Next.js CI
shuding
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 8, 2023
vercel/turborepo#5397 ## Turbopack updates * vercel/turborepo#5419 * vercel/turborepo#5397
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description This PR changes CSS assets to support the CSS client references use case of Next.js, where .css assets in the RSC graph should be replaced with a client reference assets. CSS assets are now processed in two steps: 1. Processing the CSS source asset into either a Global or a Module CSS asset. 2. Inside of Global/Module assets, processing the CSS source asset into a CSS asset. By default, (2.) will create a leaf CSS asset. But in Next.js RSC, this step will be replaced with creating a CSS client reference instead. This client reference can then be detected when walking the RSC graph, and a client CSS chunk can be produced from there. ### Testing Instructions N/A
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
) ### Description My recent change in vercel/turborepo#5397 added a way to create rules that only apply to internal references. In the process, I also made it so the default rules don't apply to internal references as well. However, we still need them to apply to TS and JS files, as we use that with ReferenceType::Internal in Next.js. ### Testing Instructions Next.js CI
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description This PR changes CSS assets to support the CSS client references use case of Next.js, where .css assets in the RSC graph should be replaced with a client reference assets. CSS assets are now processed in two steps: 1. Processing the CSS source asset into either a Global or a Module CSS asset. 2. Inside of Global/Module assets, processing the CSS source asset into a CSS asset. By default, (2.) will create a leaf CSS asset. But in Next.js RSC, this step will be replaced with creating a CSS client reference instead. This client reference can then be detected when walking the RSC graph, and a client CSS chunk can be produced from there. ### Testing Instructions N/A
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
) ### Description My recent change in vercel/turborepo#5397 added a way to create rules that only apply to internal references. In the process, I also made it so the default rules don't apply to internal references as well. However, we still need them to apply to TS and JS files, as we use that with ReferenceType::Internal in Next.js. ### Testing Instructions Next.js CI
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description This PR changes CSS assets to support the CSS client references use case of Next.js, where .css assets in the RSC graph should be replaced with a client reference assets. CSS assets are now processed in two steps: 1. Processing the CSS source asset into either a Global or a Module CSS asset. 2. Inside of Global/Module assets, processing the CSS source asset into a CSS asset. By default, (2.) will create a leaf CSS asset. But in Next.js RSC, this step will be replaced with creating a CSS client reference instead. This client reference can then be detected when walking the RSC graph, and a client CSS chunk can be produced from there. ### Testing Instructions N/A
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
) ### Description My recent change in vercel/turborepo#5397 added a way to create rules that only apply to internal references. In the process, I also made it so the default rules don't apply to internal references as well. However, we still need them to apply to TS and JS files, as we use that with ReferenceType::Internal in Next.js. ### Testing Instructions Next.js CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes CSS assets to support the CSS client references use case of Next.js, where .css assets in the RSC graph should be replaced with a client reference assets.
CSS assets are now processed in two steps:
By default, (2.) will create a leaf CSS asset. But in Next.js RSC, this step will be replaced with creating a CSS client reference instead. This client reference can then be detected when walking the RSC graph, and a client CSS chunk can be produced from there.
Testing Instructions
N/A