Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-8083: add LogPatternConfig field to RobotConfig API #526

Merged
merged 2 commits into from
Jul 3, 2024
Merged

RSDK-8083: add LogPatternConfig field to RobotConfig API #526

merged 2 commits into from
Jul 3, 2024

Conversation

puranamp
Copy link
Contributor

@puranamp puranamp commented Jul 3, 2024 •
edited by jira bot
Loading

RSDK-8083: add LogPatternConfig field to RobotConfig API

  • adds an extra field to the RobotConfig API allow you to specify a logger name with its corresponding log level.

@github-actions github-actions bot added the safe to test committer is a member of this org label Jul 3, 2024
@puranamp puranamp self-assigned this Jul 3, 2024
@puranamp puranamp added the ready-for-protos add this when you want protos to compile on every commit label Jul 3, 2024
@puranamp puranamp removed the ready-for-protos add this when you want protos to compile on every commit label Jul 3, 2024
benjirewis
benjirewis approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@puranamp puranamp merged commit 5556af3 into viamrobotics:main Jul 3, 2024
3 checks passed
maxhorowitz added a commit that referenced this pull request Sep 16, 2024
@maxhorowitz
Merge branch 'main' into app-6230
32e5e34 
* main: (22 commits)
  DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550)
  bump min golang version (#548)
  DATA-3054: Added UpdateBoundingBox (#547)
  RSDK-8595 update docs with new behavior (#546)
  APP-3604 build endpoints for external oauth and repos (#544)
  add last updated to fragment proto (#540)
  APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543)
  APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538)
  RSDK-7903 Add unhealthy state and error field (#539)
  RSDK-8381 add viam server version to API (#537)
  [APP-5417]: Undo APP-5417 (#536)
  [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535)
  Data 2816/get training job logs (#534)
  DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532)
  RSDK-8228 Add config status to machine status API (#531)
  Add revision field to config (#530)
  [APP-5420] Add ListMachineFragments request and response (#525)
  [APP-5400]: Add GetFragmentHistory proto (#524)
  RSDK-7899 Add MachineStatus to RobotService (#527)
  RSDK-8083: add LogPatternConfig field to RobotConfig API (#526)
  ...
maxhorowitz added a commit that referenced this pull request Sep 16, 2024
@maxhorowitz
Merge branch 'main' into app-6230
ac28de1 
* main: (22 commits)
  DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550)
  bump min golang version (#548)
  DATA-3054: Added UpdateBoundingBox (#547)
  RSDK-8595 update docs with new behavior (#546)
  APP-3604 build endpoints for external oauth and repos (#544)
  add last updated to fragment proto (#540)
  APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543)
  APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538)
  RSDK-7903 Add unhealthy state and error field (#539)
  RSDK-8381 add viam server version to API (#537)
  [APP-5417]: Undo APP-5417 (#536)
  [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535)
  Data 2816/get training job logs (#534)
  DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532)
  RSDK-8228 Add config status to machine status API (#531)
  Add revision field to config (#530)
  [APP-5420] Add ListMachineFragments request and response (#525)
  [APP-5400]: Add GetFragmentHistory proto (#524)
  RSDK-7899 Add MachineStatus to RobotService (#527)
  RSDK-8083: add LogPatternConfig field to RobotConfig API (#526)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjirewis benjirewis benjirewis approved these changes

@maximpertsov maximpertsov Awaiting requested review from maximpertsov

Assignees

@puranamp puranamp

Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puranamp @benjirewis