RSDK-8595 Add unhealthy state and error field #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-state
branch
3 times, most recently
from
72cbffb
to
df76c7a
Compare
maximpertsov
force-pushed
the
RSDK-7903-unhealthy-state
branch
from
df76c7a
to
b201b29
Compare
ale7714
approved these changes
Aug 2, 2024
proto/viam/robot/v1/robot.proto
Outdated
| @@ -389,11 +389,13 @@ message ResourceStatus { | |||
| STATE_UNCONFIGURED = 1; | |||
| // a resource that is being configured. | |||
| STATE_CONFIGURING = 2; | |||
| // a resource that has been successfully configured once and is not being | |||
| // a resource that has been successfully configured once, is healthy, and is not being | |||
There was a problem hiding this comment.
does healthy mean ready state? maybe we can explicitly say ready for clarity
There was a problem hiding this comment.
Yeah this is not as clear as it could be - I changed this to "not unhealthy" since we have a definition for that state. I don't want to conflate "ready" with "healthy" too much since a resource can be "healthy" (no errors) but re-configuring or removing.
maximpertsov
added
the
ready-for-protos
maximpertsov
added
safe to test
maximpertsov
added
ready-for-protos
maximpertsov
changed the title
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
maxhorowitz
added a commit
that referenced
this pull request
Sep 16, 2024
* main: (22 commits) DATA-3094: Add CLI args to SubmitCustomTrainingJobRequest (#550) bump min golang version (#548) DATA-3054: Added UpdateBoundingBox (#547) RSDK-8595 update docs with new behavior (#546) APP-3604 build endpoints for external oauth and repos (#544) add last updated to fragment proto (#540) APP-5851: Add optional visibility field to `CreateFragmentRequest` (#543) APP-5314 - add dates and limit to GetRobotPartLogsRequest (#538) RSDK-7903 Add unhealthy state and error field (#539) RSDK-8381 add viam server version to API (#537) [APP-5417]: Undo APP-5417 (#536) [APP-5417]: Accommodate pagination for GetRobotPartHistory in api (#535) Data 2816/get training job logs (#534) DATA-2792 - Add URL to UpdateRegistryItemRequest, but make it optional (#532) RSDK-8228 Add config status to machine status API (#531) Add revision field to config (#530) [APP-5420] Add ListMachineFragments request and response (#525) [APP-5400]: Add GetFragmentHistory proto (#524) RSDK-7899 Add MachineStatus to RobotService (#527) RSDK-8083: add LogPatternConfig field to RobotConfig API (#526) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the resource unhealthy state + field detailing what error caused the resource to be unhealthy.
Related RDK change: