Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RSDK-9132] Add (Get)Image to the camera interface #4487

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

[RSDK-9132] Add (Get)Image to the camera interface #4487

wants to merge 52 commits into from
+680 −600

Commits on Oct 24, 2024

  1. Init craziness

    @hexbabe
    hexbabe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a643d22 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Use camera pkg scoped ReadImage in webcam

    @hexbabe
    hexbabe committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    41cb592 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Merge branch 'main' into RSDK-9132

    @hexbabe
    hexbabe committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    f6e3d69 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Use agreed upon Image signature

    @hexbabe
    hexbabe committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d6439dd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into RSDK-9132

    @hexbabe
    hexbabe committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6417a56 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @hexbabe
    hexbabe committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    59c36ec View commit details
    Browse the repository at this point in the history

  4. Delete ReadImager and fix mimetype formatting in data collector

    @hexbabe
    hexbabe committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    16079fa View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Fix up obstacle depth; Delete custom extra type;

    @hexbabe
    hexbabe committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    9084264 View commit details
    Browse the repository at this point in the history

  2. Update video source comment spec; Add helper to DRY up .Image calls w… 

    …here we convert to go image; Change default mimetypes for classifier
    @hexbabe
    hexbabe committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c44afa2 View commit details
    Browse the repository at this point in the history

  3. Fix obstacle depth mimetype (it needs it for re-encode since we can't… 

    … encode "")
    @hexbabe
    hexbabe committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    11b1d7d View commit details
    Browse the repository at this point in the history

  4. Add image metadata replacing mimetype return; Add back non empty stri… 

    …ng default mimetypes for vision since we are failing unit tests with 'do not know how to encode' errors
    @hexbabe
    hexbabe committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    438d550 View commit details
    Browse the repository at this point in the history

  5. Forgot to include mimetype in test resp oops

    @hexbabe
    hexbabe committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0d8081b View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Add width and height to ImageMetadata struct

    @hexbabe
    hexbabe committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    824c30f View commit details
    Browse the repository at this point in the history

  2. Use GetGoImage in camera client Stream

    @hexbabe
    hexbabe committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e744b68 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Remove jpeg default in vision

    @hexbabe
    hexbabe committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    fd50881 View commit details
    Browse the repository at this point in the history

  2. Revert detections, classifications, and capture all's image call to R… 

    …eadImage
    @hexbabe
    hexbabe committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e570393 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Don't modify vision at all

    @hexbabe
    hexbabe committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6646d78 View commit details
    Browse the repository at this point in the history

  2. Remove width and height from ImageMetadata; DRY up webcam and videoso… 

    …urcewrappers Image func
    @hexbabe
    hexbabe committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    612e91c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Move ReadImageBytes to videosourcewrappers

    @hexbabe
    hexbabe committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9029a05 View commit details
    Browse the repository at this point in the history

  2. Rename GetGoImage -> ImageFromVideoSource

    @hexbabe
    hexbabe committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6ec0041 View commit details
    Browse the repository at this point in the history

  3. Make lint

    @hexbabe
    hexbabe committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    ef1bd0e View commit details
    Browse the repository at this point in the history

  4. Move mimetype unmarshaling outside of capture func

    @hexbabe
    hexbabe committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d01159a View commit details
    Browse the repository at this point in the history

  5. Update components/camera/client.go 

    Co-authored-by: nicksanford <nicholascsanford@gmail.com>
    @hexbabe @nicksanford
    hexbabe and nicksanford committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    44611d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Add error for empty bytes responses in server & client

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    146345f View commit details
    Browse the repository at this point in the history

  2. Add empty image bytes tests

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c698e16 View commit details
    Browse the repository at this point in the history

  3. Fix random things that I am doing wrong

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9da582f View commit details
    Browse the repository at this point in the history

  4. Revert

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1b51109 View commit details
    Browse the repository at this point in the history

  5. RSDK-9218: Change all of the artifacts to v4. (viamrobotics#4535)

    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    eaf28d7 View commit details
    Browse the repository at this point in the history

  6. RSDK-8359: Update smarty to avoid unnecessary data races. (viamroboti… 

    …cs#4534)
    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    4fe7e36 View commit details
    Browse the repository at this point in the history

  7. RSDK-8819: Implement FTDC file rotation. (viamrobotics#4510)

    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b4e1960 View commit details
    Browse the repository at this point in the history

  8. APP-6785: Remove local control page - remove web workflows (viamrobot… 

    …ics#4523)
    @ethanlookpotts @hexbabe
    ethanlookpotts authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    fc6665d View commit details
    Browse the repository at this point in the history

  9. APP-6850 update android build for go 1.23 (viamrobotics#4539)

    @abe-winter @hexbabe
    abe-winter authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8afb714 View commit details
    Browse the repository at this point in the history

  10. RSDK-8611: Have test make a tls config copy to avoid concurrent acces… 

    …s. (viamrobotics#4544)
    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    375a35f View commit details
    Browse the repository at this point in the history

  11. RSDK-8837: Remove the short timeout for testing reconnects that are e… 

    …xpected to succeed. (viamrobotics#4541)
    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5bf744c View commit details
    Browse the repository at this point in the history

  12. make errors reported during discovery (viamrobotics#4546)

    @erh @hexbabe
    erh authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    2a1cd8b View commit details
    Browse the repository at this point in the history

  13. Update gripper.go (viamrobotics#4540)

    @npentrel @hexbabe
    npentrel authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    1233170 View commit details
    Browse the repository at this point in the history

  14. RSDK-9090 clarify package cleanup (viamrobotics#4542)

    @maximpertsov @hexbabe
    maximpertsov authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    95f3f42 View commit details
    Browse the repository at this point in the history

  15. RSDK-9240: Remove github action code coverage stuff we do not use. (v… 

    …iamrobotics#4548)
    @dgottlieb @hexbabe
    dgottlieb authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b208d2c View commit details
    Browse the repository at this point in the history

  16. [Data-3312] add basic data capture support for capturing tabular data… 

    … to mongo (viamrobotics#4486)

Co-authored-by: Devin Hilly <devin.hilly@viam.com>
    @nicksanford @dmhilly @hexbabe
    2 people authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0b85975 View commit details
    Browse the repository at this point in the history

  17. RSDK-9136: issues when stopping motor with controls (viamrobotics#4550)

    @martha-johnston @hexbabe
    martha-johnston authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c44454b View commit details
    Browse the repository at this point in the history

  18. RSDK-9037: Add AttachDirectionalAwareness to DoCommand (viamrobotics#… 

    …4552)
    @martha-johnston @hexbabe
    martha-johnston authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d848d20 View commit details
    Browse the repository at this point in the history

  19. RSDK-8767 - populate local_name and remote_path to all resource names… 

    … sent from RDK (viamrobotics#4519)
    @Kschappacher @hexbabe
    Kschappacher authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    09e295c View commit details
    Browse the repository at this point in the history

  20. APP-6696 include os_version tag on GOOS=darwin (viamrobotics#4536)

    @abe-winter @hexbabe
    abe-winter authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3edf860 View commit details
    Browse the repository at this point in the history

  21. RSDK-8926: Rover canary motor test fail because failure to set pins (v… 

    …iamrobotics#4549)
    @martha-johnston @hexbabe
    martha-johnston authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    b7c4635 View commit details
    Browse the repository at this point in the history

  22. [DATA-3338] - collector test improvements (viamrobotics#4551)

    @nicksanford @hexbabe
    nicksanford authored and hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    63b7681 View commit details
    Browse the repository at this point in the history

  23. Merge branch 'main' into RSDK-9132

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c91b68d View commit details
    Browse the repository at this point in the history

  24. Fix new collector tests

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d63980e View commit details
    Browse the repository at this point in the history

  25. Change image.Image getter wrapper to take in a camera resource not a … 

    …soon to be deprecated VideoSource
    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6ffbae2 View commit details
    Browse the repository at this point in the history

  26. Merge branch 'viamrobotics:main' into RSDK-9132

    @hexbabe
    hexbabe authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    65b5bad View commit details
    Browse the repository at this point in the history

  27. If err, then bytes and metadata should be falsy

    @hexbabe
    hexbabe committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    9a9612f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Use imgbuf bytes directly for a robot client test rather than encode … 

    …from img; Fix prev test bug
    @hexbabe
    hexbabe committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ab7e736 View commit details
    Browse the repository at this point in the history

  2. Add back ReadImage/Stream tests where it makes sense

    @hexbabe
    hexbabe committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8244dfd View commit details
    Browse the repository at this point in the history