gltf の読み書きで反転軸を指定できるようにする #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
使い方 * var parser = new GltfParser(); * parser.ParsePath(filePath); // ParseJson, ParseGlb 等パース系の関数 * context = new ImporterContext(parser); // parse から context を作る * context.Load(); // もしくは LoadAsync で、Unity化する
Santarh
approved these changes
Feb 25, 2021
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "name": "UniGLTF.Editor", | |||
| "references": [ | |||
| "UniGLTF" | |||
| "UniGLTF", | |||
| "MeshUtility.Editor" | |||
There was a problem hiding this comment.
PR の趣旨からは外れて asmdef 運用話になるのでどちらでも良いのですが…
ライブラリ利用ユーザがアクセスしないと想定されるような asmdef は Auto Referenced のチェックボックスを切ることで、ユーザからの不要な参照は避けられるかもしれません。
| @@ -1,4 +1,5 @@ | |||
| using System.IO; | |||
| #if false | |||
There was a problem hiding this comment.
ScriptedImporterを導入で、Assets 外のファイルを選択して Prefab として保存するメニューはもう無くてもよさそうなので、消す前に寝かせる処置。
| Debug.Log("OnImportAsset to " + ctx.assetPath); | ||
|
|
||
| try | ||
| { |
| float angle; | ||
| Vector3 axis; | ||
| q.ToAngleAxis(out angle, out axis); | ||
| return Quaternion.AngleAxis(-angle, ReverseX(axis)); |
There was a problem hiding this comment.
AngleAxis じゃなくても、要素の並び替えと符号反転でも表現できるので、高速化と値保持の余地はありそう。
There was a problem hiding this comment.
X-Axis の反転と回転角の反転になるので
おそらく new Quaternion(x, -y, -z, w); かなぁ
| X, | ||
| } | ||
|
|
||
| public struct AxisInverter |
There was a problem hiding this comment.
定義自体は interface でもよさそう？
struct なら readonly struct にしておきたいですね（コピーが発生するので）
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.68.0での ScriptedImporter の導入は、glbの Asset import のみ。v0.69.0以降でvrmにも拡大する予定。