Skip to content

Change Log for January 2019 APG 1.1 Note Release 3

Matt King edited this page Jan 15, 2019 · 1 revision

Regression Tests: Add data-test-id attribute to 8 example pages (pull #810)

By Valerie Young on Tue Jul 31 01:32:09 2018 -0400

Adds data-test-id attribute values for keyboard and role/state/property tables for: Accordion, button, checkbox, 1.1 combobox with listbox popup, disclosure, scrollable listbox, radio group, and toolbar.

View commit 1164a03

ARIA WG

By Philippe Le Hegaret on Tue Jul 31 09:13:30 2018 -0400

View commit b388731

Button Example: remove aria-hidden from child svg

By Matt King on Tue Jul 31 14:16:18 2018 -0700

For issue #814, removes aria-hidden from the svg element nested inside the toggle button.

View commit 00282ea

Fix NU Checker Validation Errors (pull #820)

By Nick Schonning on Thu Aug 2 17:57:57 2018 -0400

  • fix: Markup issues flagged by validator in HTML files for 6 example pages.
  • fix: Stray tags in DeletedSectionsArchive

View commit 0549dd0

Combobox Examples: Update data-test-ids for regression tests (pull #823)

By Valerie Young on Fri Aug 10 15:47:06 2018 -0400

View commit c104e0e

Single-select listbox example: Fix aria-selected bug (pull #795)

By Christopher Tryens on Mon Aug 13 17:58:07 2018 -0400

For issue #794, update aria-selected for single-select listbox options where selection follows focus.

Change in listbox/js/listbox.js: When aria-multiselectable is false, toggle aria-selected when option receives or loses focus.

View commit 66229af

chore: Pull gh-pages building to deploy script (pull #445)

By Nick Schonning on Tue Aug 14 20:21:56 2018 -0400

Move the logic for doing the manual gh-pages deployment to the built-in Travis-CI “script” deployment. This allows all branches to be built and tested, but only the master branch to be deployed.

View commit 458beba

Treegrid Pattern: Change new pattern warning to editor's note

By Matt King on Tue Aug 14 17:27:36 2018 -0700

Trivial editorial change to test new build/test/deploy scripts from PR #445.

View commit 201fe21

Expand VNU validator file pattern (pull #779)

By Nick Schonning on Tue Aug 14 23:57:58 2018 -0400

  • chore: VNU globbing, Ensure all html files are checked.
  • chore: Bump vnu-jar to 18.7.23
  • chore: Ignore current vnu failures in accordion and menubar

Related to #815 #822

View commit d011661

Spelling fixes (pull #834)

By Nick Schonning on Thu Aug 16 19:13:45 2018 -0400

Fixes 21 errors across 18 files.

  • typo: Transcripts
  • typo: attribute
  • typo: imitate
  • typo: Research
  • typo: performing
  • typo: Transcripts
  • typo: left
  • typo: arbitrary
  • typo: left
  • typo: corp
  • typo: parent
  • typo: selector
  • typo: parent
  • typo: selector
  • typo: accessible
  • typo: left
  • typo: relevant
  • Fixed JS comment block that was HTML
  • typo: shortcuts
  • typo: selector
  • typo: accessible
  • typo: information

View commit 5e1978b

Navigation Menubar Example: delete 3 unused html files

By Matt King on Thu Aug 16 21:18:14 2018 -0700

Per comments in pull request #834, removed the following 3 html files that are no longer used by the navigation menubar example. deleted: examples/menubar/menubar-1/mb-arts.html deleted: examples/menubar/menubar-1/mb-outreach.html deleted: examples/menubar/menubar-1/mb-research.html

View commit c57878b

Regression Test: Add data-test-ids to combobox pages (pull #850)

By Valerie Young on Tue Aug 21 13:24:43 2018 -0400

View commit 3aeacfc

Legacy Combobox with autocomplete list example: Fix enter key documentation

By Matt King on Thu Aug 23 15:39:14 2018 -0700

For issue #855, modify the keyboard table for the textbox on examples/combobox/aria1.0pattern/combobox-autocomplete-list.html. Change to say that it only closes the listbox.

View commit da0fb16

Alert Dialog: Replace lorem ipsum placeholder with descriptive text (pull #844)

By Patrick H. Lauke on Sat Aug 25 23:57:06 2018 +0100

Resolves #840: Replace lorem ipsum placeholder with text that describes actions that trigger the alert dialog and alert message.

View commit ed10a3a

Add data-test-ids for regression tests

By Valerie R Young on Mon Aug 27 17:05:16 2018 -0400

View commit 8730f70

Spin Button Pattern: Add aria-invalid guidance for values outside allowed range (pull #825)

By Matt King on Wed Aug 29 05:23:44 2018 -0700

In response to issue #704, modified the roles, states, and properties section of the spin button pattern in aria-practices.html.

Added a bullet to the list of roles, states, and properties stating that aria-invalid is set true if it is possible for the textbox to contain a value that is not allowed.

View commit 4992388

Regression Tests: Add and update data-test-ids (pull #864)

By Valerie Young on Wed Aug 29 12:19:41 2018 -0400

  • Add data-test-ids to table/table.html
  • Remove untestable attribute data-test-ids from alert.html

View commit 1379511

Use Travis Build stages (pull #851)

By Nick Schonning on Fri Aug 31 10:33:11 2018 -0400

For issue #848, implement travis stages so linting and HTML validation are in separate jobs that run in parallel and show up on the checks page of a PR.

View commit e1288aa

Navigation Treeview with Declared Properties Example: Fix 2 incorrect aria-level and aria-posinset values (pull #871)

By Valerie Young on Fri Aug 31 16:28:35 2018 -0400

View commit 2d8a22c

Editorial: Fix multiple instances of repeated words (pull #867)

By Nick Schonning on Fri Aug 31 17:00:24 2018 -0400

  • typo: Double word "the"
  • typo: Double word "a"
  • typo: Double word "have"
  • typo: Double word "information"
  • typo: Double word "must"
  • typo: Double word "Career"

View commit f6d4a4a

Regression Tests: Add data-test-ids to 3 example pages (pull #874)

By Valerie Young on Tue Sep 4 16:59:55 2018 -0400

Adds data-test-ids to example pages:

  • checkbox-2.html
  • tabs-2/tabs.html
  • treegrid-1.html

View commit dcd343e

Regression testing: Add data-test-id to example pages (pull #881)

By Valerie Young on Thu Sep 13 12:29:32 2018 -0400

View commit cf6aca4

Button examples: Activate buttons on keyup for space key (pull #858)

By Philipp Rudloff on Thu Sep 13 19:18:18 2018 +0200

To resolve issue #610, activate buttons on keyup when space is pressed. Enter key behavior is not changed. Makes behavior consistent with HTML button elements.

View commit c301653

aria1.0 combobox with autocomplete=both example: Make Up Arrow set activedescendant to last match in list (pull #857)

By Jon Gunderson on Thu Sep 13 13:31:13 2018 -0400

To address issue #821, make the up arrow behavior when a match exists consistent with when text box is empty.

View commit 18eacf8

aria1.0 combobox autocomplete list and both examples: Correct up arrow documentation for the textbox

By Matt King on Thu Sep 13 12:44:24 2018 -0700

Commit 18eacf8 for issue #821 fixes the behavior of the up arrow when the combobox is not empty and the listbox is open and displays suggested values. This commit corrects the documentation so that it accurately describes the adjusted behavior. modified: examples/combobox/aria1.0pattern/combobox-autocomplete-both.html modified: examples/combobox/aria1.0pattern/combobox-autocomplete-list.html

View commit 8557ab7

Regression testing: Add data-test-id attribute for 6 example pages(pull #890)

By Valerie Young on Mon Sep 17 19:27:37 2018 -0400

View commit 2d16c91

Regression Tests: Add test infra and tests for 27 example pages (pull #895)

By Matt King on Tue Sep 18 21:45:28 2018 -0700

Add Aava.js regression test infra and tests for 27 example pages:

alert.js breadcrumb.js button.js checkbox-1.js checkbox-2.js combobox-autocomplete-both.js combobox-autocomplete-list.js combobox-autocomplete-none.js dialog.js disclosure-faq.js grid-combo.js LayoutGrids.js link.js listbox-combo.js listbox-scrollable.js menu-button-actions.js menubar-2.js radio-1.js slider-1.js table.js tabs.js toolbar.js treegrid-1.js treeview-1a.js treeview-1b.js treeview-2a.js treeview-2b.js

View commit 844a7f2

Accordion Example: Restructure to use div instead of dl and improve focus styling

By Matt King on Mon Sep 24 11:37:05 2018 -0700

To resolve issue #815:

  1. Replace dl with div
  2. Replace dt with h3
  3. Replace dd with div
  4. Update documentation tables.

Also:

  1. Improve visual focus styling so it is more apparent that arrow keys move focus from header to header.
  2. Add accessibility features section that describes the focus styling.

View commit 6cc0d6c

VNU config: Remove exclusions for accordion (pull #902)

By Nick Schonning on Mon Oct 1 14:36:57 2018 -0400

For issue #815, remove the exclusions in the VNU configuration that permitted accordion-related roles on dl, dt, and dt.

View commit c82044e

Regression tests: Add tests for 11 example pages (pull #915)

By Matt King on Mon Oct 1 13:16:28 2018 -0700

Adds tests for 11 example pages:

  • accordion.js
  • dataGrids.js
  • disclosure-img-long-description.js
  • feed.js
  • listbox-collapsible.js
  • menu-button-actions-active-descendant.js
  • menu-button-links.js
  • menubar-1.js
  • multithumb-slider.js
  • slider-2.js
  • tabs-2.js

Also updates utils and tests for other example pages that were previously merged.

View commit 6e86a4f

Add wait to dialog

By Valerie R Young on Wed Oct 3 16:27:21 2018 -0400

View commit 5628a41

Fix recently introduced mistake in tab calculation

By Valerie R Young on Thu Oct 4 10:46:44 2018 -0400

View commit 15df732

Resolve issue #923

By James Nurthen on Mon Oct 8 10:24:03 2018 -0700

View commit 60a05c0

Radio Group Example: Fix documentation of elements used in attributes table (pull #924)

By Jon Gunderson on Mon Oct 8 15:34:00 2018 -0500

Fixes issue #917; changes element used column and revises explanations in usage column of attributes table.

View commit 30af679

Fixed/updated config file

By plehegar on Wed Oct 17 10:44:03 2018 -0400

View commit 2ee55ce

CoC

By plehegar on Wed Oct 17 16:25:13 2018 -0400

View commit f05bae3

Apply role="none" to

  • elements in menubar

    By Michael Fairchild on Thu Oct 18 08:18:47 2018 -0500

    fixes #930

    View commit b33d32e

    Landmark Examples: Add landmarks browser extension (pull #936)

    By Carolyn MacLeod on Mon Oct 29 05:38:31 2018 -0400

    Resolves issue #935 by adding a link to the landmarks browser extension to the tools section on the landmarks resources page.

    View commit 028ea7a

    eslint: prevent eval()

    By tripu on Tue Oct 30 15:20:44 2018 +0100

    View commit ff4d36c

    Change History Appendix: Remove APG 1.1 change history

    By Matt King on Thu Nov 8 23:32:13 2018 -0800

    After this removal, the change history will later be added back in the apg-1.1 branch. From this point forward, all content in master will be "forever" content that can be merged into both apg-1.1 and apg-1.2.

    View commit 656dc3a

    Change History Appendix: Added change history for most recent 3 publications

    By Matt King on Thu Nov 8 23:43:52 2018 -0800

    Modified aria-practices.html appendix section to re-add content removed from the master branch in commit 656dc3a. The apg-1.1 branch now contains APG 1.1 specific content that will not be included in APG 1.2.

    View commit 4e1dda8

    Added Jaeun Jemma Ku to ARIA-APG editor list

    By JaEun Jemma Ku on Fri Nov 30 11:01:33 2018 -0600

    View commit c922239

    Removed the trailing space to fix linting error

    By JaEun Jemma Ku on Fri Nov 30 11:47:12 2018 -0600

    View commit ce64021

    Dialog Examples: Fix IE11 incompatibility in role validity check (pull #943)

    By Evan Yamanishi on Tue Dec 4 01:25:11 2018 -0500

    Modifies examples/dialog-modal/js/dialog.js to Fix issue #929:

    • Remove use of includes method, which is not supported by IE.
    • Account for condition where multiple roles are specified.

    View commit a1a8d92

    Grid Examples: Fix event listener cleanup (pull #941)

    By Gilmore Davidson on Wed Dec 5 19:57:30 2018 +1100

    event listeners were not being cleaned up properly, resulting in multiple instances of the same listener being attached to an element.

    Fixed by:

    1. Adding a method in utils.js inspired by _.bindAll() from Underscore/Lodash
    2. Removing all the explicit .bind() calls in dataGrid.js.

    View commit 0f32611

    Regression test project: final changes and updates (pull #926)

    By Matt King on Fri Dec 7 00:55:28 2018 -0800

    Incorporate final set of changes from 2018 Bocoup contract:

    • Add tests for radio/radio-2/radio-2.html
    • Add tests for listbox/listbox-rearrangeable.html
    • Add missing radio-2 test
    • Report: Account for no missing tests
    • rename Combobox test files
    • Add missing test names
    • Remove debug related log messages

    View commit 38a5619

    add Jon and Matt as authors

    By Michael Cooper on Fri Dec 7 10:12:35 2018 -0500

    View commit 092eba7

    use formerEditors feature

    By Michael Cooper on Fri Dec 7 10:13:43 2018 -0500

    View commit ebfb057

    change tabs to spaces cause apparently it matters

    By Michael Cooper on Fri Dec 7 11:10:40 2018 -0500

    View commit 301cb0d

    Editor Menubar Example: Visual design to distinguish between menuitemradio and meuitemcheckbox (pull #853)

    By Carolyn MacLeod on Tue Dec 11 22:27:08 2018 -0500

    Resolves issue #605 by:

    • Indicating menuitemcheckbox elements are checked with a checkmark icon.
    • Indicating menuitemradio elements are checked with a filled in circle icon.

    View commit 08e5fe0

    TRAVIS-CI update from aria-common

    By michael-n-cooper on Mon Dec 17 15:42:20 2018 +0000

    View commit 1a6df75

    Mark repo as host of note work (rather than rec-track)

    By Dominique Hazael-Massieux on Tue Dec 18 10:15:16 2018 +0100

    View commit 3381be7

    HTML-AAM ref

    By Michael Cooper on Tue Dec 18 13:55:36 2018 -0500

    View commit 098c5c1

    leave cite to respec

    By Michael Cooper on Tue Dec 18 13:56:24 2018 -0500

    View commit 246dc57

    updated eddraft xrefs

    By Michael Cooper on Tue Dec 18 13:57:01 2018 -0500

    View commit cf23afd

    another html-aam link

    By Michael Cooper on Tue Dec 18 14:03:19 2018 -0500

    View commit 8290caf

    Add index utility (pull #951)

    By Jon Gunderson on Fri Dec 21 03:36:38 2018 -0600

    For issue #752, adds a node script for generating two indexes:

    • Example by role
    • Examples by state or property

    The script lands the generated index.html in the /examples directory.

    View commit 5ec6c8f

    switch from rawgit to raw.githack

    By Michael Cooper on Fri Dec 21 13:46:32 2018 -0500

    View commit 3a303be

    Changes to package-lock.json made by npm install

    By Matt King on Sat Dec 22 12:21:56 2018 -0800

    View commit 1ebe25c

    GitHub ReadMe: Update badge from Travis-ci.org to .com (pull #961)

    By Nick Schonning on Sat Jan 12 17:58:55 2019 -0500

    View commit 1e1f4ff

    Travis Deploy Script: Add git command to add all new untracked files before gh-pages commit (pull #962)

    By Nick Schonning on Mon Jan 14 12:28:05 2019 -0500

    Some generated files, such as the example index file, were not getting included in the commit to gh-pages.

    View commit 37388d1

    TRAVIS-CI update from aria-common

    By michael-n-cooper on Tue Jan 15 00:14:15 2019 +0000

    View commit da323de

    Radio Group Pattern: Add new keyboard interaction for radios in toolbars (pull #952)

    By Matt King on Mon Jan 14 17:00:17 2019 -0800

    For issue #949, modified the radio group pattern section aria-practices.html:

    • Divided the keyboard interaction subsection into two subsections: not in toolbar and in toolbar.
    • Added interactions for the special case of radios contained in toolbars.
    • In toolbars, checked state does not follow focus and left/right can move focus outside radio group.

    View commit 211301f

    Add carousel pattern (pull #957)

    By Matt King on Mon Jan 14 18:12:00 2019 -0800

    Completes drafting of the carousel design pattern for issue #43.

    View commit ca78f0a

    Toolbar Example: Fix bugs and redesign to add more types of widgets (#pull 950)

    By Jon Gunderson on Mon Jan 14 21:47:01 2019 -0600

    completes work to:

    • Resolve keyboard, aria-disabled, and aria-label bugs listed in issue #847.
    • Add additional widget types requested in issue #541, including toggle, checkbox, spinner, menu button, radio group, and link.
    • The above are all issues discussed in toolbar review issue #539.

    Note: missing regression tests are tracked by issue #965.

    View commit a161bc6

    Add carousel example (pull #958)

    By Jon Gunderson on Mon Jan 14 23:47:42 2019 -0600

    Resolves issue #458 by adding a basic example of the carousel pattern that demonstrates how to make automatic rotation accessible.

    View commit 4c846e4

    Carousel Pattern and Example: Link pattern to example and update index

    By Matt King on Mon Jan 14 23:31:57 2019 -0800

    In carousel design pattern section:

    1. Add link to review issue 970.
    2. Add paragraph under example heading that includes a link to the example page and a description of the example.

    On auto-rotating image carousel Example page, update link to review issue to refer to issue 971.

    Run reference-tables node script to update index of examples, so it includes carousel example.

    View commit 45d342c

    Toolbar Pattern: Revise description to remove guidance that conflicted with updated radio group pattern

    By Matt King on Tue Jan 15 00:21:23 2019 -0800

    The radio group pattern update made for issue #949 allows nesting a radio group in a toolbar. The toolbar pattern description previously included guidance that said to avoid including radio groups in horizontal toolbars. This change revises the description to clarify options for arrow key implementation, describing how one pair can be reserved for control operation. The reserved pair depends on toolbar orientation.

    View commit 7bd7123

    Toolbar Pattern: Clarify keyboard guidance for Tab and Shift+Tab

    By Matt King on Tue Jan 15 00:59:08 2019 -0800

    Resolve issue #582 by adding explicit guidance for Tab and Shift+Tab. Use language similar to that used in the radio group pattern.

    View commit 66b5128

  • Clone this wiki locally