[Spec] Restore changes since REC #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the plan outlined in #1021#issuecomment-2107832273, we have now created the CR Snapshot and published a new CR Draft (https://www.w3.org/TR/payment-request/) that includes restoring the address changes. The only remaining work for that plan is to restore the previous changes that had been made since REC. Changes included: - [Spec] Relax user activation requirement for show() #1009 Additional edits on tops of above changes: - Add note linking to issue #1022 for discussion of user activation relaxing conditions Fixes #1025
stephenmcgruer
force-pushed
the
re-add-changes-since-rec
branch
from
94ad189 to
c7c04d2
Compare
stephenmcgruer
requested review from
marcoscaceres,
ianbjacobs and
rsolomakhin
as code owners
|
I was unable to find any other cases that differed from REC other than the user activation change - have I overlooked anything? |
|
@stephenmcgruer, thanks for creating this. I walked through all the other commits since Recommendation. The only one I could not account for is this one. The spec may no longer need to use the definition. I suspect it was replaced with JSON-parsing. Thanks! |
ianbjacobs
approved these changes
Aug 21, 2024
|
@marcoscaceres, we'll merge this on 26 August. If you want to review beforehand, that would be great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the plan outlined in #1021#issuecomment-2107832273, we have now created the CR Snapshot and published a new CR Draft (https://www.w3.org/TR/payment-request/) that includes restoring the address changes. The only remaining work for that plan is to restore the previous changes that had been made since REC.
Changes included:
Additional edits on tops of above changes:
closes #1025
Preview | Diff