-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert spec to REC state #1021
Revert spec to REC state #1021
Conversation
This addresses this issue in SPC - https://w3c.github.io/secure-payment-confirmation/#issue-e92619e9 The behavior spec'd in SPC appears to already be followed in general Payment Request implementations already, based on testing in both Safari and Chrome, so it seems safe to just spec it here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone please remind me what we've decided to do with the user activation requirement? Have we decided to keep it or remove it?
For process reasons we want to create a "CR Snapshot" that is the Recommendation unchanged, except for the status. Then we will immediately (as in the same day probably) publish a "CR Draft" that will include (1) all the changes since the Rec including removal of the user activation requirement and (2) the address stuff restored, except using contact picker API instead of defining a dictionary in PR API. I hope that sounds ok! |
This plan SGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on Ian's description of the plan to add back the User Activation Requirement immediately after merging this pull request.
As per the plan outlined in #1021#issuecomment-2107832273, we have now created the CR Snapshot and published a new CR Draft (https://www.w3.org/TR/payment-request/) that includes restoring the address changes. The only remaining work for that plan is to restore the previous changes that had been made since REC. Changes included: - [Spec] Relax user activation requirement for show() #1009 Additional edits on tops of above changes: - Add note linking to issue #1022 for discussion of user activation relaxing conditions Fixes #1025
As per the plan outlined in #1021#issuecomment-2107832273, we have now created the CR Snapshot and published a new CR Draft (https://www.w3.org/TR/payment-request/) that includes restoring the address changes. The only remaining work for that plan is to restore the previous changes that had been made since REC. Changes included: - [Spec] Relax user activation requirement for show() #1009 Additional edits on tops of above changes: - Add note linking to issue #1022 for discussion of user activation relaxing conditions Fixes #1025
As per the plan outlined in #1021#issuecomment-2107832273, we have now created the CR Snapshot and published a new CR Draft (https://www.w3.org/TR/payment-request/) that includes restoring the address changes. The only remaining work for that plan is to restore the previous changes that had been made since REC. Changes included: - [Spec] Relax user activation requirement for show() #1009 Additional edits on tops of above changes: - Add note linking to issue #1022 for discussion of user activation relaxing conditions Fixes #1025
This PR gets us back to where we were when we went to REC. It cherry-picks all the editorial and xref fixes.
Additionally:
Preview | Diff