Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert spec to REC state #1021

Merged
merged 16 commits into from
Jul 8, 2024
Merged

Revert spec to REC state #1021

merged 16 commits into from
Jul 8, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Feb 5, 2024

This PR gets us back to where we were when we went to REC. It cherry-picks all the editorial and xref fixes.

Additionally:


Preview | Diff

marcoscaceres and others added 10 commits February 6, 2024 10:45
)

And avoid exporting the term, since other specs should be calling Infra
instead.
This addresses this issue in SPC - https://w3c.github.io/secure-payment-confirmation/#issue-e92619e9

The behavior spec'd in SPC appears to already be followed in general Payment Request implementations already, based on testing in both Safari and Chrome, so it seems safe to just spec it here instead.
index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone please remind me what we've decided to do with the user activation requirement? Have we decided to keep it or remove it?

@ianbjacobs
Copy link
Collaborator

@rsolomakhin,

For process reasons we want to create a "CR Snapshot" that is the Recommendation unchanged, except for the status. Then we will immediately (as in the same day probably) publish a "CR Draft" that will include (1) all the changes since the Rec including removal of the user activation requirement and (2) the address stuff restored, except using contact picker API instead of defining a dictionary in PR API. I hope that sounds ok!

@rsolomakhin
Copy link
Collaborator

@rsolomakhin,

For process reasons we want to create a "CR Snapshot" that is the Recommendation unchanged, except for the status. Then we will immediately (as in the same day probably) publish a "CR Draft" that will include (1) all the changes since the Rec including removal of the user activation requirement and (2) the address stuff restored, except using contact picker API instead of defining a dictionary in PR API. I hope that sounds ok!

This plan SGTM!

Copy link
Collaborator

@rsolomakhin rsolomakhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on Ian's description of the plan to add back the User Activation Requirement immediately after merging this pull request.

@marcoscaceres marcoscaceres merged commit f10efb7 into gh-pages Jul 8, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the rec-base branch July 8, 2024 22:07
stephenmcgruer added a commit that referenced this pull request Aug 21, 2024
As per the plan outlined in #1021#issuecomment-2107832273, we have now
created the CR Snapshot and published a new CR Draft
(https://www.w3.org/TR/payment-request/) that includes restoring
the address changes. The only remaining work for that plan is to restore
the previous changes that had been made since REC.

Changes included:
  - [Spec] Relax user activation requirement for show() #1009

Additional edits on tops of above changes:
  - Add note linking to issue #1022 for discussion of user activation
    relaxing conditions

Fixes #1025
stephenmcgruer added a commit that referenced this pull request Aug 21, 2024
As per the plan outlined in #1021#issuecomment-2107832273, we have now
created the CR Snapshot and published a new CR Draft
(https://www.w3.org/TR/payment-request/) that includes restoring
the address changes. The only remaining work for that plan is to restore
the previous changes that had been made since REC.

Changes included:
  - [Spec] Relax user activation requirement for show() #1009

Additional edits on tops of above changes:
  - Add note linking to issue #1022 for discussion of user activation
    relaxing conditions

Fixes #1025
ianbjacobs pushed a commit that referenced this pull request Sep 9, 2024
As per the plan outlined in #1021#issuecomment-2107832273, we have now
created the CR Snapshot and published a new CR Draft
(https://www.w3.org/TR/payment-request/) that includes restoring
the address changes. The only remaining work for that plan is to restore
the previous changes that had been made since REC.

Changes included:
  - [Spec] Relax user activation requirement for show() #1009

Additional edits on tops of above changes:
  - Add note linking to issue #1022 for discussion of user activation
    relaxing conditions

Fixes #1025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants