Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Internal GET, PUT API 추가 #288

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Feat: Internal GET, PUT API 추가 #288

merged 5 commits into from
Jul 1, 2024

Conversation

huGgW
Copy link
Collaborator

@huGgW huGgW commented Jun 30, 2024

Feat: Internal GET, PUT API 추가

한줄 요약

.internal 페이지에 대하여 db 항목 추가, GET과 PUT API를 추가하였습니다.

Copy link

Test Results

12 files  +  1  12 suites  +1   1s ⏱️ ±0s
59 tests +  9  59 ✔️ +  9  0 💤 ±0  0 ±0 
66 runs  +10  66 ✔️ +10  0 💤 ±0  0 ±0 

Results for commit 21dd330. ± Comparison against base commit 5c0454e.

Copy link
Contributor

@leeeryboy leeeryboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 internal이 여러개 들어있을 수 있는 상황이 있나? 궁금

@huGgW
Copy link
Collaborator Author

huGgW commented Jul 1, 2024

👍 internal이 여러개 들어있을 수 있는 상황이 있나? 궁금

ㄴㄴ 없는데 혹시 몰라서

@huGgW huGgW merged commit b796ab5 into develop Jul 1, 2024
3 checks passed
@huGgW huGgW deleted the feat/international branch July 1, 2024 14:52
leeeryboy added a commit that referenced this pull request Jul 16, 2024
* Feat: Internal GET, PUT API 추가 (#288)

* Refactor: Remove unused interface

* Feat: Create Internal Entity, Dto

* Feat: Create Internal Repository, Service.

* Feat: Create Internal Controller

* Test: Add Test for Internal Domain.

* Feat: Main API에서 중요 공지 갯수 optional하게 전달하도록 수정 (#289)

* Feat: Change to get count optional for repositories.

* Feat: Change service method to get important count as optional.

* Feat: Change importCnt query param as optional.

* 인증서 세팅 + migrate api 일부 삭제 (#290)

* delete migrate api

* set new ssl certificate

* style: ktlint

* Feat: 안전한 파일 제거 method 추가 (#291)

* Feat: Create file delete event.

* Feat: Create File Delete Event Listener, only delete file when transaction commit.

* Feat: Add remove entity method which publish file delete event.

* Refactor: change old delete method name to deprecated.

---------

Co-authored-by: Junhyeong Kim <leeeryboy@gmail.com>

* Feat: Staff 수정 API 추가 (#292)

* Feat: Add request body for create, modify staff.

* Refactor: Make DTO as representation of entity.

* Refactor: Change language as changable.

* Feat: Change CUD method to properly update file, search index.

* Feat: Change CUD api to use proper request body, remove migrate api.

* Comment: Add comment.

* Test: Fix staff service test.

* fix: 교수회의실 예약 권한 변경 (#293)

* fix: 교수회의실 예약 권한 변경

* fix: 교수회의실 예약 권한 변경

* 로그인 취약점 수정 및 Caddyfile.dev 추가 (#295)

* update deprecated methods and enable csrf

* create Caddyfile.dev

* add swagger reverse proxy

* remove swagger related path

* update api for single html page (#294)

* feat: update guide

* update search entity

* update degree requirements

* save csrf cookie (#297)

* 스프링 세션 설정 변경 (#298)

* fix timeout to 9h and set cookie same-site lax

* disable csrf

* remove unnecessary import

* Feat: Professor 수정 API 추가 (#296)

* Feat: Add Request Body for create, update.

* Feat: Change DTO to use representation layer purely.

* Feat: Change service method to use request body, delete files properly.

* Refactor: Remove unused method.

* Feat: Change request body for create, update. Change update to POST.

* Test: Fix test to use updated request body.

* Comment: Add newImage multipart description for updateProfessor.

* Refactor: Remove unused migrate codes.

* Refactor: change updateProfessor api to PUT

---------

Co-authored-by: 우혁준 (Logan) <whjoon0225@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants