Feat: 안전한 파일 제거 method 추가 #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huGgW
force-pushed
the
feat/transaction-safe-file-deletion
branch
from
c72800b to
133b8ad
Compare
leeeryboy
added a commit
that referenced
this pull request
Jul 16, 2024
* Feat: Internal GET, PUT API 추가 (#288) * Refactor: Remove unused interface * Feat: Create Internal Entity, Dto * Feat: Create Internal Repository, Service. * Feat: Create Internal Controller * Test: Add Test for Internal Domain. * Feat: Main API에서 중요 공지 갯수 optional하게 전달하도록 수정 (#289) * Feat: Change to get count optional for repositories. * Feat: Change service method to get important count as optional. * Feat: Change importCnt query param as optional. * 인증서 세팅 + migrate api 일부 삭제 (#290) * delete migrate api * set new ssl certificate * style: ktlint * Feat: 안전한 파일 제거 method 추가 (#291) * Feat: Create file delete event. * Feat: Create File Delete Event Listener, only delete file when transaction commit. * Feat: Add remove entity method which publish file delete event. * Refactor: change old delete method name to deprecated. --------- Co-authored-by: Junhyeong Kim <leeeryboy@gmail.com> * Feat: Staff 수정 API 추가 (#292) * Feat: Add request body for create, modify staff. * Refactor: Make DTO as representation of entity. * Refactor: Change language as changable. * Feat: Change CUD method to properly update file, search index. * Feat: Change CUD api to use proper request body, remove migrate api. * Comment: Add comment. * Test: Fix staff service test. * fix: 교수회의실 예약 권한 변경 (#293) * fix: 교수회의실 예약 권한 변경 * fix: 교수회의실 예약 권한 변경 * 로그인 취약점 수정 및 Caddyfile.dev 추가 (#295) * update deprecated methods and enable csrf * create Caddyfile.dev * add swagger reverse proxy * remove swagger related path * update api for single html page (#294) * feat: update guide * update search entity * update degree requirements * save csrf cookie (#297) * 스프링 세션 설정 변경 (#298) * fix timeout to 9h and set cookie same-site lax * disable csrf * remove unnecessary import * Feat: Professor 수정 API 추가 (#296) * Feat: Add Request Body for create, update. * Feat: Change DTO to use representation layer purely. * Feat: Change service method to use request body, delete files properly. * Refactor: Remove unused method. * Feat: Change request body for create, update. Change update to POST. * Test: Fix test to use updated request body. * Comment: Add newImage multipart description for updateProfessor. * Refactor: Remove unused migrate codes. * Refactor: change updateProfessor api to PUT --------- Co-authored-by: 우혁준 (Logan) <whjoon0225@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: 안전한 파일 제거 method 추가
한줄 요약
상세 설명
CommonFileService.removeFile이 transaction이 commit되었을 경우 event를 listen하여 주어진 경로의 파일을 제거합니다.17a02c9 Feat: Create file delete event.
998be6c Feat: Create File Delete Event Listener, only delete file when transaction commit.
eeb765d Feat: Add remove entity method which publish file delete event.
TODO
기존 deprecated된 파일 safe delete 방식 제거.