Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Staff 수정 API 추가 #292

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Feat: Staff 수정 API 추가 #292

merged 7 commits into from
Jul 11, 2024

Conversation

huGgW
Copy link
Collaborator

@huGgW huGgW commented Jul 7, 2024

Feat: Staff 수정 API 추가

한줄 요약

  • 사용하지 않고 로직이 불완전했던 staff 수정 api를 수정하여 적용했습니다.
    • 수정 시 파일과 검색을 위한 인덱스 역시 수정되도록 함.
    • response로 사용하는 dto와 request body를 분리.

TODO

Professor에 대한 같은 작업.

@huGgW huGgW requested a review from leeeryboy July 7, 2024 15:53
@huGgW huGgW self-assigned this Jul 7, 2024
Copy link

github-actions bot commented Jul 7, 2024

Test Results

12 files  12 suites   1s ⏱️
59 tests 59 ✔️ 0 💤 0
66 runs  66 ✔️ 0 💤 0

Results for commit 2de566c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@leeeryboy leeeryboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huGgW huGgW force-pushed the feat/staff-cud-implement branch from db939cb to 2de566c Compare July 11, 2024 15:22
@huGgW huGgW merged commit d341b2d into develop Jul 11, 2024
3 checks passed
@huGgW huGgW deleted the feat/staff-cud-implement branch July 11, 2024 15:34
leeeryboy added a commit that referenced this pull request Jul 16, 2024
* Feat: Internal GET, PUT API 추가 (#288)

* Refactor: Remove unused interface

* Feat: Create Internal Entity, Dto

* Feat: Create Internal Repository, Service.

* Feat: Create Internal Controller

* Test: Add Test for Internal Domain.

* Feat: Main API에서 중요 공지 갯수 optional하게 전달하도록 수정 (#289)

* Feat: Change to get count optional for repositories.

* Feat: Change service method to get important count as optional.

* Feat: Change importCnt query param as optional.

* 인증서 세팅 + migrate api 일부 삭제 (#290)

* delete migrate api

* set new ssl certificate

* style: ktlint

* Feat: 안전한 파일 제거 method 추가 (#291)

* Feat: Create file delete event.

* Feat: Create File Delete Event Listener, only delete file when transaction commit.

* Feat: Add remove entity method which publish file delete event.

* Refactor: change old delete method name to deprecated.

---------

Co-authored-by: Junhyeong Kim <leeeryboy@gmail.com>

* Feat: Staff 수정 API 추가 (#292)

* Feat: Add request body for create, modify staff.

* Refactor: Make DTO as representation of entity.

* Refactor: Change language as changable.

* Feat: Change CUD method to properly update file, search index.

* Feat: Change CUD api to use proper request body, remove migrate api.

* Comment: Add comment.

* Test: Fix staff service test.

* fix: 교수회의실 예약 권한 변경 (#293)

* fix: 교수회의실 예약 권한 변경

* fix: 교수회의실 예약 권한 변경

* 로그인 취약점 수정 및 Caddyfile.dev 추가 (#295)

* update deprecated methods and enable csrf

* create Caddyfile.dev

* add swagger reverse proxy

* remove swagger related path

* update api for single html page (#294)

* feat: update guide

* update search entity

* update degree requirements

* save csrf cookie (#297)

* 스프링 세션 설정 변경 (#298)

* fix timeout to 9h and set cookie same-site lax

* disable csrf

* remove unnecessary import

* Feat: Professor 수정 API 추가 (#296)

* Feat: Add Request Body for create, update.

* Feat: Change DTO to use representation layer purely.

* Feat: Change service method to use request body, delete files properly.

* Refactor: Remove unused method.

* Feat: Change request body for create, update. Change update to POST.

* Test: Fix test to use updated request body.

* Comment: Add newImage multipart description for updateProfessor.

* Refactor: Remove unused migrate codes.

* Refactor: change updateProfessor api to PUT

---------

Co-authored-by: 우혁준 (Logan) <whjoon0225@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants