Adding Test from TtWF #76
Conversation
Testing first paragraph of musts in 2.8.2.3
Changed value to null from undefined.
| </select> | ||
|
|
||
| <script> | ||
| (function () { |
There was a problem hiding this comment.
Wrap this all in a test() instead.
Removed mutation events (split out into other file with async on mutation observers?) and made all other indicated fixes.
Tests the namedItem() method on an HTMLOptionsCollection for correct return type/value on single match, no match, and multiple match cases.
|
These files aren't in the correct directory. |
|
Sorry. What is the corrrect directory? I'll move them. |
|
Somewhere within the html directory. |
Moved from common/ to semantics/forms/the-select-element/ per feedback from tobie. Tests should now satisfy ms2ger's code quality suggestions and tobie's placement suggestions.
|
Changed directory to more appropriate location. |
|
Critic review: https://critic.hoppipolla.co.uk/r/583 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Added some comments on critic. |
|
@grbulm there are review comments waiting for your responses over at https://critic.hoppipolla.co.uk/r/583 For example, https://critic.hoppipolla.co.uk/showcomment?chain=1670 |
|
@jgraham no responses from @grbulm on this in many months. I suggest we either close or you wrap it up yourself. |
|
?Sorry, didn't get the May message. On the January message, if I did, I might have thought getting a link to some site I'd never heard of (hoppipolla.co.uk) 9 months after the last communication was suspect and canned it. Tomorrow's a national holiday, yesterday was "bring your kids to work day," and I've got a lot to catch up for the day job. Will look at and make edits next week. From: Michael[tm] Smith notifications@github.com @jgrahamhttps://github.com/jgraham no responses from @grbulmhttps://github.com/grbulm on this in many months. I suggest we either close or you wrap it up yourself. Reply to this email directly or view it on GitHubhttps://github.com//pull/76#issuecomment-47886859. |
|
@grbulm sounds good—thanks for the update. Will keep this open |
|
Rebased and addressed comments in #1563. Thanks for the contribution, @grbulm! |
Update WebIDL submodule to latest release.
Add ability to pause after running tests
8a7ff70664 chore(package): bump version number to 8.1.0 f26e320e49 feat: always add rhs property (web-platform-tests#110) 8fc7b2ea19 docs(README): Removed redundant sections 649e457b78 chore(CHANGELOG): regenerate c1af872481 chore(package): bump version number to 8.0.1 407aaefc9f Remove m postfix from all_ws() (web-platform-tests#108) 8f7c37ea23 chore(package): bump version number to 8.0 6f86663dbc feat: support mixins + includes statements (web-platform-tests#105) d1f2352275 docs(README): fix typo 0ecc48607c BREAKING CHANGE: drop creator support (web-platform-tests#101) 4f1aab4e77 chore: drop Node 6 support (web-platform-tests#102) af08834028 style: Normalize some whitespace to pass wpt's lint (web-platform-tests#99) e938ba5eea chore(package): bump version number to 7.0 cb85ff1a02 BREAKING CHANGE: argument type should be a string 101d9067ae chore(package): bump version number 67af674490 docs(README): extended attribute type b4013a14cc feat: give extended attributes a type d15fcb28a9 Yet another innocuous change for tests dd01a2ba48 Another innocuous change for tests 706d6251d5 Innocuous change to trigger a cvs.w3.org refresh 31be15dd81 chore(package): update jsondiffpatch ca6c08ccd8 chore(CHANGELOG): regenerate 8ce266fc02 Use ES2015 syntax for tests (web-platform-tests#88) 7ffef282e1 chore(package): bump version number 9d2071443c BREAKING CHANGE: ret enum value as object (web-platform-tests#87) 8360040a9d chore(package): bump version number fa4b9a3ef1 BREAKING CHANGE: Use ES2015 syntax (web-platform-tests#84) 4252cef22e chore(package): update deps d6b17d84a1 chore(package): bump version number 174e47ea6d Check duplicated names (web-platform-tests#80) 981743ad2e remove legacycaller (web-platform-tests#79) 99100d174b Add "sequence" property to IDL Type AST definition (web-platform-tests#76) 23fc13f951 chore(CHANGELOG): regenerate 6b53eb357b chore(package): bump version dbce4340c7 feat: support TypeWithExtendedAttributes on generics (web-platform-tests#75) c5facac405 chore(CHANGELOG): regenerate 0077262a8f chore(CHANGELOG): regenerate bbbab23b3d BREAKING CHANGE: remove serializers (closes web-platform-tests#73) (web-platform-tests#74) 5d7a972728 docs(README): add namespaces (web-platform-tests#70) 1ad592c3bb chore(package): bump version 056f0cbaf8 chore(.travis): test for latest LTS/stable node versions (web-platform-tests#69) c6ef83e72f chore(pacakge): bump version f5d777c7ab fix extattr whitespace error (web-platform-tests#68) 112e8feb16 chore(package): bump version + update deps 8ec814b9f3 BREAKING CHANGE: deprecate arrays and exceptions (web-platform-tests#67) git-subtree-dir: resources/webidl2 git-subtree-split: 8a7ff70664ef54fbca77d9bda660865a369e9ce6
Testing musts in first paragraph of HTML5 2.8.2.3