Meta: export preload and alternate #5843
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24005,7 +24005,8 @@ document.body.appendChild(wbr);</code></pre> | |
| </table> | ||
|
|
||
|
|
||
| <h5 id="rel-alternate">Link type "<dfn data-export=""><code | ||
| data-x="rel-alternate">alternate</code></dfn>"</h5> | ||
|
|
||
| <p>The <code data-x="rel-alternate">alternate</code> keyword may be used with <code>link</code>, | ||
| <code>a</code>, and <code>area</code> elements.</p> | ||
|
|
@@ -24829,7 +24830,7 @@ document.body.appendChild(wbr);</code></pre> | |
| keyword.</p> | ||
|
|
||
|
|
||
| <h5>Link type "<dfn data-export=""><code data-x="rel-preload">preload</code></dfn>"</h5> | ||
|
There was a problem hiding this comment. This is going to collide with https://w3c.github.io/preload/#dfn-preload-keyword, but in w3c/preload#154, @domenic suggested moving the canonical definition here. There was a problem hiding this comment. That one isn't exported, so it won't be an immediate problem :) |
||
|
|
||
| <p>The <code data-x="rel-preload">preload</code> keyword may be used with <code>link</code> | ||
| elements. This keyword creates an <span data-x="external resource link">external resource | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're creating the first external reference, it's a good time to double-check that we have the right
data-dfn-typefor these keywords. They currently get the defaultdata-dfn-type=dfn, but something likeattr-valueseems more appropriate. We'd setdata-dfn-forto, for example,link/rel,a/rel,area/relfor the link relations that work on several elements.These also used from https://www.iana.org/assignments/link-relations/link-relations.xhtml to define header parameter values, where
attr-valuedoesn't quite fit, but we could say that's still the<{link/rel/alternate}>form.Does @tabatkins have any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to using
data-dfn-for="link/rel,a/rel,area/rel" data-dfn-type="attr-value"here. (And justdata-dfn-for="link/rel" data-dfn-type="attr-value"below.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done