[Gutenberg] Hide help button from UBE #15674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Dec 8, 2021
SiobhyB
added
[Status] Not Ready for Merge
gutenberg-mobile
Gutenberg
SiobhyB
changed the title
|
You can test the changes on this Pull Request by downloading the APKs: |
SiobhyB
changed the title
added 2 commits
December 9, 2021 15:57
'getOnGutenbergReadyExternalStyles' will fetch and return external styles defined in Gutenberg Mobile's 'external-style-overrides.css' file.
4 tasks
twstokes
reviewed
Jan 4, 2022
...r/WordPressEditor/src/main/java/org/wordpress/android/editor/WPGutenbergWebViewActivity.java
Show resolved
Hide resolved
Added following feedback here: #15674 (comment)
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses wordpress-mobile/gutenberg-mobile#4339
Related PRs and Installable Builds
Gutenberg: [RNMobile] Hide help button from UBE WordPress/gutenberg#37221Gutenberg Mobile: Hide help button from UBE gutenberg-mobile#4352WPiOS: [Gutenberg] Hide help button from UBE WordPress-iOS#17644Description
As described in wordpress-mobile/gutenberg-mobile#4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button prompts users to navigate away from the editor on Android, creating the potential for edits to be lost.
With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits. A high-level overview of the code changes can be found in the
Types of changessection of the Gutenberg PR.Testing
Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.
PR submission checklist:
RELEASE-NOTES.txtif necessary.