[Gutenberg] Hide help button from UBE #17644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
This was referenced Dec 8, 2021
SiobhyB
added
[Status] DO NOT MERGE
Gutenberg
SiobhyB
changed the title
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
added 5 commits
December 14, 2021 12:13
In order to allow custom, external CSS styles, the pattern set for allowing custom JS scripts has been followed i.e. a function similar to 'onGutenbergReadyScripts()' has been created, 'onGutenbergReadyStyles()', along with a function for processing the styles, 'loadCustomStyles()'.
SiobhyB
changed the title
twstokes
reviewed
Dec 17, 2021
WordPress/Classes/ViewRelated/Gutenberg/GutenbergWeb/GutenbergWebViewController.swift
Show resolved
Hide resolved
| @@ -82,6 +82,12 @@ class GutenbergWebViewController: GutenbergWebSingleBlockViewController, WebKitA | |||
| ].compactMap { $0 } | |||
| } | |||
|
|
|||
| override func onGutenbergReadyStyles() -> [WKUserScript] { | |||
There was a problem hiding this comment.
Just wanted to flag this comment from the Gutenberg PR about the function name.
There was a problem hiding this comment.
Thank you, changed in 9a2cf3b. Let me know if you have further thoughts on the naming, though!
added 4 commits
December 17, 2021 14:38
Following the refactoring of the SourceFile function (as outlined here: WordPress/gutenberg@0cda8b3), the loadCustomStyles function can now be simplified to just call SourceFile() directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses wordpress-mobile/gutenberg-mobile#4339
Related PRs and Installable Builds
Gutenberg: [RNMobile] Hide help button from UBE WordPress/gutenberg#37221Gutenberg Mobile: Hide help button from UBE gutenberg-mobile#4352WPAndroid: [Gutenberg] Hide help button from UBE WordPress-Android#15674Description
As described in wordpress-mobile/gutenberg-mobile#4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button has no impact on iOS.
With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits. A high-level overview of the code changes can be found in the
Types of changessection of the Gutenberg PR.Testing
Please refer to the Gutenberg PR as the "central PR" with the most up-to-date testing instructions.
PR submission checklist:
RELEASE-NOTES.txtif necessary.