-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help behavior button in Unsupported Block Editor doesn't work on iOS, loses edits on Android #4339
Comments
Ouch, the help button seems new and the UBE flow doesn't cater for it yet :(
I'd consider the second option as a stopgap solution. Then, some form of the third option. |
I've got a PR up to hide the button in WordPress/gutenberg#37221 and have requested you as a reviewer, @twstokes. Let me know if anything's unclear on it! :) I was curious about the class name associated with the button, |
@SiobhyB I'm slightly confused as this inline help work was completed as part of my work for WordPress.com. AFAIK it isn't directly connected to Gutenberg. As far as I remember the "faux" is denoting that the element is not the true Inline Help but rather simply an anchor which links back to WP.com "Calypso" where the true inline help module can be displayed. I believe the "faux" version of the button is intended to be replaced with the real inline help in the future but that will require some more work on WP.com to achieve this. If you need help reaching out to anyone at A8c on those teams please let me know. |
Just noting for posterity that @getdave and I talked "off GitHub" to share how the UBE worked (and therefore why the help button could be seen within it). He helpfully clarified again that the eventual plan is to replace the "faux" help button, so hiding it, therefore, seems like the best solution for our needs for now. |
As described in wordpress-mobile/gutenberg-mobile#4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost. With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits. A high-level overview of the code changes can be found in the `Types of changes` section below.
…n-from-ube As described in #4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost. With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits.
Describe the bug
On iOS:
On Android:
To Reproduce
On a Simple site:
Expected behavior
On web a new window is created and the authenticated session is loaded using existing cookies.
A few thoughts:
Screenshots
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: