Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help behavior button in Unsupported Block Editor doesn't work on iOS, loses edits on Android #4339

Closed
twstokes opened this issue Dec 3, 2021 · 4 comments
Assignees

Comments

@twstokes
Copy link
Contributor

twstokes commented Dec 3, 2021

Describe the bug

On iOS:

  • Tapping the Help button (question mark icon at the bottom right) while editing an unsupported block does nothing
  • Long pressing the Help button shows a WordPress.com login

On Android:

  • Tapping the Help button shows "Confirm Navigation" with options to "Stay on this page" or "Leave this page". When choosing "Leave this page", any changes to the unsupported block are lost.
  • Long pressing does nothing

To Reproduce

On a Simple site:

  1. Using a web browser, add a block that's not supported by Gutenberg Mobile (currently the Markdown block will work).
  2. Save the draft or publish the post.
  3. Load the post in the Gutenberg Mobile editor on WPiOS or WPAndroid.
  4. Choose the option to "Edit using web editor" on the unsupported block.

Expected behavior

  • Tapping the Help button shows the user some form of support (or the Help button is removed)
  • Long pressing the Help button does nothing

On web a new window is created and the authenticated session is loaded using existing cookies.

A few thoughts:

  • The user could be navigated to an entirely new web view independently of the UBE, or jump to their OS' browser (where they'll probably have to re-authenticate)
  • The button could be removed to encourage using support within the app
  • The button's action could be changed to show the app's native support view

Screenshots

iOS tap of Help button iOS long press of Help button
iOS tap of Help button

Smartphone (please complete the following information):

  • Device: iPhone 12, Pixel 4a
  • OS: iOS 15, Android 11
  • Version 1.67.0
@twstokes twstokes added Unsupported Block Editor [Type] Bug Something isn't working labels Dec 3, 2021
@hypest
Copy link
Contributor

hypest commented Dec 7, 2021

Ouch, the help button seems new and the UBE flow doesn't cater for it yet :(

  • The user could be navigated to an entirely new web view independently of the UBE, or jump to their OS' browser (where they'll probably have to re-authenticate)
  • The button could be removed to encourage using support within the app
  • The button's action could be changed to show the app's native support view

I'd consider the second option as a stopgap solution. Then, some form of the third option.

@SiobhyB
Copy link
Contributor

SiobhyB commented Dec 8, 2021

I've got a PR up to hide the button in WordPress/gutenberg#37221 and have requested you as a reviewer, @twstokes. Let me know if anything's unclear on it! :)

I was curious about the class name associated with the button, a8c-faux-inline-help, and found some background in Automattic/jetpack#18960 and Automattic/jetpack#18885. From what I've read, it seems the plan is to refactor the code around the button in the future. @getdave, can you let me know if that understanding is right? If so, maybe it'd be best to wait until the refactor before we begin any work on forwarding it to the app's built-in support?

@getdave
Copy link

getdave commented Dec 9, 2021

@SiobhyB I'm slightly confused as this inline help work was completed as part of my work for WordPress.com. AFAIK it isn't directly connected to Gutenberg.

As far as I remember the "faux" is denoting that the element is not the true Inline Help but rather simply an anchor which links back to WP.com "Calypso" where the true inline help module can be displayed.

I believe the "faux" version of the button is intended to be replaced with the real inline help in the future but that will require some more work on WP.com to achieve this.

If you need help reaching out to anyone at A8c on those teams please let me know.

@SiobhyB
Copy link
Contributor

SiobhyB commented Dec 14, 2021

Just noting for posterity that @getdave and I talked "off GitHub" to share how the UBE worked (and therefore why the help button could be seen within it). He helpfully clarified again that the eventual plan is to replace the "faux" help button, so hiding it, therefore, seems like the best solution for our needs for now.

SiobhyB pushed a commit to WordPress/gutenberg that referenced this issue Jan 14, 2022
As described in wordpress-mobile/gutenberg-mobile#4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost.

With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits. A high-level overview of the code changes can be found in the `Types of changes` section below.
SiobhyB pushed a commit that referenced this issue Jan 14, 2022
…n-from-ube

As described in #4339, a help button is currently displaying in the bottom right-hand corner of the unsupported block editor (UBE) in both the Android and iOS apps. The button can be seen while logged into WordPress.com. When tapped on, the button isn't working as expected on iOS and prompts users to navigate away from the editor on Android, creating the potential for edits to be lost.

With this PR, the button is hidden from view in order to avoid confusion and potential loss of edits.
@SiobhyB SiobhyB closed this as completed Jan 14, 2022
@fluiddot fluiddot mentioned this issue Jan 20, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants