Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.34.0 #2529

Merged
merged 73 commits into from
Aug 8, 2020
Merged

Release 1.34.0 #2529

merged 73 commits into from
Aug 8, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented Aug 3, 2020 •
edited by cameronvoell
Loading

Release for Gutenberg Mobile 1.34.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Check WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Release number was bumped in package.json and gutenberg/packages/react-native-editor/package.json.
  • Aztec dependencies are pointing to a stable release.
    • iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
    • Android: 'grep aztecVersion react-native-aztec/android/build.gradle'.
  • Gutenberg 'Podfile' and 'Podfile.lock' inside 'gutenberg/package/react-native-editor/ios/' are updated to the release number.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

Antonis Lilis and others added 30 commits July 20, 2020 18:47
MLP Android GlueCode
a6c149b
@mchowning
Update gutenberg submodule ref
bcfad45
@mchowning
Merge pull request #2485 from wordpress-mobile/update_passing_of_init…
eee29ca 
…ial_props_on_android

Update passing of initial props on android
Updated Gutenberg ref
05fb43b
@chipsnyder
Update Gutenberg commit
70dbd35
Cover block - Allow media editing (#2403)
3fb5eee 
* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref

* Update Gutenberg ref
Update Gutenberg ref (#2500)
eb81800
@SergioEstevao
Merge branch 'main' into try/bring_main_1.33.0_to_develop
1f8955a 
# Conflicts:
#	gutenberg
Merge branch 'develop' into issue/2419-MLPContainerAndroid and refere…
8f6501a 
…nce update

# Conflicts:
#	gutenberg
Gutenberg reference update
77f4aeb
Merge pull request #2494 from wordpress-mobile/issue/2419-MLPContaine…
ecccd3d 
…rAndroid

[Modal Layout Picker] Disable Page Template picker if MLP is enabled
Reference update and Merge branch 'develop' into issue/Cover_with_cus…
241aaa8 
…tom_color

# Conflicts:
#	gutenberg
Cover block - Hide media editing button for videos (#2509)
857b590 
* Update Gutenberg ref

* Update Gutenberg ref
@mchowning
Merge remote-tracking branch 'origin/develop' into HEAD
73c21f3 
Accepting conflicts to the bundle files and not updating the gutenberg
submodule ref. I will update these in follow-up commits separately.
@mchowning
Update gutenberg submodule with ref from develop
08e2c5b
@mchowning
Update bundles
7f775be
@SergioEstevao
Merge pull request #2506 from wordpress-mobile/try/bring_main_1.33.0_…
f9d28f1 
…to_develop

Bring 1.33.0 to develop
@SergioEstevao
Update GB version.
dd47b7f
Merge branch 'develop' into issue/Cover_with_custom_color
fba98a5
Bundle
0a90af5
@mchowning
Update release checklist with usage of release_automation.sh script
c5b1227
@mchowning
Add release precheck for open milestone PRs
e29768f
Merge pull request #2508 from antonis/issue/Cover_with_custom_color
7dce390 
Create cover block with custom colour (without an image)
Gutenberg reference
a659dc5
@enejb
Update the title VoiceOver label to be more clear when you are editin…
540a419 
…g the post or page titl
@enejb
Update release noted to bump version to 1.33
daee9fc
@enejb
Bump Gutenberg commit after the merge
f1d1e38
@enejb
Merge pull request #2368 from wordpress-mobile/add/accessibility-labe…
04a39c0 
…l-to-rich-text

[Gutenberg] Add AccessibilityLabel and hint to AztecViewManager
@SergioEstevao
Update GB reference.
9f00441
@SergioEstevao
Merge branch 'develop' into issue/2507_fix_link_heading_shadow
f5ea341
This was referenced Aug 3, 2020
Closed
Merged
Merged
@mchowning mchowning marked this pull request as ready for review August 3, 2020 21:29
@mchowning
Copy link
Contributor

Went through the Writing Flow tests on Android and found no issues! 👍

Writing Flow tests performed Writing Flow checklist:
  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

@ceyhun
Copy link
Contributor Author

ceyhun commented Aug 5, 2020

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

Run through it on iOS and it looks good 🎉

@pinarol
Copy link
Contributor

pinarol commented Aug 5, 2020 •
edited
Loading

Ran with WPiOS, it looks good 🎉

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-4

  • Gallery block - Settings: Link to - steps
  • Gallery block - Settings: Column number - steps
  • Gallery block - Settings: Crop images - steps

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 4

  • Columns - Check if in DarkMode all components gets proper colors - steps

MediaText-3

  • Media Text block - Insert video from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing video upload - steps

MediaText-4

  • Media Text block - Media & Text alignment - steps
  • Media Text block - Vertical alignment - steps

Shortcode-1

  • Shortcode block - Add a youtube link - steps

Cover-2

  • Cover - Add Video Background from WordPress Media library - steps
  • Cover - Replace media - steps
  • Cover - Gradient background is rendered properly - steps
  • Cover - Gradient overlay is rendered properly - steps

Social Icons - 2

  • The link sheet is opened automatically when adding new icon - steps
  • Ghost placeholder is visible when no icon is active - steps
  • Social icon forwarding to the link - steps

@chipsnyder chipsnyder mentioned this pull request Aug 5, 2020
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 7, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun ceyhun mentioned this pull request Aug 7, 2020
Merged
3 tasks
guarani
guarani approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via wordpress-mobile/WordPress-iOS#14565 (review) and wordpress-mobile/WordPress-Android#12588 (review)

cameronvoell
cameronvoell approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cameronvoell cameronvoell merged commit 7a532e7 into main Aug 8, 2020
@cameronvoell cameronvoell deleted the release/1.34.0 branch August 8, 2020 00:44
@ceyhun ceyhun mentioned this pull request Aug 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

@guarani guarani guarani approved these changes

@mchowning mchowning Awaiting requested review from mchowning

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ceyhun @mchowning @pinarol @cameronvoell @guarani @chipsnyder @SergioEstevao @enejb @lukewalczak