NSActivityOptions.IdleDisplaySleepDisabled had wrong value #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was due to an integer overflow. The original value was based on Int32 1 << 40 == 256 The correct value should be based on a UInt64. 1UL << 40 == 1099511627776
|
Hello! I'm the build bot for the Mono project. I need approval from a Mono team member to build this pull request. A team member should reply with "approve" to approve a build of this pull request, "whitelist" to whitelist this and all future pull requests from this contributor, or "build" to explicitly request a build, even if one has already been done. Contributors can ignore this message. |
|
@nberardi, |
spouliot
approved these changes
Jun 20, 2017
There was a problem hiding this comment.
@dalexsoto could you double check if it's sharpie bug ? In that case we might need to audit itger values too
Also please backport this to 15.3, thanks
|
@spouliot I am not sure I understand your comment. Do you need me to do anything with this commit? |
|
@spouliot on a seperate note, I didn't want to overload this commit. But is there a reason that NSActivityUserInitiatedAllowingIdleSystemSleep = (NSActivityUserInitiated & ~NSActivityIdleSystemSleepDisabled) |
|
@nberardi nothing else is needed from your side for this particular PR, about the second issue feel free to contribute it if you want, if not please open a bug report in http://bugzilla.xamarin.com so we do not forget. Thanks for your contribution! |
dalexsoto
approved these changes
Jun 20, 2017
|
@nberardi the comment was for Alex to follow up why this occurred. The pr itself is fine and will be merged once bots confirm it. Thanks for the contribution :) |
|
approve |
|
Build success |
rolfbjarne
approved these changes
Jun 21, 2017
dalexsoto
pushed a commit
to dalexsoto/xamarin-macios
that referenced
this pull request
Jun 21, 2017
dalexsoto
added a commit
that referenced
this pull request
Jun 21, 2017
spouliot
added a commit
that referenced
this pull request
Jul 13, 2017
* [msbuild] Re-added wildcard (*) expandsion for application-identifier in Entitlements.plist (#2186) Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=57119 * Bump mono (#2213) * Framework tests were still binding non-linked Simple class which errors now (#2216) (#2218) - Improve Makefile to rebuild when projects build with errors * Bump mono to get cecil fix for bug #56808. (#2222) https://bugzilla.xamarin.com/show_bug.cgi?id=56808 * [msbuild] Use @(ReferencePath) instead of @(ResolvedFiles) (#2188) (#2214) This allows things to work on both xbuild and msbuild. In xbuild, both lists are exactly the same and on msbuild, only @(ReferencePath) exists. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=55147 * NSActivityOptions.IdleDisplaySleepDisabled had wrong value (#2232) (#2239) This was due to an integer overflow. The original value was based on Int32 1 << 40 == 256 The correct value should be based on a UInt64. 1UL << 40 == 1099511627776 * [tests] Fix bug 57699 - [iOS]InternalsTest failure (Linkall) tests on device (#2243) Strip native debugging symbols should not be checked for debug builds * Bump mono to get fix for bug #57780. https://bugzilla.xamarin.com/show_bug.cgi?id=57780
spouliot
added a commit
that referenced
this pull request
Sep 12, 2017
* [msbuild] Re-added wildcard (*) expandsion for application-identifier in Entitlements.plist (#2186) Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=57119 * Bump mono (#2213) * Framework tests were still binding non-linked Simple class which errors now (#2216) (#2218) - Improve Makefile to rebuild when projects build with errors * Bump mono to get cecil fix for bug #56808. (#2222) https://bugzilla.xamarin.com/show_bug.cgi?id=56808 * [msbuild] Use @(ReferencePath) instead of @(ResolvedFiles) (#2188) (#2214) This allows things to work on both xbuild and msbuild. In xbuild, both lists are exactly the same and on msbuild, only @(ReferencePath) exists. Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=55147 * NSActivityOptions.IdleDisplaySleepDisabled had wrong value (#2232) (#2239) This was due to an integer overflow. The original value was based on Int32 1 << 40 == 256 The correct value should be based on a UInt64. 1UL << 40 == 1099511627776 * [tests] Fix bug 57699 - [iOS]InternalsTest failure (Linkall) tests on device (#2243) Strip native debugging symbols should not be checked for debug builds * Bump mono to get fix for bug #57780. https://bugzilla.xamarin.com/show_bug.cgi?id=57780 * Update .gitmodules Change branch to d15-3 branch of mono * Bump maccore to get fix for bug #55064. https://bugzilla.xamarin.com/show_bug.cgi?id=55064 * [mono] Bump mono to get the head of cecil/mono-2017-04 and fix IsComObject #57919 Also fix #58789 [1], the typo in tools/mtouch/Tuning.cs showing in MT0000 errors instead MT2102. That's already in master and d15-4 mono bump includes: [2] commit 2a6502cee0df9de5198eafe7c8b5f6ac25106f34 (HEAD -> d15-3, origin/d15-3) Merge: 02457c20fcf 5e05cafc6f1 Author: Luis Aguilera <luis.aguilera@xamarin.com> Date: Fri Aug 18 10:04:06 2017 -0400 Merge pull request #5401 from marek-safar/com [Marshal.IsComObject] Make this predicate return false instead of thr… [3] commit 02457c20fcf57c0610e844d638eb1da82b5d1eb0 Merge: da80840ea55 73fd9a1b82e Author: Luis Aguilera <luis.aguilera@xamarin.com> Date: Fri Aug 18 09:59:06 2017 -0400 Merge pull request #5400 from spouliot/bump-cecil-58834-d15-3 [cecil] Bump to the head of the mono-2017-04 branch and pick the fix for bug #58834 References [1] https://bugzilla.xamarin.com/show_bug.cgi?id=58789 [2] https://bugzilla.xamarin.com/show_bug.cgi?id=57919 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=58834 * [mtouch] Put 'mono_profiler_startup_log' in the symbol list. Fixes #58778. (#2501) We need the 'mono_profiler_startup_log' symbol when profiling is enabled, so make sure to add the symbol to the correct list of symbols we need. Previously we were passing `-u _mono_profiler_startup_log` to clang directly, which is fine, but not complete, since it does not write the symbol to the symbollist file (--symbollist=file), which means it wouldn't be preserved when the MSBuild tasks strip the executable. https://bugzilla.xamarin.com/show_bug.cgi?id=58778 * Bump versions for SR3 https://trello.com/c/EVze08ei * Bump mono to include HttpClientHandler fix #44027 https://trello.com/c/jYFXadH8/8-systemnethttp-close-request-stream-when-httpclienthandler https://bugzilla.xamarin.com/show_bug.cgi?id=44027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to an integer overflow. The original value was based on
Int32The correct value should be based on a
UInt64.Reference documentation.
https://developer.apple.com/documentation/foundation/nsactivityoptions/nsactivityidledisplaysleepdisabled?language=objc