logwarn, logerr behavior #147
Comments
|
Thanks for reporting, that is definitely a bug. I was able to reproduce this on my machine (with Python 3). I'll look deeper into it, I suspect the python nodes are not properly flushing their stderr for some reason, because the messages appear as soon as the node exits. |
xqms
added a commit
that referenced
this issue
Jul 2, 2021
|
Should be fixed now in master. Could you please test if both issues are gone now? |
|
It works (ROS Melodic on Ubuntu 18.04). Will this be in a melodic release soon? |
gauthamm
added a commit
to rapyuta-robotics/rosmon
that referenced
this issue
Jul 15, 2021
* core: launch_config: parse attributes in parent context and make it mutable (required for $(anon)) * core: launch_config: handle $(anon) in ParseContext, see xqms#100 * core: test: node_utils: more debug output * core: test: test_subst: test for nested $(anon), see xqms#100 * fix two typos in the README * rosmon_core: fix a lot of whitespace issues introduced in xqms#76 * rosmon_core: option to obey output="XY" tags (see xqms#108) Co-authored-by: Roger Pi <u1926981@campus.udg.edu> * rosmon_core: unit test for output-attr parsing, refs xqms#108 * fix xqms#110 * rosmon_core: do not print node prefix in --disable-ui mode --disable-ui is mostly used with ncurses-like nodes that have problems with such additional outputs. * rosmon_core: node_monitor: flush out remaining node output after node exit * rosmon_core: new rosmon-disable-ui attribute for problematic launch files * core: launch_config: accept empty yaml node * rosmon_core: LaunchConfig warnings to stderr & make them captureable * rosmon_core: test: unit tests for the warnings we trigger * rosmon_core: Add YAML merge key parsing functionality. * rosmon_core: Adding fix for rosparam parsing to equivilate with undocumented behavior of roslaunch * rosmon_core: test: unit tests for merge keys feature * rosmon_core: ui: UI DrawStatus optimized to only refresh on events. * core: launch: add some comments & fix whitespace * rosmon_core: depend on python2/3 conditioned on ROS_PYTHON_VERSION * core: launch: add comments * core: ui: just redraw on every keystroke * core: launch: shift some node attributes into context See xqms#116 * rosmon_core: parse scope attributes also for launch, include, group tags * core: launch: make "enable-coredumps" a scoped attribute * core: test: add test for scoped attributes on include tags * core: monitor: support for systemd-coredump * core: monitor: delete working directories from two runs ago * capture stderr separately and correctly do output=log * roscore: test: Fixing unit tests for stdout_stderr mod * Adding alt. stderr output filter * CHANGELOG * CHANGELOG * 2.3.0 * rosmon_core: cmake: request specific boost_python3 version * rosmon_core: test: adapt test_node to python 3 * CHANGELOG * 2.3.1 * rosmon_core: *really* fix search for boost_python for python 3 * rosmon_core: cmake: increase minimum version to address policy warnings * CHANGELOG * 2.3.2 * rosmon_core: cmake: older cmake versions don't have GREATER_EQUAL * all: increase cmake minimum version to 3.4 * README: add installation hint for rosmon_core * core: launch_config: loadYAMLParams: don't scope keys with leading slash See xqms#130 for bug report. Basically, roslaunch respects leading slashes during key resolution, we don't. We don't know what's better, but we have to match whatever roslaunch is doing, as always. * core: test: xml: rosparam: test leading slashes in keys * core: consolidate floating point types used for stats Fixes problems identified with -Wfloat-conversion * core: ui: explicit float casts Fixes problems identified with -Wfloat-conversion. * rqt: make float/int casts explicit Identified with -Wfloat-conversion. * rosmon_core: env-hooks: follow symbolic links during file name suggestion This fixes bash completion for colcon linked install spaces. * core: substitution_python: catch by reference Fixes a compiler warning on Ubuntu Focal. * core: ui: display & search full name including namespace * core: ui: use full name everywhere * Start all and stop all options are added F6 -> start all F7 -> stop all * core: launch: bytes_parser: add missing include * Added option --stdout-print-source to print out node name when --disable-ui is used. Addresses xqms#139. * Removed stdout-print-source option and print node name by default when --disable-ui is used. Right justify node names to the max node name length. * core: fix compilation on Kinetic (boost::placeholders came later) * core: monitor: do not leak stderr file descriptors * core: launch_config: add warning for type= attrs on <param> tags on Kinetic See xqms#138. * update warning * core: launch_config: strip off leading/trailing whitespace of params * core: add utility to precisely dump ROS parameters This is useful to analyze differences between roslaunch and rosmon in parameter loading. * core: launch_config: use double precision for auto type parameters Previously we used floats, but XmlRpc stores doubles, so we should make use of the full precision. * core: launch_config: convert tabs + newlines in parameters * core: test: add unit test for all sorts of whitespace in parameters * core: test: basic.launch: make it work with roslaunch * core: test: basic.py: adapt to fixed whitespace behavior * core: fix aliasing problem using std::memcpy * Resolves xqms#145 by providing a number of restarts threshold per node via ROS-launch arguments * core: fix signed/unsigned comparison warning * core: install tests (necessary for testing with colcon) * core: monitor: use a second PTY for stderr, see xqms#147 * Inidicate when a node is actually Idle (e.g. stopped) * Add missing dependency on libboost-pyhton-dev Co-authored-by: Max Schwarz <max.schwarz@ais.uni-bonn.de> Co-authored-by: Max Schwarz <max.schwarz@online.de> Co-authored-by: Roger Pi <u1926981@campus.udg.edu> Co-authored-by: Kazuhiro Hiratsuka <papino0319@gmail.com> Co-authored-by: marco-tranzatto <marcot@ethz.ch> Co-authored-by: Carl Colena <carl.colena@gmail.com> Co-authored-by: Kutay YILMAZ <ktyylmz035@gmail.com> Co-authored-by: Steve Golton <stevegolton@gmail.com> Co-authored-by: mcfurry <f.b.f.schoenmakers@gmail.com> Co-authored-by: Ferry Schoenmakers <ferry.schoenmakers@nobleo.nl> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
gauthamm
pushed a commit
to rapyuta-robotics/rosmon
that referenced
this issue
Jul 15, 2021
|
Thanks for the feedback. I'll create a new release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I'm having a bit of an issue with logging. I'm running a node using Python 3 (need a
python3only module) and usingasyncio. I was getting all my "INFO" logs in the monitor, but none of the "WARN" or "ERROR" level logs.A couple of things I noticed/confirmed during debugging:
/rosout(confirmed withrostopic echo)roslaunchandrosmon)I'm sure there's something different about how rosmon captures the logs, but I wasn't able to find documentation anywhere. Can I get some help? I could make all my logs info, but I'd prefer not to...
The text was updated successfully, but these errors were encountered: