Adding ros_diagnostics publication into rosmon_core. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xqms
requested changes
Apr 1, 2019
There was a problem hiding this comment.
Thanks for the update!
In general, rosmon source code uses tabs for indentation, please adapt. We use tabs for the current indentation level, and spaces for aligning within that indentation level. (Sorry, we don't have a coding style document right now).
What do you think about renaming the "limits" to "warnings"? If someone reads rosmon-memory-limit he/she might think that rosmon actually limits the available memory. I know that name was partly my suggestion, but this just occurred to me...
See the inline stuff for further comments.
| @@ -0,0 +1,52 @@ | |||
| #include <gtest/gtest.h> | |||
There was a problem hiding this comment.
I much prefer catch_ros as the unit testing framework, as this is already used everywhere else in rosmon. If you are not familiar with it, I can convert your testcase later on, no problem.
Closed
added 3 commits
April 8, 2019 07:29
…e method signature to not use argument as return value.
Extracting memory string generation into a function, and using the same notation conventions (KiB, MiB ...) as elsewhere in the project.
xqms
requested changes
Apr 8, 2019
added 5 commits
April 11, 2019 11:25
|
Thanks for the update 👍
|
|
I can't really understand why the CI test fail on jenkins. we have the following error on the ros build farm : On my computer when I try to run this test I have another error ! Do you have any idea ? |
|
On my system the test fails with exactly the same exception as on the CI server. Maybe you did not build To replicate & debug, you can do: Full backtrace: It's failing here: I guess the |
xqms
approved these changes
May 8, 2019
|
Okay, I did the port to Open todos:
|
The old ones already gave a warning for an idling python ROS node.
|
Seems to work in the workspaces I have for testing. I raised the default memory & CPU limits though, many nodes use more than 50MB memory and that's not a problem on most platforms. I'll wait for CI results and then we can merge :-) |
|
Seems to work in the workspaces I use for testing. I raised the default memory & CPU limits though, there are were many nodes using more than 50MB RAM where I would say that is not a problem. Let's go ahead and merge this! :-) |
|
huh, strange issue with the comment timestamps, sorry for the double post. Somehow I'm able to write from the future... |
xqms
added a commit
that referenced
this pull request
Dec 27, 2019
gauthamm
added a commit
to rapyuta-robotics/rosmon
that referenced
this pull request
Jul 15, 2021
* core: launch_config: parse attributes in parent context and make it mutable (required for $(anon)) * core: launch_config: handle $(anon) in ParseContext, see xqms#100 * core: test: node_utils: more debug output * core: test: test_subst: test for nested $(anon), see xqms#100 * fix two typos in the README * rosmon_core: fix a lot of whitespace issues introduced in xqms#76 * rosmon_core: option to obey output="XY" tags (see xqms#108) Co-authored-by: Roger Pi <u1926981@campus.udg.edu> * rosmon_core: unit test for output-attr parsing, refs xqms#108 * fix xqms#110 * rosmon_core: do not print node prefix in --disable-ui mode --disable-ui is mostly used with ncurses-like nodes that have problems with such additional outputs. * rosmon_core: node_monitor: flush out remaining node output after node exit * rosmon_core: new rosmon-disable-ui attribute for problematic launch files * core: launch_config: accept empty yaml node * rosmon_core: LaunchConfig warnings to stderr & make them captureable * rosmon_core: test: unit tests for the warnings we trigger * rosmon_core: Add YAML merge key parsing functionality. * rosmon_core: Adding fix for rosparam parsing to equivilate with undocumented behavior of roslaunch * rosmon_core: test: unit tests for merge keys feature * rosmon_core: ui: UI DrawStatus optimized to only refresh on events. * core: launch: add some comments & fix whitespace * rosmon_core: depend on python2/3 conditioned on ROS_PYTHON_VERSION * core: launch: add comments * core: ui: just redraw on every keystroke * core: launch: shift some node attributes into context See xqms#116 * rosmon_core: parse scope attributes also for launch, include, group tags * core: launch: make "enable-coredumps" a scoped attribute * core: test: add test for scoped attributes on include tags * core: monitor: support for systemd-coredump * core: monitor: delete working directories from two runs ago * capture stderr separately and correctly do output=log * roscore: test: Fixing unit tests for stdout_stderr mod * Adding alt. stderr output filter * CHANGELOG * CHANGELOG * 2.3.0 * rosmon_core: cmake: request specific boost_python3 version * rosmon_core: test: adapt test_node to python 3 * CHANGELOG * 2.3.1 * rosmon_core: *really* fix search for boost_python for python 3 * rosmon_core: cmake: increase minimum version to address policy warnings * CHANGELOG * 2.3.2 * rosmon_core: cmake: older cmake versions don't have GREATER_EQUAL * all: increase cmake minimum version to 3.4 * README: add installation hint for rosmon_core * core: launch_config: loadYAMLParams: don't scope keys with leading slash See xqms#130 for bug report. Basically, roslaunch respects leading slashes during key resolution, we don't. We don't know what's better, but we have to match whatever roslaunch is doing, as always. * core: test: xml: rosparam: test leading slashes in keys * core: consolidate floating point types used for stats Fixes problems identified with -Wfloat-conversion * core: ui: explicit float casts Fixes problems identified with -Wfloat-conversion. * rqt: make float/int casts explicit Identified with -Wfloat-conversion. * rosmon_core: env-hooks: follow symbolic links during file name suggestion This fixes bash completion for colcon linked install spaces. * core: substitution_python: catch by reference Fixes a compiler warning on Ubuntu Focal. * core: ui: display & search full name including namespace * core: ui: use full name everywhere * Start all and stop all options are added F6 -> start all F7 -> stop all * core: launch: bytes_parser: add missing include * Added option --stdout-print-source to print out node name when --disable-ui is used. Addresses xqms#139. * Removed stdout-print-source option and print node name by default when --disable-ui is used. Right justify node names to the max node name length. * core: fix compilation on Kinetic (boost::placeholders came later) * core: monitor: do not leak stderr file descriptors * core: launch_config: add warning for type= attrs on <param> tags on Kinetic See xqms#138. * update warning * core: launch_config: strip off leading/trailing whitespace of params * core: add utility to precisely dump ROS parameters This is useful to analyze differences between roslaunch and rosmon in parameter loading. * core: launch_config: use double precision for auto type parameters Previously we used floats, but XmlRpc stores doubles, so we should make use of the full precision. * core: launch_config: convert tabs + newlines in parameters * core: test: add unit test for all sorts of whitespace in parameters * core: test: basic.launch: make it work with roslaunch * core: test: basic.py: adapt to fixed whitespace behavior * core: fix aliasing problem using std::memcpy * Resolves xqms#145 by providing a number of restarts threshold per node via ROS-launch arguments * core: fix signed/unsigned comparison warning * core: install tests (necessary for testing with colcon) * core: monitor: use a second PTY for stderr, see xqms#147 * Inidicate when a node is actually Idle (e.g. stopped) * Add missing dependency on libboost-pyhton-dev Co-authored-by: Max Schwarz <max.schwarz@ais.uni-bonn.de> Co-authored-by: Max Schwarz <max.schwarz@online.de> Co-authored-by: Roger Pi <u1926981@campus.udg.edu> Co-authored-by: Kazuhiro Hiratsuka <papino0319@gmail.com> Co-authored-by: marco-tranzatto <marcot@ethz.ch> Co-authored-by: Carl Colena <carl.colena@gmail.com> Co-authored-by: Kutay YILMAZ <ktyylmz035@gmail.com> Co-authored-by: Steve Golton <stevegolton@gmail.com> Co-authored-by: mcfurry <f.b.f.schoenmakers@gmail.com> Co-authored-by: Ferry Schoenmakers <ferry.schoenmakers@nobleo.nl> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
gauthamm
pushed a commit
to rapyuta-robotics/rosmon
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my pull request for the feature that add ros diagnostics into rosmon core instead of adding it as a third part node.