Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-sys master merge #966

Merged
merged 44 commits into from
Feb 26, 2020
Merged

web-sys master merge #966

merged 44 commits into from
Feb 26, 2020

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Feb 25, 2020 •
edited
Loading

So here I thought I was extremely smart by merging commits to not end up having to rebase, turns out you can't really squash merge commits.

If somebody has a suggestion how to clean this up I'm all ears.

Additionally I removed most Options in services, as removing cancel from Task made those absolute. Somebody correct me if this was wrong.

See #961.

jstarry and others added 30 commits January 26, 2020 17:36
@jstarry
Move tests (#897)
38f4054
@ctm @jstarry
Allow binary-only and text-only websocket connects (#389) (#851)
a42cca3 
This allows the various formats (e.g., CBOR) that can't be converted
in or out of Text to be used in a websocket by specifying you want to
use a binary-only connection.  A text-only connection is provided for
symmetry.
@kakoc @jstarry
fix(task): remove cancel method from Task trait(#884) (#899)
5629f37 
In order to avoid misuse It was decided to remove `cancel` from `Task` trait
and delegate such logic to `Drop`.
@leordev @jstarry
fix native_worker.js 404 error (#900)
d1180c0 
* fix native_worker.js 404 error

* fix contribute link

* drops contribute link
@jplatte
Simplify yew-macro a bit (#902)
063c254 
* yew-macro: Simplify Properties validation

* Fix most clippy warnings
@jstarry
Fix clippy warnings (#912)
c422a5e
@jstarry
Fix component rendering process (#913)
3dca0c7 
* wip

* Fix component rendering process
@jstarry
Fix ResizeTask drop (#915)
ee4792c
@jstarry
Implement PartialEq for ChildrenRenderer (#916)
aedce8b
@jstarry
Rename NodeRef.try_into to avoid trait conflicts (#917)
87f76f7
Fix wrong order of classes when reordering or adding classes to the f…
839b793 
…ront (#927)

* Fix wrong order of classes when reordering or adding classes in the front/middle (#926)

* Fix coding style (#926)

* Use set_attribute(class, className) for classes (#926)
@jstarry
Update README.md
12981dd
@jstarry
Clean up readme (#930)
f703bdd 
* Clean up README

* Remove bors
@jstarry
Update README.md
bf0a6bb
@jplatte
ComponentLink: Allow send_message and send_message_batch through shar…
1ede167 
…ed references (#931)
@llebout @jstarry
Implement more of FetchOptions (#602)
12da2b5 
* Implement more of FetchOptions

Add referrer, referrer_policy and integrity

* Pass options to Request constructor instead of fetch

* Derive Debug on ReferrerPolicy and Referrer

* WIP: Add tests

* Add tests for referrer and redirect

* Add FetchService `integrity` field test

* Add FetchService `integrity` field fail test and refactor

* Add FetchService `referrer_policy` field tests

Co-authored-by: Justin Starry <justin.m.starry@gmail.com>
fix: link all outstanding TODO items to a ticket (#949)
df14a9f 
Signed-off-by: Matthew Fisher <matt.fisher@microsoft.com>
@jstarry
Prepare v0.12 release (#953)
6cc4449
@jstarry
Update CHANGELOG.md
a5e74e7
@Fi3
Add components interaction example (#951)
b534a4c 
This add a small example of how to use agents in order to send
messages between components.
@captain-yossarian
Fix contributing test instructions (#957)
92aab6c
@mdtusz
Add WebGL example (#908)
90a7cdb
@daxpedda
Merge commit 'Allow binary-only and text-only websocket connects (#389)…
62a68ab 
… (#851)' into web-sys-fixes
@jstarry
Bump rust version for macro tests (#965)
6a75932
@daxpedda
Merge commit '5629f37b575c0c0468ad867975a09d07381710db' into web-sys-…
da9e93e 
…fixes
@daxpedda
Remove Option from most services.
e35d5e1
@daxpedda
Merge commit 'd1180c0369edfc6f19f539a448e6d9bdfeb1a077' into web-sys-…
bd43d37 
…fixes
@daxpedda
Merge commit '063c25472efcc79c017eecd73da9fbd062aa3550' into web-sys-…
05a0854 
…fixes
@daxpedda
Merge commit 'c422a5ed1b4f82f986b3293c465eb825ea72a656' into web-sys-…
a2152aa 
…fixes
@daxpedda
Merge commit '3dca0c775869f5bb28e00acbba2f97d5af1aa8f5' into web-sys-…
2c6e8c7 
…fixes
@daxpedda
Merge commit 'ee4792c7f6350962afd9e605b6c1c09731ed4c9c' into web-sys-…
86a4a77 
…fixes
@daxpedda
Remove Option from resize service.
84e2802
@daxpedda
Merge commit 'aedce8bfbcdaaadc815fd4c01a65d36eb43a6ce1' into web-sys-…
b0639f4 
…fixes
@daxpedda
Merge commit '87f76f7736cb8c063ff291e99d43d1941c4509e4' into web-sys-…
07da4ed 
…fixes
@daxpedda
Merge commit '839b793b17241783d60d4bd25acb2c41599b2081' into web-sys-…
05ff2ce 
…fixes
@daxpedda
Merge commit '1ede16795a8f08975708e1808c0d528f31d5c946' into web-sys-…
2cb6ae9 
…fixes
@daxpedda
Merge commit '12da2b5119abbaa17e1b2ce88740f650d035284a' into web-sys-…
7019d20 
…fixes
@daxpedda
Apply fetch changes.
2ce21b7
@daxpedda
Merge commit 'df14a9fc3e74c697e1e5e201f35fd177b83065ae' into web-sys-…
c69c370 
…fixes
@daxpedda
Apply reader service changes.
8b7ab86
@daxpedda
Merge commit 'a5e74e7d1dd42362abb902b13498911c269841cc' into web-sys-…
7ebf37e 
…fixes
@daxpedda
Merge commit 'b534a4c83a3f4dabcfa39ddf582515091a6539dd' into web-sys-…
2a9fb99 
…fixes
@daxpedda
Merge commit '6a759329d1a5a49d062e6265b1435f8dff54c6f4' into web-sys-…
8fddbab 
…fixes
@daxpedda
Fix node_refs example.
4790b33
@jstarry
Copy link
Member

jstarry commented Feb 26, 2020

So here I thought I was extremely smart by merging commits to not end up having to rebase, turns out you can't really squash merge commits.
If somebody has a suggestion how to clean this up I'm all ears.

This is fine with me, adding more merge commits at this point is not really hurting anything.

Additionally I removed most Options in services, as removing cancel from Task made those absolute. Somebody correct me if this was wrong.

Lgtm

@jstarry jstarry merged commit 4b43e24 into yewstack:web-sys Feb 26, 2020
@daxpedda daxpedda deleted the web-sys-fixes branch February 26, 2020 05:33
@jetli
Copy link
Contributor

jetli commented Feb 26, 2020

This is huge and really cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.