Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Follow up for prompt on saving to another context #325

Closed

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Mar 29, 2024

Changelog Description

Fix for implementation of #261

  • Remove logic that would always update before save/open anyway (and as such the dialog itself didn't make any sense)
  • Also update task on the instances instead of only folderPath

Additional info

This also fixes that before opening a scene in another context that maya was actually resetting time range, fps, etc. always even though it would be opening a file anyway - optimizing opening workfiles in other contexts because of that.

Testing notes:

  1. Save into a different folder or task
  2. When picking no options (or cancelling) on the prompt - nothing should update
  3. When clicking ok with certain options, only those options should update.

@ynbot ynbot added size/XS host: Maya type: enhancement Improvement of existing functionality or minor addition labels Mar 29, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 1, 2024
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my side.

@@ -653,10 +653,6 @@ def on_task_changed():
"Can't set project for new context because path does not exist: {}"
).format(workdir))

with lib.suspended_refresh():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only @antirotor can tell if this is ok.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic removed here was basically replaced by an artist facing prompt on file save to another context in the PR here #261

@BigRoy BigRoy closed this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants