Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya: Fix: Do not always reset context on task change #359

Merged

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Apr 3, 2024

Changelog Description

Fix for implementation of #261

  • Remove logic that would always update before save/open anyway (and as such the dialog itself didn't make any sense)

Additional info

This also fixes that before opening a scene in another context that maya was actually resetting time range, fps, etc. always even though it would be opening a file anyway - optimizing opening workfiles in other contexts because of that.

Note that the Task does not update on context change/resets. For that you'll need PR: #358

Testing notes:

  1. Save into a different folder or task
  2. When picking no options (or cancelling) on the prompt - nothing should update
  3. When clicking ok with certain options, only those options should update.

@ynbot ynbot added size/XS host: Maya type: enhancement Improvement of existing functionality or minor addition labels Apr 3, 2024
@BigRoy BigRoy changed the title Maya: Follow up for prompt on saving to another context Maya: Fix: Do not always reset context on task change Apr 3, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Apr 3, 2024
@BigRoy BigRoy requested a review from moonyuet April 3, 2024 15:49
Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested successfully in maya 2023. When changing different context and hit okay, the instance name changed as followed. And when changing different context and hit cancel, the instance name and context won't be changed as expected.

Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool!
Thanks.

@moonyuet moonyuet merged commit 194e415 into ynput:develop Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members host: Maya size/XS type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants