Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[narando] Add new extractor #18260

Closed
wants to merge 5 commits into from
Closed

Conversation

ealgase
Copy link
Contributor

@ealgase ealgase commented Nov 21, 2018

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request adds support for the website narando.com as described in #18252 (but does not close it, as that issue also includes support for the Narando player embedded in other sites).

This is my first contribution here, and while I've done my best to comply with the coding conventions, I'm almost certain it's not perfect. In particular, I'm unsure of the best way to use one extractor within another. If you find any issues, please tell me.

@ealgase ealgase changed the title Narando player [narando] Add new extractor Nov 21, 2018
@ealgase ealgase closed this Nov 21, 2018
@ealgase
Copy link
Contributor Author

ealgase commented Nov 21, 2018

Sorry, realized that this fails compilation (originally worked on my end). I'll resubmit when everything checks out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant