Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linux binary expectations #12622

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Update linux binary expectations #12622

merged 6 commits into from
Jun 4, 2024

Conversation

ConradIrwin
Copy link
Member

@ConradIrwin ConradIrwin commented Jun 4, 2024

Fixes #12585

This changes the expectations for installed binaries on linux based on work
that @jirutka has done for Alpine.

In particular, we now put the cli in place as bin/zed and the zed binary as
libexec/zed-editor, and assume that packagers do the same.

cc @someone13574

Release notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 4, 2024
@zed-industries-bot
Copy link

zed-industries-bot commented Jun 4, 2024

Warnings
⚠️

This PR is missing release notes.

Please add a "Release Notes" section that describes the change:

Release Notes:

- (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

If your change is not user-facing, you can use "N/A" for the entry:

Release Notes:

- N/A

Generated by 🚫 dangerJS against e3cdf0f

@ConradIrwin ConradIrwin force-pushed the zeditor branch 3 times, most recently from 8566b14 to 9d98bb5 Compare June 4, 2024 02:56
@AnInternetTroll
Copy link

Hi, I am not a Zed developer but I am interested in zed as a linux user.

In void linux we already have a binary named zed, which comes from zfs
https://openzfs.github.io/openzfs-docs/man/v2.2/8/zed.8.html

If Zed's binary will be called zed then it will either conflict with the zfs package or void will change Zed's zed to some other name (zed-cli? Zed? not sure)

Could you consider using another name?

@mikayla-maki
Copy link
Contributor

@AnInternetTroll Given that this is specific to a single filesystem, I think we'd be ok with Void patching the binary name. cc: @ConradIrwin for his take, but it's more 'standard' for our binary to match our name IMO :)

@someone13574
Copy link
Contributor

someone13574 commented Jun 4, 2024

Why are there two binaries in the first place? Could they be merged or is it a requirement on Mac that they are separate?

Edit: Could you just symlink the binary in the app bundle to a file in path?

@Calandracas606
Copy link

Calandracas606 commented Jun 4, 2024

i expect that the conflict with openzfs' "ZFS Event Daemon" (zed) will occur in other distribution's as well. it's easy for downstream packagers to rename the binary to Zed, but would this cause any runtime problems? if at some point the application invokes the zed binary, things may not work as expected.

A possible solution might be to call the binary zed-cli, and have zed (or Zed) symlink to it

@someone13574
Copy link
Contributor

Maybe have a file, similar to RELEASE_CHANNEL, which sets any references to the executable name used at compile time (iirc, the cli search’s for it, so this would otherwise need to be patched).

@jirutka
Copy link

jirutka commented Jun 4, 2024

In void linux we already have a binary named zed, which comes from zfs

Uh, I hadn’t noticed that; you’re right, we have that in Alpine Linux as well. This is a problem, so I’m thinking about renaming zed to zed-editor.

@mikayla-maki
Copy link
Contributor

zed to zed-editor

zeditor? :D

Co-Authored-By: Mikayla <mikayla@zed.dev>
@mikayla-maki
Copy link
Contributor

@jirutka Thank you for all of your feedback. We've adjusted the documentation to be clear about the current state of Zed and how that relates to distros. Let's continue the conversation on the relevant issues :)

@mikayla-maki mikayla-maki merged commit 27beb9e into main Jun 4, 2024
8 checks passed
@mikayla-maki mikayla-maki deleted the zeditor branch June 4, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expected installation paths on Linux, name of cli binary
7 participants