-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update linux binary expectations #12622
Conversation
|
8566b14
to
9d98bb5
Compare
Hi, I am not a Zed developer but I am interested in zed as a linux user. In void linux we already have a binary named If Zed's binary will be called Could you consider using another name? |
@AnInternetTroll Given that this is specific to a single filesystem, I think we'd be ok with Void patching the binary name. cc: @ConradIrwin for his take, but it's more 'standard' for our binary to match our name IMO :) |
Why are there two binaries in the first place? Could they be merged or is it a requirement on Mac that they are separate? Edit: Could you just symlink the binary in the app bundle to a file in path? |
i expect that the conflict with openzfs' "ZFS Event Daemon" (zed) will occur in other distribution's as well. it's easy for downstream packagers to rename the binary to A possible solution might be to call the binary |
Maybe have a file, similar to RELEASE_CHANNEL, which sets any references to the executable name used at compile time (iirc, the cli search’s for it, so this would otherwise need to be patched). |
Uh, I hadn’t noticed that; you’re right, we have that in Alpine Linux as well. This is a problem, so I’m thinking about renaming |
|
Co-Authored-By: Mikayla <mikayla@zed.dev>
@jirutka Thank you for all of your feedback. We've adjusted the documentation to be clear about the current state of Zed and how that relates to distros. Let's continue the conversation on the relevant issues :) |
Fixes #12585
This changes the expectations for installed binaries on linux based on work
that @jirutka has done for Alpine.
In particular, we now put the cli in place as
bin/zed
and the zed binary aslibexec/zed-editor
, and assume that packagers do the same.cc @someone13574
Release notes: