Red 1950 unskip tests #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecoologic
commented
Oct 9, 2023
| @@ -28,7 +27,7 @@ public function testInstall() | |||
| $this->client->chat->apps()->install($postFields); | |||
| }, 'apps/installations.json', 'POST', [ | |||
| 'postFields' => $postFields, | |||
| 'apiBasePath' => '/api/chat/', | |||
| 'apiBasePath' => '/api/v2/' | |||
There was a problem hiding this comment.
This is another case where I think the tests were failing even "back in the days". Very confusing.
ecoologic
force-pushed
the
RED-1950-unskip-tests
branch
from
e8514d9
to
b172ff4
Compare
ecoologic
force-pushed
the
RED-1950-unskip-tests
branch
from
b172ff4
to
617b010
Compare
ecoologic
force-pushed
the
RED-1950-unskip-tests
branch
from
9446f0c
to
ac68725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing what started in the #508. Unskipping the tests that work and fixing code that didn't. I also tested the code in a separate consumer.