Bluetooth: controller: PHY Update Procedure #11

cvinayak · 2017-04-29T05:11:49Z

Draft work in progress pull request of PHY Update Procedure implementation.

This change is

cvinayak · 2017-05-01T05:24:21Z

@carlescufi Missing define in MDK, nRF52832 supports 2M PHY as per documentation at http://infocenter.nordicsemi.com/topic/com.nordic.infocenter.nrf52832.ps.v1.1/radio.html?cp=2_2_0_22_13_10#register.MODE

carlescufi · 2017-05-02T08:09:05Z

@cvinayak I will push a patch to update the MDK today

carlescufi · 2017-05-03T14:19:21Z

subsys/bluetooth/controller/Kconfig

@@ -200,6 +207,13 @@ config BLUETOOTH_CONTROLLER_SCHED_ADVANCED
 	  Disabling this feature will lead to overlapping role in timespace
 	  leading to skipped events amongst active roles.

+config BLUETOOTH_CONTROLLER_TIFS_HW


Unless you have a very good reason not to use the hw TIFS switching I don't see why you couldn't remove this Kconfig option and use the hardware when available (compiling for nRF52 and higher)

One, due to the nature of NRF_RADIO->PACKETPTR being common to Rx and Tx, using the hw switching will still need timers+ppis to watch(dog) whether ISR has run on time, to avoid packet buffer corruption and/or spurious transmissions.
Two, Kconfig option enables application developer in making the choice, lower power hard realtime vs slightly higher power consumption due to use of (watchdog) timer to skip events under occasional latencies on Radio ISR.

Scale the ctrl pkt enqueue implementation to allow multiple ctrl packets to be enqueued. This will aid in the graceful implementation of parallel control procedure collisions. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

Add support for Bluetooth v5.0 PHY Update Procedure. Jira: ZEP-2086 Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

* This commit adds an implementation of the page_layout API call to the Winbond W25Q series driver. * Added data structure flash_w25qxxxx_pages_layout that describes the Flash chip's layout of erasable units. * Added function spi_flash_wb_page_layout that creates the Page Layout Table containing the above single page layout descriptor. * Updated the page_layout pointer in the driver API struct. * Added Doxygen-style documentation to all added code. * Closes zephyrproject-rtos#11

Fix audio distortions

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write zephyrproject-rtos#1: 16 bytes (0 bps) Write zephyrproject-rtos#2: 32 bytes (3445948416 bps) Write zephyrproject-rtos#3: 48 bytes (2596929536 bps) Write zephyrproject-rtos#4: 64 bytes (6400 bps) Write zephyrproject-rtos#5: 80 bytes (8533 bps) Write zephyrproject-rtos#6: 96 bytes (10666 bps) Write zephyrproject-rtos#7: 112 bytes (8533 bps) Write zephyrproject-rtos#8: 128 bytes (9955 bps) Write zephyrproject-rtos#9: 144 bytes (11377 bps) Write zephyrproject-rtos#10: 160 bytes (7680 bps) Write zephyrproject-rtos#11: 176 bytes (8533 bps) Write zephyrproject-rtos#12: 192 bytes (9386 bps) Write Complete (err 0) Write zephyrproject-rtos#13: 208 bytes (8533 bps) Write zephyrproject-rtos#14: 224 bytes (9244 bps) Write zephyrproject-rtos#15: 240 bytes (9955 bps) Write zephyrproject-rtos#16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This makes the gatt metrics also available for gatt write-without-rsp-cb so it now prints the rate of each write: uart:~$ gatt write-without-response-cb 1e ff 10 10 Write #1: 16 bytes (0 bps) Write #2: 32 bytes (3445948416 bps) Write #3: 48 bytes (2596929536 bps) Write #4: 64 bytes (6400 bps) Write #5: 80 bytes (8533 bps) Write #6: 96 bytes (10666 bps) Write #7: 112 bytes (8533 bps) Write #8: 128 bytes (9955 bps) Write #9: 144 bytes (11377 bps) Write #10: 160 bytes (7680 bps) Write #11: 176 bytes (8533 bps) Write #12: 192 bytes (9386 bps) Write Complete (err 0) Write #13: 208 bytes (8533 bps) Write #14: 224 bytes (9244 bps) Write #15: 240 bytes (9955 bps) Write #16: 256 bytes (8000 bps) Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

Adds in detection of entering apple's MFI mode 2 state and then decrypts mode 2 packets and passes them along to higher levels of the stack. Mode 2 is entered by the iphone first pausing encryption and then re-starting it. After this, all encrypted packets coming from the iphone use mode 2 regardless of whether they're standard BLE packets or audio packets.

Flush all messages and invoke `abort()` when a k_panic() or k_oops() is hit in native_posix mode. One of the main purposes of `native_posix` is to provide debug convenience. When running in a debugger, `abort()` stops execution which provides a backtrace and the ability to inspect all variables. A practical use case is fuzzing failures in SOF, see an example in: thesofproject/sof#8632 In such a case, this commit adds value even before using a debugger. Without this commit, confusingly meaningless stack trace: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb Exiting due to fatal error ==314134== ERROR: libFuzzer: fuzz target exited #0 0x81d9637 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9637) #1 0x80cc42b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc42b) zephyrproject-rtos#2 0x80ab79e in fuzzer::Fuzzer::ExitCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab864 in fuzzer::Fuzzer::StaticExitCallback() (zephyr.exe+ zephyrproject-rtos#4 0xf783dfe8 (/usr/lib32/libc.so.6+0x3dfe8) zephyrproject-rtos#5 0xf783e1e6 in exit (/usr/lib32/libc.so.6+0x3e1e6) zephyrproject-rtos#6 0x82a5488 in posix_exit boards/posix/native_posix/main.c:51:2 SUMMARY: libFuzzer: fuzz target exited ``` Thanks to this commit the `k_panic()` location is immediately available in the logs without even running anything: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb ==315176== ERROR: libFuzzer: deadly signal LLVMSymbolizer: error reading file: No such file or directory #0 0x81d9647 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9647) #1 0x80cc43b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc43b) zephyrproject-rtos#2 0x80ab6be in fuzzer::Fuzzer::CrashCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab77b in fuzzer::Fuzzer::StaticCrashSignalCallback() zephyrproject-rtos#4 0xf7f3159f (linux-gate.so.1+0x59f) zephyrproject-rtos#5 0xf7f31578 (linux-gate.so.1+0x578) zephyrproject-rtos#6 0xf788ea16 (/usr/lib32/libc.so.6+0x8ea16) zephyrproject-rtos#7 0xf783b316 in raise (/usr/lib32/libc.so.6+0x3b316) zephyrproject-rtos#8 0xf7822120 in abort (/usr/lib32/libc.so.6+0x22120) zephyrproject-rtos#9 0x82afbde in ipc_cmd src/ipc/ipc3/handler.c:1623:2 NOTE: libFuzzer has rudimentary signal handlers. Combine libFuzzer with AddressSanitizer or similar for better crash reports. SUMMARY: libFuzzer: deadly signal ``` Full stack trace When running zephyr.exe in gdb: ``` ./scripts/fuzz.sh -- -DEXTRA_CFLAGS="-O0 -g3" gdb ./zephyr.exe backtrace zephyrproject-rtos#2 0xf783b317 in raise () from /usr/lib32/libc.so.6 zephyrproject-rtos#3 0xf7822121 in abort () from /usr/lib32/libc.so.6 zephyrproject-rtos#4 0x082afbdf in ipc_cmd (_hdr=0x8b...) at src/ipc/ipc3/handler.c:1623 zephyrproject-rtos#5 0x082fbf4b in ipc_platform_do_cmd (ipc=0x8b161c0) at src/platform/posix/ipc.c:162 zephyrproject-rtos#6 0x082e1e07 in ipc_do_cmd (data=0x8b161c0 <heapmem+1472>) at src/ipc/ipc-common.c:328 zephyrproject-rtos#7 0x083696aa in task_run (task=0x8b161e8 <heapmem+1512>) at zephyr/include/rtos/task.h:94 zephyrproject-rtos#8 0x083682dc in edf_work_handler (work=0x8b1621c <heapmem+1564>) at zephyr/edf_schedule.c:32 zephyrproject-rtos#9 0x085245af in work_queue_main (workq_ptr=0x8b15b00 <edf_workq>,...) at zephyr/kernel/work.c:688 zephyrproject-rtos#10 0x0823a6bc in z_thread_entry (entry=0x8523be0 <work_queue_main>,.. at zephyr/lib/os/thread_entry.c:48 zephyrproject-rtos#11 0x0829a6a1 in posix_arch_thread_entry (pa_thread_status=0x8630648 .. at zephyr/arch/posix/core/thread.c:56 zephyrproject-rtos#12 0x0829c043 in posix_thread_starter (arg=0x4) at zephyr/arch/posix/core/posix_core.c:293 zephyrproject-rtos#13 0x080f6041 in asan_thread_start(void*) () zephyrproject-rtos#14 0xf788c73c in ?? () from /usr/lib32/libc.so.6 ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>

Flush all messages and invoke `abort()` when a k_panic() or k_oops() is hit in native_posix mode. One of the main purposes of `native_posix` is to provide debug convenience. When running in a debugger, `abort()` stops execution which provides a backtrace and the ability to inspect all variables. A good, sample use case is fuzzing failures in SOF, see an example in: thesofproject/sof#8632 In such a case, this commit adds value even before using a debugger. Without this commit, confusingly meaningless stack trace: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb Exiting due to fatal error ==314134== ERROR: libFuzzer: fuzz target exited #0 0x81d9637 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9637) #1 0x80cc42b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc42b) zephyrproject-rtos#2 0x80ab79e in fuzzer::Fuzzer::ExitCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab864 in fuzzer::Fuzzer::StaticExitCallback() (zephyr.exe+ zephyrproject-rtos#4 0xf783dfe8 (/usr/lib32/libc.so.6+0x3dfe8) zephyrproject-rtos#5 0xf783e1e6 in exit (/usr/lib32/libc.so.6+0x3e1e6) zephyrproject-rtos#6 0x82a5488 in posix_exit boards/posix/native_posix/main.c:51:2 SUMMARY: libFuzzer: fuzz target exited ``` Thanks to this commit the `k_panic()` location is now immediately available in test logs without even running anything locally: ``` INFO: seed corpus: files: 1097 min: 1b max: 428b total: 90853b rss: 58Mb @ WEST_TOPDIR/sof/src/ipc/ipc3/handler.c:1623 ZEPHYR FATAL ERROR: 3 ==315176== ERROR: libFuzzer: deadly signal LLVMSymbolizer: error reading file: No such file or directory #0 0x81d9647 in __sanitizer_print_stack_trace (zephyr.exe+0x81d9647) #1 0x80cc43b in fuzzer::PrintStackTrace() (zephyr.exe+0x80cc43b) zephyrproject-rtos#2 0x80ab6be in fuzzer::Fuzzer::CrashCallback() FuzzerLoop.cpp.o zephyrproject-rtos#3 0x80ab77b in fuzzer::Fuzzer::StaticCrashSignalCallback() zephyrproject-rtos#4 0xf7f3159f (linux-gate.so.1+0x59f) zephyrproject-rtos#5 0xf7f31578 (linux-gate.so.1+0x578) zephyrproject-rtos#6 0xf788ea16 (/usr/lib32/libc.so.6+0x8ea16) zephyrproject-rtos#7 0xf783b316 in raise (/usr/lib32/libc.so.6+0x3b316) zephyrproject-rtos#8 0xf7822120 in abort (/usr/lib32/libc.so.6+0x22120) zephyrproject-rtos#9 0x82afbde in ipc_cmd src/ipc/ipc3/handler.c:1623:2 NOTE: libFuzzer has rudimentary signal handlers. Combine libFuzzer with AddressSanitizer or similar for better crash reports. SUMMARY: libFuzzer: deadly signal ``` The full stack trace is now immediately available when running zephyr.exe in gdb: ``` ./scripts/fuzz.sh -- -DEXTRA_CFLAGS="-O0 -g3" gdb build-fuzz/zephyr/zephyr.exe run backtrace zephyrproject-rtos#2 0xf783b317 in raise () from /usr/lib32/libc.so.6 zephyrproject-rtos#3 0xf7822121 in abort () from /usr/lib32/libc.so.6 zephyrproject-rtos#4 0x082afbdf in ipc_cmd (_hdr=0x8b...) at src/ipc/ipc3/handler.c:1623 zephyrproject-rtos#5 0x082fbf4b in ipc_platform_do_cmd (ipc=0x8b161c0) at src/platform/posix/ipc.c:162 zephyrproject-rtos#6 0x082e1e07 in ipc_do_cmd (data=0x8b161c0 <heapmem+1472>) at src/ipc/ipc-common.c:328 zephyrproject-rtos#7 0x083696aa in task_run (task=0x8b161e8 <heapmem+1512>) at zephyr/include/rtos/task.h:94 zephyrproject-rtos#8 0x083682dc in edf_work_handler (work=0x8b1621c <heapmem+1564>) at zephyr/edf_schedule.c:32 zephyrproject-rtos#9 0x085245af in work_queue_main (workq_ptr=0x8b15b00 <edf_workq>,...) at zephyr/kernel/work.c:688 zephyrproject-rtos#10 0x0823a6bc in z_thread_entry (entry=0x8523be0 <work_queue_main>,.. at zephyr/lib/os/thread_entry.c:48 zephyrproject-rtos#11 0x0829a6a1 in posix_arch_thread_entry (pa_thread_status=0x8630648 .. at zephyr/arch/posix/core/thread.c:56 zephyrproject-rtos#12 0x0829c043 in posix_thread_starter (arg=0x4) at zephyr/arch/posix/core/posix_core.c:293 zephyrproject-rtos#13 0x080f6041 in asan_thread_start(void*) () zephyrproject-rtos#14 0xf788c73c in ?? () from /usr/lib32/libc.so.6 ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>

….do_not_recovery_i2c_bus Lotus: don't recovery the i2c bus when the bus is idle

Replace ACPI_VM0.bin and acrn.bin in acrn-binaries to transition to ACRN 2.7. Signed-off-by: NingX Zhao <ningx.zhao@intel.com>

…ble-baudrate Lucas/variable baudrate

cvinayak force-pushed the github_bluetooth_phy_upd branch from 9ece5ca to 009588f Compare April 29, 2017 05:13

nashif assigned jhedberg Apr 29, 2017

cvinayak force-pushed the github_bluetooth_phy_upd branch from 009588f to 74c88a5 Compare May 1, 2017 04:51

jhedberg force-pushed the bluetooth branch from 1914fc3 to e588ca0 Compare May 1, 2017 12:55

cvinayak force-pushed the github_bluetooth_phy_upd branch from 74c88a5 to 00c3e88 Compare May 1, 2017 21:09

jhedberg assigned carlescufi and unassigned jhedberg May 2, 2017

cvinayak force-pushed the github_bluetooth_phy_upd branch from 00c3e88 to da064c7 Compare May 2, 2017 12:23

cvinayak changed the base branch from bluetooth to master May 2, 2017 13:35

cvinayak force-pushed the github_bluetooth_phy_upd branch from da064c7 to 36c8f45 Compare May 3, 2017 13:41

cvinayak changed the title ~~DRAFT: Bluetooth: controller: PHY Update Procedure~~ Bluetooth: controller: PHY Update Procedure May 3, 2017

carlescufi reviewed May 3, 2017

View reviewed changes

cvinayak force-pushed the github_bluetooth_phy_upd branch from 36c8f45 to 44f3545 Compare May 4, 2017 03:50

cvinayak added 2 commits May 5, 2017 12:01

Bluetooth: controller: PHY Update Procedure

3fe6eaf

Add support for Bluetooth v5.0 PHY Update Procedure. Jira: ZEP-2086 Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>

cvinayak force-pushed the github_bluetooth_phy_upd branch from 44f3545 to 3fe6eaf Compare May 5, 2017 10:01

cvinayak closed this May 5, 2017

This was referenced Sep 23, 2017

Tinycrypt SHA256 test blocks at test vector 13 and 14 with microkernel #2637

Closed

Disabling advertising gets stuck #3774

Closed

NULL pointer read in udp, tcp, context net tests #3800

Closed

hakehuang mentioned this pull request Aug 28, 2018

Shell_module@mimxrt1050_evk runs failure on R1.13_RC1 #9651

Closed

magilus mentioned this pull request Feb 3, 2019

Dead loop of the kernel during Bluetooth Mesh pressure communication #12726

Closed

This was referenced Jun 13, 2019

kernel timeout_list repeatedly add a thread #16793

Closed

Bluetooth: Mesh: Rx buffer exhaustion causes deadlock #16864

Closed

xiaoliang314 mentioned this pull request Jun 26, 2019

Bluetooth: Fix various deadlock issues when running low on buffers #16870

Closed

finikorg pushed a commit to finikorg/zephyr that referenced this pull request Aug 27, 2019

Merge pull request zephyrproject-rtos#11 from dcpleung/sof/fix-audio

06e8ff3

Fix audio distortions

vikrant8052 mentioned this pull request Dec 1, 2019

samples: mesh: nrf52: improved coding style, way to save default & target values on flash #21014

Merged

zephyrbot mentioned this pull request Apr 22, 2020

net: socket: syscall for socketpair(2) #24367

Closed

Philipp-Wohlgenannt-Tridonic-com mentioned this pull request May 26, 2020

net: openthread: Add config for NCP vendor hook #25450

Closed

anchao mentioned this pull request Jul 30, 2020

Bluetooth: Mesh: Fix tx seg buffer with NULL pointer reference #27251

Merged

RafaelLeeImg mentioned this pull request Jan 19, 2022

Kernel usage fault when using semaphore with multi-threading #41963

Closed

piotrParf mentioned this pull request Feb 9, 2022

BLE Testing functions do not work properly #42534

Closed

WolsYang mentioned this pull request Jul 14, 2022

WS2812 driver not work on nRF52833DK #47780

Closed

sjanc mentioned this pull request May 16, 2023

Assert when executing GATT/SR/GAW/BV-14-C test #57930

Closed

talih0 mentioned this pull request Dec 13, 2023

subsys: shell_telent: don't close connection on EAGAIN #66287

Merged

kiram9 added a commit to FrameworkComputer/zephyr that referenced this pull request Apr 22, 2024

Merge pull request zephyrproject-rtos#11 from FrameworkComputer/lotus…

7b88e17

….do_not_recovery_i2c_bus Lotus: don't recovery the i2c bus when the bus is idle

ldenefle added a commit to ldenefle/zephyr that referenced this pull request Aug 2, 2024

Merge pull request zephyrproject-rtos#11 from converge-io/lucas/varia…

6f84f6a

…ble-baudrate Lucas/variable baudrate

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bluetooth: controller: PHY Update Procedure #11

Bluetooth: controller: PHY Update Procedure #11

cvinayak commented Apr 29, 2017 •

edited by galak

Loading

cvinayak commented May 1, 2017

carlescufi commented May 2, 2017

carlescufi May 3, 2017

cvinayak May 3, 2017

Bluetooth: controller: PHY Update Procedure #11

Bluetooth: controller: PHY Update Procedure #11

Conversation

cvinayak commented Apr 29, 2017 • edited by galak Loading

cvinayak commented May 1, 2017

carlescufi commented May 2, 2017

carlescufi May 3, 2017

Choose a reason for hiding this comment

cvinayak May 3, 2017

Choose a reason for hiding this comment

cvinayak commented Apr 29, 2017 •

edited by galak

Loading